loplugin:unusedmethods unused return value in include/sfx2

Change-Id: Id4017bdfe18f8224d28a9f787865c7a880aeeed8

16 files changed, 26 insertions, 44 deletions

diff --git a/include/sfx2/app.hxx b/include/sfx2/app.hxx
index d00aa953b001..ed618d974854 100644
--- a/include/sfx2/app.hxx
+++ b/include/sfx2/app.hxx
@@ -175,10 +175,10 @@ public:
     css::script::XLibraryContainer * GetDialogContainer();
     css::script::XLibraryContainer * GetBasicContainer();
     static StarBASIC*           GetBasic();
-    sal_uInt16                  SaveBasicAndDialogContainer() const;
+    void                        SaveBasicAndDialogContainer() const;
 
     // misc.
-    bool                        GetOptions(SfxItemSet &);
+    void                        GetOptions(SfxItemSet &);
     void                        SetOptions(const SfxItemSet &);
     virtual void                Invalidate(sal_uInt16 nId = 0) override;
     void                        NotifyEvent(const SfxEventHint& rEvent, bool bSynchron = true );
@@ -189,7 +189,7 @@ public:
     SAL_DLLPRIVATE SfxDispatcher* GetDispatcher_Impl();
 
     SAL_DLLPRIVATE void         SetOptions_Impl(const SfxItemSet &);
-    SAL_DLLPRIVATE bool         Initialize_Impl();
+    SAL_DLLPRIVATE void         Initialize_Impl();
 
     SAL_DLLPRIVATE SfxAppData_Impl* Get_Impl() const { return pAppData_Impl; }
 
diff --git a/include/sfx2/docfile.hxx b/include/sfx2/docfile.hxx
index d60596d54bfe..2dc8014c8fa4 100644
--- a/include/sfx2/docfile.hxx
+++ b/include/sfx2/docfile.hxx
@@ -61,7 +61,7 @@ class SFX2_DLLPUBLIC SfxMedium : public SvRefBase
 
     SAL_DLLPRIVATE void SetIsRemote_Impl();
     SAL_DLLPRIVATE void CloseInStream_Impl();
-    SAL_DLLPRIVATE bool CloseOutStream_Impl();
+    SAL_DLLPRIVATE void CloseOutStream_Impl();
     SAL_DLLPRIVATE void CloseStreams_Impl();
 
     SAL_DLLPRIVATE void SetEncryptionDataToStorage_Impl();
@@ -204,10 +204,10 @@ public:
     SAL_DLLPRIVATE void SetStorage_Impl( const css::uno::Reference< css::embed::XStorage >& xNewStorage );
 
     SAL_DLLPRIVATE void CloseAndReleaseStreams_Impl();
-    SAL_DLLPRIVATE sal_uInt16 AddVersion_Impl( css::util::RevisionTag& rVersion );
+    SAL_DLLPRIVATE void AddVersion_Impl( css::util::RevisionTag& rVersion );
     SAL_DLLPRIVATE bool TransferVersionList_Impl( SfxMedium& rMedium );
-    SAL_DLLPRIVATE bool SaveVersionList_Impl( bool bUseXML );
-    SAL_DLLPRIVATE bool RemoveVersion_Impl( const OUString& rVersion );
+    SAL_DLLPRIVATE void SaveVersionList_Impl( bool bUseXML );
+    SAL_DLLPRIVATE void RemoveVersion_Impl( const OUString& rVersion );
 
     SAL_DLLPRIVATE void SetExpired_Impl( const DateTime& rDateTime );
     SAL_DLLPRIVATE SvKeyValueIterator* GetHeaderAttributes_Impl();
@@ -243,7 +243,7 @@ public:
 
     SAL_DLLPRIVATE bool StorageCommit_Impl();
 
-    SAL_DLLPRIVATE bool TransactedTransferForFS_Impl( const INetURLObject& aSource,
+    SAL_DLLPRIVATE void TransactedTransferForFS_Impl( const INetURLObject& aSource,
                              const INetURLObject& aDest,
                              const css::uno::Reference< css::ucb::XCommandEnvironment >& xComEnv );
 
diff --git a/include/sfx2/docmacromode.hxx b/include/sfx2/docmacromode.hxx
index 2a9efc8429a6..7011f93ece4d 100644
--- a/include/sfx2/docmacromode.hxx
+++ b/include/sfx2/docmacromode.hxx
@@ -83,7 +83,7 @@ namespace sfx2
 
             see getCurrentMacroExecMode
         */
-        virtual bool
+        virtual void
                     setCurrentMacroExecMode( sal_uInt16 ) = 0;
 
         /** returns the origin of the document
diff --git a/include/sfx2/ipclient.hxx b/include/sfx2/ipclient.hxx
index b836bf41ca58..590ec7f8d0b7 100644
--- a/include/sfx2/ipclient.hxx
+++ b/include/sfx2/ipclient.hxx
@@ -71,7 +71,7 @@ public:
     Rectangle           GetObjArea() const;
     Rectangle           GetScaledObjArea() const;
     void                SetSizeScale( const Fraction & rScaleWidth, const Fraction & rScaleHeight );
-    bool                SetObjAreaAndScale( const Rectangle&, const Fraction&, const Fraction& );
+    void                SetObjAreaAndScale( const Rectangle&, const Fraction&, const Fraction& );
     const Fraction&     GetScaleWidth() const;
     const Fraction&     GetScaleHeight() const;
     void                Invalidate();
diff --git a/include/sfx2/linkmgr.hxx b/include/sfx2/linkmgr.hxx
index c6cbcf000960..ab59dddc1ed8 100644
--- a/include/sfx2/linkmgr.hxx
+++ b/include/sfx2/linkmgr.hxx
@@ -91,13 +91,13 @@ public:
     bool        Insert( SvBaseLink* pLink );
 
     // the links connect to a SvLinkSource and adds to the list
-    bool        InsertDDELink( SvBaseLink*,
+    void        InsertDDELink( SvBaseLink*,
                         const OUString& rServer,
                         const OUString& rTopic,
                         const OUString& rItem );
 
     // if everything is already set at the link!
-    bool        InsertDDELink( SvBaseLink* );
+    void        InsertDDELink( SvBaseLink* );
 
     // Connect the links to a pseudo-object and add to the list
     bool InsertFileLink( sfx2::SvBaseLink&,
diff --git a/include/sfx2/lnkbase.hxx b/include/sfx2/lnkbase.hxx
index fe5c881440da..5baabf44b808 100644
--- a/include/sfx2/lnkbase.hxx
+++ b/include/sfx2/lnkbase.hxx
@@ -136,7 +136,7 @@ public:
     void                 SetUpdateMode( SfxLinkUpdateMode );
     SfxLinkUpdateMode    GetUpdateMode() const;
     SotClipboardFormatId GetContentType() const;
-    bool                 SetContentType( SotClipboardFormatId nType );
+    void                 SetContentType( SotClipboardFormatId nType );
 
     LinkManager*          GetLinkManager();
     const LinkManager*    GetLinkManager() const;
diff --git a/include/sfx2/mnumgr.hxx b/include/sfx2/mnumgr.hxx
index 2adb619d9f28..7682fc624464 100644
--- a/include/sfx2/mnumgr.hxx
+++ b/include/sfx2/mnumgr.hxx
@@ -86,10 +86,10 @@ public:
     // Changing code which relies on Popup would need much more effort.
     static SfxPopupMenuManager* Popup( const ResId& rResId, SfxViewFrame* pFrame,const Point& rPoint, vcl::Window* pWindow );
 
-    sal_uInt16              Execute( const Point& rPos, vcl::Window *pWindow );
+    void                Execute( const Point& rPos, vcl::Window *pWindow );
 
     void                RemoveDisabledEntries();
-    Menu*                   GetSVMenu();
+    Menu*               GetSVMenu();
 };
 
 #endif // INCLUDED_SFX2_MNUMGR_HXX
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index 6fd70b2828b6..47f804293b62 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -318,7 +318,7 @@ public:
      *
      * @return true if the initialization is successful, false otherwise.
      */
-    bool                        DoInitUnitTest();
+    void                        DoInitUnitTest();
     bool                        DoInitNew( SfxMedium* pMedium=nullptr );
     bool                        DoLoad( SfxMedium* pMedium );
     bool                        DoLoadExternal( SfxMedium* pMed );
@@ -624,7 +624,7 @@ public:
     virtual bool    IsChangeRecording() const;
     virtual bool    HasChangeRecordProtection() const;
     virtual void    SetChangeRecording( bool bActivate );
-    virtual bool    SetProtectionPassword( const OUString &rPassword );
+    virtual void    SetProtectionPassword( const OUString &rPassword );
     virtual bool    GetProtectionHash( /*out*/ css::uno::Sequence< sal_Int8 > &rPasswordHash );
 
     SAL_DLLPRIVATE std::shared_ptr<GDIMetaFile> CreatePreviewMetaFile_Impl( bool bFullContent ) const;
diff --git a/include/sfx2/printer.hxx b/include/sfx2/printer.hxx
index f6cda406ca41..1e9c05bb03a0 100644
--- a/include/sfx2/printer.hxx
+++ b/include/sfx2/printer.hxx
@@ -53,7 +53,7 @@ public:
     VclPtr<SfxPrinter>      Clone() const;
 
     static VclPtr<SfxPrinter> Create( SvStream &rStream, SfxItemSet *pOptions );
-    SvStream&               Store( SvStream &rStream ) const;
+    void                    Store( SvStream &rStream ) const;
 
     const SfxItemSet&       GetOptions() const { return *pOptions; }
     void                    SetOptions( const SfxItemSet &rNewOptions );
diff --git a/include/sfx2/shell.hxx b/include/sfx2/shell.hxx
index a976c933651e..488e06b8b65d 100644
--- a/include/sfx2/shell.hxx
+++ b/include/sfx2/shell.hxx
@@ -281,7 +281,7 @@ public:
     /**
         Asynchronous ExecuteSlot for the RELOAD
         */
-    const SfxPoolItem*          ExecuteSlot( SfxRequest &rReq, bool bAsync );
+    void                        ExecuteSlot( SfxRequest &rReq, bool bAsync );
 
     inline SfxItemPool&         GetPool() const;
     inline void                 SetPool( SfxItemPool *pNewPool ) ;
diff --git a/include/sfx2/sidebar/FocusManager.hxx b/include/sfx2/sidebar/FocusManager.hxx
index a7ffd5e1ffa2..71096cbaa78b 100644
--- a/include/sfx2/sidebar/FocusManager.hxx
+++ b/include/sfx2/sidebar/FocusManager.hxx
@@ -131,9 +131,9 @@ private:
     void FocusPanelContent(const sal_Int32 nPanelIndex);
     void FocusButton(const sal_Int32 nButtonIndex);
     void ClickButton(const sal_Int32 nButtonIndex);
-    bool MoveFocusInsidePanel(const FocusLocation& rLocation,
+    void MoveFocusInsidePanel(const FocusLocation& rLocation,
                               const sal_Int32 nDirection);
-    bool MoveFocusInsideDeckTitle(const FocusLocation& rLocation,
+    void MoveFocusInsideDeckTitle(const FocusLocation& rLocation,
                                   const sal_Int32 nDirection);
 
     void HandleKeyEvent(const vcl::KeyCode& rKeyCode,
diff --git a/include/sfx2/styfitem.hxx b/include/sfx2/styfitem.hxx
index c35ea6ccc1fd..64d092690c35 100644
--- a/include/sfx2/styfitem.hxx
+++ b/include/sfx2/styfitem.hxx
@@ -80,11 +80,8 @@ public:
         requested bitmap mode, incremented by 1.</p>
 
         <p>Usually, you will use the same resource which originally constructed the object.</p>
-
-        @return
-            <TRUE/> if an image list for the requested mode could be found in the given resource.
     */
-    bool    updateImages( const ResId& _rId );
+    void    updateImages( const ResId& _rId );
 };
 
 #endif
diff --git a/include/sfx2/tbxctrl.hxx b/include/sfx2/tbxctrl.hxx
index 241e7a47efe7..b971be938910 100644
--- a/include/sfx2/tbxctrl.hxx
+++ b/include/sfx2/tbxctrl.hxx
@@ -79,7 +79,7 @@ friend class SfxFrameStatusListener;
     css::uno::Reference< css::lang::XComponent >           m_xStatusListener;
 
 private:
-    SfxFrameStatusListener* GetOrCreateStatusListener();
+    void                    GetOrCreateStatusListener();
 
     SfxPopupWindow(SfxPopupWindow &) = delete;
     void operator =(SfxPopupWindow &) = delete;
diff --git a/include/sfx2/templateabstractview.hxx b/include/sfx2/templateabstractview.hxx
index bd2b59030597..2ff5a26c596b 100644
--- a/include/sfx2/templateabstractview.hxx
+++ b/include/sfx2/templateabstractview.hxx
@@ -61,21 +61,6 @@ protected:
     FILTER_APPLICATION mApp;
 };
 
-class ViewFilter_Keyword
-{
-public:
-
-    ViewFilter_Keyword (const OUString &rKeyword)
-        : maKeyword(rKeyword)
-    {}
-
-    bool operator () (const ThumbnailViewItem *pItem);
-
-private:
-
-    OUString maKeyword;
-};
-
 class SFX2_DLLPUBLIC TemplateAbstractView : public ThumbnailView
 {
 public:
diff --git a/include/sfx2/viewfrm.hxx b/include/sfx2/viewfrm.hxx
index 5134da26edbc..6c4d090d43b3 100644
--- a/include/sfx2/viewfrm.hxx
+++ b/include/sfx2/viewfrm.hxx
@@ -141,8 +141,8 @@ public:
     void                    UpdateTitle();
 
     // interne Handler
-    SAL_DLLPRIVATE bool SetBorderPixelImpl( const SfxViewShell *pSh, const SvBorder &rBorder );
-    SAL_DLLPRIVATE const SvBorder& GetBorderPixelImpl( const SfxViewShell *pSh ) const;
+    SAL_DLLPRIVATE void SetBorderPixelImpl( const SfxViewShell *pSh, const SvBorder &rBorder );
+    SAL_DLLPRIVATE const SvBorder& GetBorderPixelImpl() const;
     SAL_DLLPRIVATE void InvalidateBorderImpl( const SfxViewShell *pSh );
 
     virtual SfxObjectShell* GetObjectShell() override;
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index f19d66a36420..c5e5a6380bad 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -304,7 +304,7 @@ public:
     SAL_DLLPRIVATE void ResetAllClients_Impl( SfxInPlaceClient *pIP );
     SAL_DLLPRIVATE void DiscardClients_Impl();
 
-    SAL_DLLPRIVATE SfxPrinter* SetPrinter_Impl( VclPtr<SfxPrinter>& pNewPrinter );
+    SAL_DLLPRIVATE void SetPrinter_Impl( VclPtr<SfxPrinter>& pNewPrinter );
     SAL_DLLPRIVATE bool IsShowView_Impl() const;
 
     SAL_DLLPRIVATE bool HandleNotifyEvent_Impl( NotifyEvent& rEvent );