diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-28 10:35:49 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-28 12:07:54 +0100 |
| commit | bc539bd3c04964471af6b5ca54264215c8995696 (patch) | |
| tree | c37af5b9fb3dc0b8677fc8dd535fb8e93ad6039d /idlc | |
| parent | 9f78a4174e5099ad3af65a23e158a51c1afca54d (diff) | |
loplugin:stringadd improve detection
if one side of the expression is a compile-time-constant, we don't need
to worry about side-effects on the other side
Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b
Reviewed-on: https://gerrit.libreoffice.org/81589
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'idlc')
| -rw-r--r-- | idlc/source/options.cxx | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/idlc/source/options.cxx b/idlc/source/options.cxx index d9b0003a60cb..2f2e3bb1e6f9 100644 --- a/idlc/source/options.cxx +++ b/idlc/source/options.cxx @@ -285,8 +285,7 @@ bool Options::initOptions(std::vector< std::string > & rArgs) { return badOption("invalid", option); } - OString param("-D"); - param += OString((*first).c_str(), (*first).size()); + OString param = "-D" + rtl::OStringView((*first).c_str(), (*first).size()); if (m_options.count("-D") > 0) { param = m_options["-D"] + " " + param; @@ -393,8 +392,8 @@ OString Options::prepareHelp() const " -verbose = verbose output.\n" " -w = display warning messages.\n" " -we = treat warnings as errors.\n" - " -h|-? = print this help message and exit.\n\n"; - help += prepareVersion(); + " -h|-? = print this help message and exit.\n\n" + + prepareVersion(); return help; } |