summaryrefslogtreecommitdiff
path: root/idlc
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2017-01-26 12:28:58 +0100
committerStephan Bergmann <sbergman@redhat.com>2017-01-26 12:54:43 +0000
commite57ca02849c3d87142ff5ff9099a212e72b8139c (patch)
treebcce66b27261553c308779f3e8663a269ed3a671 /idlc
parent8802ebd5172ec4bc412a59d136c82b77ab452281 (diff)
Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'idlc')
-rw-r--r--idlc/inc/options.hxx9
-rw-r--r--idlc/source/options.cxx5
2 files changed, 5 insertions, 9 deletions
diff --git a/idlc/inc/options.hxx b/idlc/inc/options.hxx
index 212faf3187d6..4c30bcc40db8 100644
--- a/idlc/inc/options.hxx
+++ b/idlc/inc/options.hxx
@@ -46,11 +46,9 @@ public:
static bool checkCommandFile(std::vector< std::string > & rArgs, char const * filename);
/// @throws IllegalArgument
- bool initOptions(std::vector< std::string > & rArgs)
- throw(IllegalArgument);
+ bool initOptions(std::vector< std::string > & rArgs);
/// @throws IllegalArgument
- static bool badOption(char const * reason, std::string const & rArg)
- throw(IllegalArgument);
+ static bool badOption(char const * reason, std::string const & rArg);
bool setOption(char const * option, std::string const & rArg);
OString prepareHelp();
@@ -59,8 +57,7 @@ public:
const OString& getProgramName() const { return m_program;}
bool isValid(const OString& option);
/// @throws IllegalArgument
- const OString& getOption(const OString& option)
- throw( IllegalArgument );
+ const OString& getOption(const OString& option);
const std::vector< OString >& getInputFiles() const { return m_inputFiles; }
bool readStdin() const { return m_stdin; }
diff --git a/idlc/source/options.cxx b/idlc/source/options.cxx
index 0d02236cac47..794f7929ad33 100644
--- a/idlc/source/options.cxx
+++ b/idlc/source/options.cxx
@@ -174,7 +174,7 @@ bool Options::checkCommandFile (std::vector< std::string > & rArgs, char const *
return (fclose(fp) == 0);
}
-bool Options::badOption(char const * reason, std::string const & rArg) throw(IllegalArgument)
+bool Options::badOption(char const * reason, std::string const & rArg)
{
OStringBuffer message;
if (reason != nullptr)
@@ -216,7 +216,7 @@ OString convertIncPathtoShortWindowsPath(const OString& incPath) {
}
#endif
-bool Options::initOptions(std::vector< std::string > & rArgs) throw(IllegalArgument)
+bool Options::initOptions(std::vector< std::string > & rArgs)
{
std::vector< std::string >::const_iterator first = rArgs.begin(), last = rArgs.end();
for (; first != last; ++first)
@@ -427,7 +427,6 @@ bool Options::isValid(const OString& option)
}
const OString& Options::getOption(const OString& option)
- throw( IllegalArgument )
{
if (!isValid(option))
{