diff options
author | Michael Stahl <mstahl@redhat.com> | 2017-11-29 15:18:12 +0100 |
---|---|---|
committer | Michael Stahl <mstahl@redhat.com> | 2017-11-30 22:45:55 +0100 |
commit | 95f643cd9c14f3eb8ca3a265d0d0ea8f4b7c8865 (patch) | |
tree | 0c1abfa3ab3774a74885c70c69ba7ad2ce26d75b /icon-themes/sifr/cmd/sc_insertcolumnsafter.png | |
parent | 613e21c2cec354637a3e882e44793fb50a5826b5 (diff) |
tdf#114025 framework: avoid deadlock between Desktop init ...
... and SolarMutex: the problem is that rtl::StaticWithArg will
first lock the implicit mutex of the C++11 static variable, and
then the SolarMutex.
So if one thread creates the Desktop singleton with SolarMutex
locked and another thread without SolarMutex locked, this can
deadlock.
If we use rtl_Instance directly with SolarMutex, then there is
still a static variable, but the SolarMutex will always be locked
first, preventing this deadlock.
Change-Id: Ibd37fdfa96a4a2b57f661be3814dd597eb52d338
Reviewed-on: https://gerrit.libreoffice.org/45508
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit fa9c083c6071a0a4dc812f3c34731f347ddbabf7)
Reviewed-on: https://gerrit.libreoffice.org/45557
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Diffstat (limited to 'icon-themes/sifr/cmd/sc_insertcolumnsafter.png')
0 files changed, 0 insertions, 0 deletions