sd: Don't try to set non-existent combobox entry as activeHEADmaster

In SlideTransitionPane::updateVariants, the call to
weld::ComboBox::clear removes all entries, so there
is no more entry with an index of 0 afterwards.
Therefore, don't try to set that (non-existent) entry
as the active entry a few lines below.

Doing so would result in this critical warning when using
the gtk3 vcl plugin e.g. when starting Impress and trying
to assign the "Fade" transition for the current slide,
as also mentioned in tdf#171411 comment 9:

    (soffice:451812): Gtk-CRITICAL **: 11:27:34.049: gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed

Backtrace when starting with `G_DEBUG=fatal-criticals`:

    Fatal exception: Signal 5
    Stack:
    #0 sal::backtrace_get(unsigned int) at /home/michi/development/git/libreoffice/sal/osl/unx/backtraceapi.cxx:42
    #1 (anonymous namespace)::printStack(int) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:289
    #2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:330
    #3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:427
    #4 /usr/lib/x86_64-linux-gnu/libc.so.6(+0x40e30) [0x7fbf2de48e30]
    #5 _g_log_abort at ./debian/build/deb/../../../glib/gmessages.c:455
    #6 g_logv at ./debian/build/deb/../../../glib/gmessages.c:1313
    #7 g_log at ./debian/build/deb/../../../glib/gmessages.c:1357
    #8 (anonymous namespace)::GtkInstanceComboBox::tree_view_set_cursor(int) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:0
    #9 (anonymous namespace)::GtkInstanceComboBox::set_active_including_mru(int, bool) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:21428
    #10 (anonymous namespace)::GtkInstanceComboBox::do_set_active(int) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:21944
    #11 weld::ComboBox::set_active(int) at /home/michi/development/git/libreoffice/vcl/source/weld/ComboBox.cxx:25
    #12 sd::SlideTransitionPane::updateVariants(std::shared_ptr<sd::TransitionPreset> const&) at /home/michi/development/git/libreoffice/sd/source/ui/animations/SlideTransitionPane.cxx:1068
    #13 sd::SlideTransitionPane::TransitionSelected(weld::IconView&) at /home/michi/development/git/libreoffice/sd/source/ui/animations/SlideTransitionPane.cxx:1056
    #14 sd::SlideTransitionPane::LinkStubTransitionSelected(void*, weld::IconView&) at /home/michi/development/git/libreoffice/sd/source/ui/animations/SlideTransitionPane.cxx:1052
    #15 Link<weld::IconView&, bool>::Call(weld::IconView&) const at /home/michi/development/git/libreoffice/include/tools/link.hxx:105
    #16 weld::IconView::signal_item_activated() at /home/michi/development/git/libreoffice/include/vcl/weld/IconView.hxx:40
    #17 (anonymous namespace)::GtkInstanceIconView::signalItemActivated(_GtkIconView*, _GtkTreePath*, void*) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:16372
    #18 g_cclosure_marshal_VOID__BOXEDv at ./debian/build/deb/../../../gobject/gmarshal.c:1689
    #19 closure_invoke_notifiers at ./debian/build/deb/../../../gobject/gclosure.c:326
    #20 accumulate at ./debian/build/deb/../../../gobject/gsignal.c:3264
    #21 g_signal_emit_valist at ./debian/build/deb/../../../gobject/gsignal.c:3304 (discriminator 1)
    #22 g_signal_emit at ./debian/build/deb/../../../gobject/gsignal.c:3626
    #23 /usr/lib/x86_64-linux-gnu/libgtk-3.so.0(+0x1df1ed) [0x7fbf1b3df1ed]
    #24 /usr/lib/x86_64-linux-gnu/libgtk-3.so.0(+0x97e87) [0x7fbf1b297e87]
    #25 closure_invoke_notifiers at ./debian/build/deb/../../../gobject/gclosure.c:326
    #26 accumulate at ./debian/build/deb/../../../gobject/gsignal.c:3267
    #27 g_signal_emit_valist at ./debian/build/deb/../../../gobject/gsignal.c:3304 (discriminator 1)
    #28 g_signal_emit at ./debian/build/deb/../../../gobject/gsignal.c:3626
    #29 /usr/lib/x86_64-linux-gnu/libgtk-3.so.0(+0x35d0cc) [0x7fbf1b55d0cc]
    #30 /usr/lib/x86_64-linux-gnu/libgtk-3.so.0(+0x20936e) [0x7fbf1b40936e]
    #31 gtk_main_do_event in /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
    #32 /usr/lib/x86_64-linux-gnu/libgdk-3.so.0(+0x40989) [0x7fbf1bf30989]
    #33 /usr/lib/x86_64-linux-gnu/libgdk-3.so.0(+0x75aa6) [0x7fbf1bf65aa6]
    #34 g_main_dispatch at ./debian/build/deb/../../../glib/gmain.c:3595 (discriminator 2)
    #35 g_main_context_dispatch_unlocked at ./debian/build/deb/../../../glib/gmain.c:4451
    #36 g_main_context_iteration at ./debian/build/deb/../../../glib/gmain.c:4583
    #37 GtkSalData::Yield(bool, bool) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkdata.cxx:400
    #38 GtkInstance::DoYield(bool, bool) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:445
    #39 InnerYield(bool, bool) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:389
    #40 Application::Yield() at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:503
    #41 Application::Execute() at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:364
    #42 desktop::Desktop::Main() at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1680
    #43 ImplSVMain() at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:231
    #44 SVMain() at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:249
    #45 soffice_main at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
    #46 sal_main at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
    #47 main at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
    #48 __libc_start_call_main at ./csu/../sysdeps/nptl/libc_start_call_main.h:74
    #49 call_init at ./csu/../csu/libc-start.c:128
    #50 _start in ./instdir/program/soffice.bin

Change-Id: Ibb08811e8f40f11dd53294f87e1bd1cfed92684c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203305
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

0 files changed, 0 insertions, 0 deletions