summaryrefslogtreecommitdiff
path: root/i18npool
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2012-12-21 09:05:17 +0000
committerCaolán McNamara <caolanm@redhat.com>2012-12-29 18:02:25 +0000
commit92a9b7780c6e13a4da3b12794342edbc4c09ef51 (patch)
treeea263d76c24832b1e109dc50c36ebd9cfc9a565a /i18npool
parentc4b2921fc21eed2ec7a5333a3d24cdba46be1203 (diff)
follow logical consequences of a minimum icu version of 4.6
since commit f20ed8959bc0a984177377a734d34f767653625b Change-Id: I4f2fc5d9eb7a581b9ed707a3c3f96be817141846
Diffstat (limited to 'i18npool')
-rw-r--r--i18npool/CustomTarget_breakiterator.mk17
-rw-r--r--i18npool/qa/cppunit/test_breakiterator.cxx8
-rw-r--r--i18npool/source/breakiterator/data/line.txt2
3 files changed, 2 insertions, 25 deletions
diff --git a/i18npool/CustomTarget_breakiterator.mk b/i18npool/CustomTarget_breakiterator.mk
index f23dad0ee88a..067c882b86aa 100644
--- a/i18npool/CustomTarget_breakiterator.mk
+++ b/i18npool/CustomTarget_breakiterator.mk
@@ -96,28 +96,11 @@ $(i18npool_BIDIR)/%.brk : $(i18npool_BIDIR)/%.txt $(call gb_ExternalExecutable_g
# fdo#31271 ")" reclassified in more recent Unicode Standards / ICU 4.4
# * Prepend set empty as of Unicode Version 6.1 / ICU 4.9, which bails out if used.
# NOTE: strips every line with _word_ 'Prepend', including $Prepend
-# * Conditional_Japanese_Starter does not exist in ICU 4.6, which bails out if used.
-# * Hebrew_Letter does not exist in ICU 4.6, which bails out if used.
# NOTE: I sincerely hope there is a better way to avoid problems than this abominable
# sed substitution...
$(i18npool_BIDIR)/%.txt : \
$(SRCDIR)/i18npool/source/breakiterator/data/%.txt | $(i18npool_BIDIR)/.dir
sed -e ': dummy' \
- -e "s#\[:LineBreak = Close_Punctuation:\]#\[& \[:LineBreak = Close_Parenthesis:\]\]#" \
- $(if $(filter-out YES,$(ICU_RECLASSIFIED_CONDITIONAL_JAPANESE_STARTER)),\
- -e '/\[:LineBreak = Conditional_Japanese_Starter:\]/d' \
- -e 's# $$CJ##' \
- ) \
- $(if $(filter-out YES,$(ICU_RECLASSIFIED_HEBREW_LETTER)),\
- -e '/\[:LineBreak = Hebrew_Letter:\]/d' \
- -e '/^$$HLcm =/d' \
- -e '/^$$HLcm $$NUcm;/d' \
- -e '/^$$NUcm $$HLcm;/d' \
- -e '/^$$HL $$CM+;/d' \
- -e 's# | $$HL\(cm\)\?##g' \
- -e 's#$$HLcm ##g' \
- -e 's# $$HL##g' \
- ) \
$(if $(filter YES,$(ICU_RECLASSIFIED_PREPEND_SET_EMPTY)),-e "/Prepend/d") \
$< > $@
diff --git a/i18npool/qa/cppunit/test_breakiterator.cxx b/i18npool/qa/cppunit/test_breakiterator.cxx
index a6bc2cdbd24f..26e24397ed81 100644
--- a/i18npool/qa/cppunit/test_breakiterator.cxx
+++ b/i18npool/qa/cppunit/test_breakiterator.cxx
@@ -72,10 +72,9 @@ public:
#if TODO
CPPUNIT_TEST(testNorthernThai);
#endif
-#if (U_ICU_VERSION_MAJOR_NUM > 4)
+
CPPUNIT_TEST(testWordBoundaries);
CPPUNIT_TEST(testKhmer);
-#endif
CPPUNIT_TEST(testJapanese);
CPPUNIT_TEST_SUITE_END();
private:
@@ -866,12 +865,8 @@ void TestBreakIterator::testNorthernThai()
}
#endif
-#if (U_ICU_VERSION_MAJOR_NUM > 4)
//A test to ensure that our khmer word boundary detection is useful
//https://bugs.freedesktop.org/show_bug.cgi?id=52020
-//
-//icu doesn't have the Khmer word boundary dictionaries in <= 4.0.0 but does in
-//the current 49.x.y . Not sure which version first had them introduced.
void TestBreakIterator::testKhmer()
{
lang::Locale aLocale;
@@ -891,7 +886,6 @@ void TestBreakIterator::testKhmer()
CPPUNIT_ASSERT(aBounds.startPos == 3 && aBounds.endPos == 5);
}
-#endif
void TestBreakIterator::testJapanese()
{
diff --git a/i18npool/source/breakiterator/data/line.txt b/i18npool/source/breakiterator/data/line.txt
index 91c8f3d4850d..b9f3a0585be9 100644
--- a/i18npool/source/breakiterator/data/line.txt
+++ b/i18npool/source/breakiterator/data/line.txt
@@ -62,7 +62,7 @@ $BK = [:LineBreak = Mandatory_Break:];
$B2 = [:LineBreak = Break_Both:];
$CB = [:LineBreak = Contingent_Break:];
$CJ = [:LineBreak = Conditional_Japanese_Starter:];
-$CL = [:LineBreak = Close_Punctuation:] ;
+$CL = [:LineBreak = Close_Parenthesis:];
$CM = [:LineBreak = Combining_Mark:];
$CR = [:LineBreak = Carriage_Return:];
$EX = [:LineBreak = Exclamation:];