diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-10-09 10:28:48 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-10-09 14:47:17 +0200 |
| commit | 7ceee0f1ec0e349d0df4980d7fdedbd13c7917c5 (patch) | |
| tree | 616ab419fe0f01e94740de7faacb393775420589 /i18nlangtag | |
| parent | 664db0d945fbb23e115eeea8377e3a4e88541da1 (diff) | |
Extend loplugin:redundantinline to catch inline functions w/o external linkage
...where "inline" (in its meaning of "this function can be defined in multiple
translation units") thus doesn't make much sense. (As discussed in
compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions
in include files for now.)
All the rewriting has been done automatically by the plugin, except for one
instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus
some subsequent solenv/clang-format/reformat-formatted-files.
Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224
Reviewed-on: https://gerrit.libreoffice.org/61573
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'i18nlangtag')
| -rw-r--r-- | i18nlangtag/source/isolang/isolang.cxx | 2 | ||||
| -rw-r--r-- | i18nlangtag/source/languagetag/languagetag.cxx | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/i18nlangtag/source/isolang/isolang.cxx b/i18nlangtag/source/isolang/isolang.cxx index 6ddafafe2c1c..215a82c64665 100644 --- a/i18nlangtag/source/isolang/isolang.cxx +++ b/i18nlangtag/source/isolang/isolang.cxx @@ -32,7 +32,7 @@ constexpr LanguageType k0(0); constexpr LanguageType kSAME(0xffff); namespace { -inline LanguageType getOverrideLang( LanguageType nLang, LanguageType nOverride ) +LanguageType getOverrideLang( LanguageType nLang, LanguageType nOverride ) { return nOverride ? ((nOverride == kSAME) ? nLang : nOverride) : nLang; } diff --git a/i18nlangtag/source/languagetag/languagetag.cxx b/i18nlangtag/source/languagetag/languagetag.cxx index ed768a907303..ba3d82cce475 100644 --- a/i18nlangtag/source/languagetag/languagetag.cxx +++ b/i18nlangtag/source/languagetag/languagetag.cxx @@ -1733,12 +1733,12 @@ void LanguageTag::getIsoLanguageScriptCountry( OUString& rLanguage, OUString& rS namespace { -inline bool isLowerAscii( sal_Unicode c ) +bool isLowerAscii( sal_Unicode c ) { return 'a' <= c && c <= 'z'; } -inline bool isUpperAscii( sal_Unicode c ) +bool isUpperAscii( sal_Unicode c ) { return 'A' <= c && c <= 'Z'; } |