diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2015-10-07 10:50:12 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2015-10-07 11:32:43 +0200 |
| commit | 41e2f345486f3e5acf7a240e52146fe9b2811c6f (patch) | |
| tree | cedc5cc83cbc96939d5cffd62b6bf9c35d35aabb /hwpfilter | |
| parent | 205f85749d4245ddb80657829af74fc1de23622c (diff) | |
clang-analyzer-deadcode.DeadStores
The code had been like this ever since 16cba77220efab8204eeecb49ccd3ec033efca38
"#112673# initial checkin of HWP filter." Assuming that the second line should
rather read
angle = 1800 - angle * 10;
instead of
angle = 1800 - prop->angle * 10;
does not look too plausible: It would keep mapping
-1 -> 181
0 -> 180
1 -> 179
:
179 -> 1
but then would discontinuously map
180 -> 180
181 -> 179
:
instead of continuously mapping
180 -> 0
181 -> -1
:
Change-Id: I8cf97eeb53409b18bda6777b09a20331f3c8132a
Diffstat (limited to 'hwpfilter')
| -rw-r--r-- | hwpfilter/source/hwpreader.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx index 46f83877f093..13bd651cff00 100644 --- a/hwpfilter/source/hwpreader.cxx +++ b/hwpfilter/source/hwpreader.cxx @@ -648,8 +648,7 @@ void HwpReader::makeDrawMiscStyle( HWPDrawingObject *hdo ) } if( prop->angle > 0 && ( prop->gstyle == 1 || prop->gstyle == 4)) { - int angle = prop->angle >= 180 ? prop->angle - 180 : prop->angle; - angle = 1800 - prop->angle * 10; + int angle = 1800 - prop->angle * 10; padd( "draw:angle", sXML_CDATA, ascii(Int2Str( angle, "%d", buf))); } |