diff options
author | Caolán McNamara <caolanm@redhat.com> | 2017-03-11 17:44:52 +0000 |
---|---|---|
committer | Andras Timar <andras.timar@collabora.com> | 2017-03-16 14:43:54 +0100 |
commit | 490843ac55c9f76939470e25a5c18d391eff4a5f (patch) | |
tree | a14ddfba53ec069df650fde0e6f51e3ed94b4110 /hwpfilter/source/hiodev.h | |
parent | 73efdb66ad4f40388d711da902ebf54a0d5071ef (diff) |
ofz#820 oom terminate
comments claim return is len of data, but negative numbers for compressed data errors
are returned. Make things return the amount of successful data read and turn into
unsigned size_t to match ofz#727
Change-Id: Iadddfae67bb5d4960ddf82e169fc2592ded85950
Reviewed-on: https://gerrit.libreoffice.org/35078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 4a7e226fa4bb5fe5e94a7cc5883b1747a4fd716b)
Diffstat (limited to 'hwpfilter/source/hiodev.h')
-rw-r--r-- | hwpfilter/source/hiodev.h | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/hwpfilter/source/hiodev.h b/hwpfilter/source/hiodev.h index 7c20e1ffa699..af49703c3482 100644 --- a/hwpfilter/source/hiodev.h +++ b/hwpfilter/source/hiodev.h @@ -56,12 +56,12 @@ class DLLEXPORT HIODev virtual bool read2b(unsigned short &out) = 0; virtual bool read4b(unsigned int &out) = 0; virtual bool read4b(int &out) = 0; - virtual int readBlock( void *ptr, int size ) = 0; - virtual int skipBlock( int size ) = 0; + virtual size_t readBlock( void *ptr, size_t size ) = 0; + virtual size_t skipBlock( size_t size ) = 0; - int read1b( void *ptr, int nmemb ); - int read2b( void *ptr, int nmemb ); - int read4b( void *ptr, int nmemb ); + size_t read1b( void *ptr, size_t nmemb ); + size_t read2b( void *ptr, size_t nmemb ); + size_t read4b( void *ptr, size_t nmemb ); }; struct gz_stream; @@ -117,11 +117,11 @@ class HStreamIODev final: public HIODev /** * Read some bytes from stream to given pointer as amount of size */ - virtual int readBlock( void *ptr, int size ) override; + virtual size_t readBlock( void *ptr, size_t size ) override; /** * Move current pointer of stream as amount of size */ - virtual int skipBlock( int size ) override; + virtual size_t skipBlock( size_t size ) override; private: /** * Initialize this object @@ -137,9 +137,9 @@ class HStreamIODev final: public HIODev class HMemIODev final: public HIODev { uchar *ptr; - int pos, length; + size_t pos, length; public: - HMemIODev(char *s, int len); + HMemIODev(char *s, size_t len); virtual ~HMemIODev() override; virtual bool open() override; @@ -155,8 +155,8 @@ class HMemIODev final: public HIODev using HIODev::read4b; virtual bool read4b(unsigned int &out) override; virtual bool read4b(int &out) override; - virtual int readBlock( void *ptr, int size ) override; - virtual int skipBlock( int size ) override; + virtual size_t readBlock( void *ptr, size_t size ) override; + virtual size_t skipBlock( size_t size ) override; private: virtual void init() override; }; |