diff options
| author | Eike Rathke <erack@redhat.com> | 2012-07-24 10:53:33 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2012-07-24 14:54:32 +0200 |
| commit | ca9607ac8ed43d29125a0a2d22a938ec8f414841 (patch) | |
| tree | 0ef67b364c53c01d4d142a13252025d34b540005 /hunspell | |
| parent | 94fdc1e684d691cd63d75685b5a607d35e737dcf (diff) | |
prevent crash in malformed pivot table loaded from .xls
ScDPMember::GetItemData() unconditionally returned a reference to a
ScDPItemData pointer obtained through ScDPSource::GetItemDataById()
ScDPTableData::GetMemberById() ScDPCache::GetItemDataById() that can be
null for malformed entries. Changed ScDPMember::GetItemData() to return
a pointer instead and adapted callers to check for null.
3.5.x in ScDPSource::GetItemDataById() had a check for null pointer and
added an empty ScDPItemData element to the cache for this case and
returned the pointer to that entry (marked as todo). This is not the
case anymore.
(cherry picked from commit 3536fcd999f16525f20a1fff5c2512b565511d7b
plus follow-up 9b2ec8c2a3478047a270b31bc25ad1d782401306 "it's pData2")
Change-Id: I241c232d7182f5d58e8531af540e69b26ab4888a
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'hunspell')
0 files changed, 0 insertions, 0 deletions