diff options
author | Dennis Francis <dennis.francis@collabora.com> | 2019-11-20 13:24:48 +0530 |
---|---|---|
committer | Eike Rathke <erack@redhat.com> | 2019-11-22 14:41:16 +0100 |
commit | c8459ed5e433418453f366504f86cc1c2b1bf011 (patch) | |
tree | 8b79db6e8475af9966a88cf3f42e964156f8f2d5 /helpcontent2 | |
parent | ebba06b785c87e6a310a523fa9570449d3986cd7 (diff) |
tdf#128894: xlsx-import : Do not share tokens between cells...
which are part of a xlsx-shared-formula along a *row*.
If we do, any reference-updates on these cells while editing
will mess things up.
For example a shared formula "=A30+1" used for a few cells in
the first row (say, A1, B1, C1 and D1) and on deleting a row,
say row#5, the reference update operation will decrement the
row index of all tokens in A1, B1, C1 and D1. But if they
share tokens, they all end up pointing to row#26 instead of
row#29 as each cell is updated which amounts to decrementing
4 times instead of once.
However shared formulas along columns are not affected by this
bug, when tokens are shared since we use formula-groups which
only keeps one copy of token array for the entire group and
reference-update code is designed to correctly work with
formula-groups.
Change-Id: Ic0fe84d12fef18fbf21658664e2b2b86409bca27
Reviewed-on: https://gerrit.libreoffice.org/83361
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit b30251ca0d102ced36799ee18d4bbcd9e8530fa0)
Reviewed-on: https://gerrit.libreoffice.org/83476
Diffstat (limited to 'helpcontent2')
0 files changed, 0 insertions, 0 deletions