diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 07:50:57 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 11:48:22 +0200 |
| commit | 51d1ec7883444e6216f1020122084d3a996c9ecb (patch) | |
| tree | 8b24c91daecfa2ccb922b6e1c91e29c3bf89e7dc /framework | |
| parent | cd6dd8c6f3562cbccbc971b916c6a8933840ffeb (diff) | |
clang-tidy performance-unnecessary-copy-init in editeng..i18npool
Change-Id: I2ee2c8d15d8700cfaa1697363da4557c741a5f36
Reviewed-on: https://gerrit.libreoffice.org/62216
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'framework')
| -rw-r--r-- | framework/source/fwe/helper/actiontriggerhelper.cxx | 2 | ||||
| -rw-r--r-- | framework/source/fwi/helper/mischelper.cxx | 2 | ||||
| -rw-r--r-- | framework/source/tabwin/tabwindow.cxx | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/framework/source/fwe/helper/actiontriggerhelper.cxx b/framework/source/fwe/helper/actiontriggerhelper.cxx index 8d00b23a9e6e..0a9bc906c5be 100644 --- a/framework/source/fwe/helper/actiontriggerhelper.cxx +++ b/framework/source/fwe/helper/actiontriggerhelper.cxx @@ -159,7 +159,7 @@ static void InsertSubMenuItems( Menu* pSubMenu, sal_uInt16& nItemId, const Refer { // This is our own optimized implementation of menu images! ImageWrapper* pImageWrapper = reinterpret_cast< ImageWrapper * >( nPointer ); - Image aMenuImage = pImageWrapper->GetImage(); + const Image& aMenuImage = pImageWrapper->GetImage(); if ( !!aMenuImage ) pSubMenu->SetItemImage( nNewItemId, aMenuImage ); diff --git a/framework/source/fwi/helper/mischelper.cxx b/framework/source/fwi/helper/mischelper.cxx index fa94988a7e35..c991a8cc0774 100644 --- a/framework/source/fwi/helper/mischelper.cxx +++ b/framework/source/fwi/helper/mischelper.cxx @@ -89,7 +89,7 @@ void FillLangItems( std::set< OUString > &rLangItems, } //4--guessed language - uno::Reference< linguistic2::XLanguageGuessing > xLangGuesser( rLangGuessHelper.GetGuesser() ); + const uno::Reference< linguistic2::XLanguageGuessing >& xLangGuesser( rLangGuessHelper.GetGuesser() ); if ( xLangGuesser.is() && !rGuessedTextLang.isEmpty()) { css::lang::Locale aLocale(xLangGuesser->guessPrimaryLanguage( rGuessedTextLang, 0, rGuessedTextLang.getLength()) ); diff --git a/framework/source/tabwin/tabwindow.cxx b/framework/source/tabwin/tabwindow.cxx index 606f13748517..06b938db0410 100644 --- a/framework/source/tabwin/tabwindow.cxx +++ b/framework/source/tabwin/tabwindow.cxx @@ -233,7 +233,7 @@ IMPL_LINK( TabWindow, Activate, TabControl*, pTabControl, void ) sal_Int32 nPageId = pTabControl->GetCurPageId(); - OUString aTitle = pTabControl->GetPageText( sal_uInt16( nPageId )); + const OUString& aTitle = pTabControl->GetPageText( sal_uInt16( nPageId )); impl_SetTitle( aTitle ); aLock.clear(); /* SAFE AREA ----------------------------------------------------------------------------------------------- */ @@ -664,7 +664,7 @@ css::uno::Sequence< css::beans::NamedValue > SAL_CALL TabWindow::getTabProps( :: if ( nPos == TAB_PAGE_NOTFOUND ) throw css::lang::IndexOutOfBoundsException(); - OUString aTitle = pTabControl->GetPageText( sal_uInt16( ID )); + const OUString& aTitle = pTabControl->GetPageText( sal_uInt16( ID )); nPos = pTabControl->GetPagePos( sal_uInt16( ID )); css::uno::Sequence< css::beans::NamedValue > aSeq |