summaryrefslogtreecommitdiff
path: root/fpicker
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2014-03-19 22:21:41 +0100
committerStephan Bergmann <sbergman@redhat.com>2014-03-19 22:21:41 +0100
commitf342aba967dab0be6a4ce981c92240d66a1c41b1 (patch)
treec499483c6c32d0e16e468ccaa49c8dfce9dc3db8 /fpicker
parentf52dcaa810517195fe6a3b305a6c1097ec32995e (diff)
loplugin:passstringbyref (and some dead code)
Change-Id: I96f5b58ac000e7535b6759af04be60e738aa2b09
Diffstat (limited to 'fpicker')
-rw-r--r--fpicker/source/aqua/FilterHelper.hxx6
-rw-r--r--fpicker/source/aqua/FilterHelper.mm6
2 files changed, 4 insertions, 8 deletions
diff --git a/fpicker/source/aqua/FilterHelper.hxx b/fpicker/source/aqua/FilterHelper.hxx
index c519a21d5f19..7facc808f363 100644
--- a/fpicker/source/aqua/FilterHelper.hxx
+++ b/fpicker/source/aqua/FilterHelper.hxx
@@ -112,11 +112,7 @@ private:
OUString m_aCurrentFilter;
NSStringList *m_pFilterNames;
- int implAddFilter( const OUString rFilter, const OUStringList rSuffixList);
- int implAddFilterGroup( const OUString rFilter,
- const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::StringPair>& _rFilters );
-
- sal_Bool FilterNameExists( const OUString rTitle );
+ sal_Bool FilterNameExists( const OUString& rTitle );
sal_Bool FilterNameExists( const UnoFilterList& _rGroupedFilters );
void ensureFilterList( const OUString& _rInitialCurrentFilter );
diff --git a/fpicker/source/aqua/FilterHelper.mm b/fpicker/source/aqua/FilterHelper.mm
index 5ee7b447fa9f..ef048f28fe47 100644
--- a/fpicker/source/aqua/FilterHelper.mm
+++ b/fpicker/source/aqua/FilterHelper.mm
@@ -92,7 +92,7 @@ isFilterString( const rtl::OUString& rFilterString, const char *pMatch )
static rtl::OUString
-shrinkFilterName( const rtl::OUString aFilterName, bool bAllowNoStar = false )
+shrinkFilterName( const rtl::OUString& aFilterName, bool bAllowNoStar = false )
{
// DBG_PRINT_ENTRY(CLASS_NAME, "shrinkFilterName", "filterName", aFilterName);
@@ -130,7 +130,7 @@ protected:
const rtl::OUString rTitle;
public:
- FilterTitleMatch( const rtl::OUString _rTitle ) : rTitle( _rTitle ) { }
+ FilterTitleMatch( const rtl::OUString& _rTitle ) : rTitle( _rTitle ) { }
bool operator () ( const FilterEntry& _rEntry )
@@ -203,7 +203,7 @@ FilterHelper::~FilterHelper()
}
-sal_Bool FilterHelper::FilterNameExists( const rtl::OUString rTitle )
+sal_Bool FilterHelper::FilterNameExists( const rtl::OUString& rTitle )
{
sal_Bool bRet = sal_False;