Enable -Wnon-virtual-dtor for GCC 4.6

...which has the necessary features to support it.

Change a lot of classes to either contain a protected non-virtual dtor
(which is backwards compatible, so even works for cppumaker-generated
UNO headers) or a public virtual one.

cppuhelper/propertysetmixin.hxx still needs to disable the warning, as
the relevant class has a non-virtual dtor but friends, which would still
cause GCC to warn.

Includes a patch for libcmis, intended to be upstreamed.

8 files changed, 26 insertions, 0 deletions

diff --git a/forms/source/inc/featuredispatcher.hxx b/forms/source/inc/featuredispatcher.hxx
index 760a8c4b6455..7a1afc1800bc 100644
--- a/forms/source/inc/featuredispatcher.hxx
+++ b/forms/source/inc/featuredispatcher.hxx
@@ -102,6 +102,9 @@ namespace frm
             integer information associated with it.
         */
         virtual sal_Int32       getIntegerState( sal_Int16 _nFeatureId ) const = 0;
+
+    protected:
+        ~IFeatureDispatcher() {}
     };
 
 //.........................................................................
diff --git a/forms/source/inc/property.hxx b/forms/source/inc/property.hxx
index d12a0d030e61..81102c609a20 100644
--- a/forms/source/inc/property.hxx
+++ b/forms/source/inc/property.hxx
@@ -106,6 +106,8 @@ private:
 class ConcreteInfoService : public ::comphelper::IPropertyInfoService
 {
 public:
+    virtual ~ConcreteInfoService() {}
+
     virtual sal_Int32 getPreferedPropertyId(const ::rtl::OUString& _rName);
 };
 
diff --git a/forms/source/inc/propertybaghelper.hxx b/forms/source/inc/propertybaghelper.hxx
index 5bb10583ea37..7600618fa8f1 100644
--- a/forms/source/inc/propertybaghelper.hxx
+++ b/forms/source/inc/propertybaghelper.hxx
@@ -58,6 +58,9 @@ namespace frm
 
         virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XMultiPropertySet >
                                 getPropertiesInterface() = 0;
+
+    protected:
+        ~IPropertyBagHelperContext() {}
     };
 
     //====================================================================
diff --git a/forms/source/richtext/richtextengine.hxx b/forms/source/richtext/richtextengine.hxx
index c571f51e9aaf..99ab2d67d121 100644
--- a/forms/source/richtext/richtextengine.hxx
+++ b/forms/source/richtext/richtextengine.hxx
@@ -47,6 +47,9 @@ namespace frm
     {
     public:
         virtual void EditEngineStatusChanged( const EditStatus& _rStatus ) = 0;
+
+    protected:
+        ~IEngineStatusListener() {}
     };
 
     //====================================================================
diff --git a/forms/source/richtext/richtextunowrapper.hxx b/forms/source/richtext/richtextunowrapper.hxx
index ef9ecbe57338..65ced5a440b9 100644
--- a/forms/source/richtext/richtextunowrapper.hxx
+++ b/forms/source/richtext/richtextunowrapper.hxx
@@ -44,6 +44,9 @@ namespace frm
     {
     public:
         virtual void potentialTextChange( ) = 0;
+
+    protected:
+        ~IEngineTextChangeListener() {}
     };
 
     //====================================================================
diff --git a/forms/source/richtext/rtattributehandler.hxx b/forms/source/richtext/rtattributehandler.hxx
index e908ae75162c..36c55861600d 100644
--- a/forms/source/richtext/rtattributehandler.hxx
+++ b/forms/source/richtext/rtattributehandler.hxx
@@ -68,6 +68,9 @@ namespace frm
         virtual     AttributeId     getAttributeId( ) const = 0;
         virtual     AttributeState  getState( const SfxItemSet& _rAttribs ) const = 0;
         virtual     void            executeAttribute( const SfxItemSet& _rCurrentAttribs, SfxItemSet& _rNewAttribs, const SfxPoolItem* _pAdditionalArg, ScriptType _nForScriptType ) const = 0;
+
+    protected:
+        ~IAttributeHandler() {}
     };
 
     //====================================================================
diff --git a/forms/source/richtext/rtattributes.hxx b/forms/source/richtext/rtattributes.hxx
index 246a1366e283..8049705f6783 100644
--- a/forms/source/richtext/rtattributes.hxx
+++ b/forms/source/richtext/rtattributes.hxx
@@ -163,6 +163,9 @@ namespace frm
     public:
         virtual AttributeState  getState( AttributeId _nAttributeId ) const = 0;
         virtual void            executeAttribute( AttributeId _nAttributeId, const SfxPoolItem* _pArgument ) = 0;
+
+    protected:
+        ~IMultiAttributeDispatcher() {}
     };
 
 //........................................................................
diff --git a/forms/source/richtext/textattributelistener.hxx b/forms/source/richtext/textattributelistener.hxx
index 51ea48f42af1..04616172d383 100644
--- a/forms/source/richtext/textattributelistener.hxx
+++ b/forms/source/richtext/textattributelistener.hxx
@@ -43,6 +43,9 @@ namespace frm
     {
     public:
         virtual void    onAttributeStateChanged( AttributeId _nAttributeId, const AttributeState& _rState ) = 0;
+
+    protected:
+        ~ITextAttributeListener() {}
     };
 
     //====================================================================
@@ -52,6 +55,9 @@ namespace frm
     {
     public:
         virtual void    onSelectionChanged( const ESelection& _rSelection ) = 0;
+
+    protected:
+        ~ITextSelectionListener() {}
     };
 
 //........................................................................