clang-tidy:readability-redundant-member-init

Change-Id: I67edbea77b12940ac807ccbadfd74b250902809d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121378
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

17 files changed, 8 insertions, 49 deletions

diff --git a/forms/source/component/ComboBox.cxx b/forms/source/component/ComboBox.cxx
index 6ef66237a174..9b1bd9b9c7bd 100644
--- a/forms/source/component/ComboBox.cxx
+++ b/forms/source/component/ComboBox.cxx
@@ -112,7 +112,6 @@ OComboBoxModel::OComboBoxModel(const Reference<XComponentContext>& _rxFactory)
      // use the old control name for compatibility reasons
     ,OEntryListHelper( static_cast<OControlModel&>(*this) )
     ,OErrorBroadcaster( OComponentHelper::rBHelper )
-    ,m_aListRowSet()
     ,m_eListSourceType(ListSourceType_TABLE)
     ,m_bEmptyIsNull(true)
 {
@@ -125,7 +124,6 @@ OComboBoxModel::OComboBoxModel( const OComboBoxModel* _pOriginal, const Referenc
     :OBoundControlModel( _pOriginal, _rxFactory )
     ,OEntryListHelper( *_pOriginal, static_cast<OControlModel&>(*this) )
     ,OErrorBroadcaster( OComponentHelper::rBHelper )
-    ,m_aListRowSet()
     ,m_aListSource( _pOriginal->m_aListSource )
     ,m_aDefaultText( _pOriginal->m_aDefaultText )
     ,m_eListSourceType( _pOriginal->m_eListSourceType )
diff --git a/forms/source/component/Filter.cxx b/forms/source/component/Filter.cxx
index 141e011ad792..0bf85648ddba 100644
--- a/forms/source/component/Filter.cxx
+++ b/forms/source/component/Filter.cxx
@@ -78,8 +78,7 @@ namespace frm
     using namespace ::connectivity;
 
     OFilterControl::OFilterControl( const Reference< XComponentContext >& _rxORB )
-        :UnoControl()
-        ,m_aTextListeners( *this )
+        :m_aTextListeners( *this )
         ,m_xContext( _rxORB )
         ,m_nControlClass( FormComponentType::TEXTFIELD )
         ,m_bFilterList( false )
diff --git a/forms/source/component/FormComponent.cxx b/forms/source/component/FormComponent.cxx
index c71c02c1c34f..0f67f8433e95 100644
--- a/forms/source/component/FormComponent.cxx
+++ b/forms/source/component/FormComponent.cxx
@@ -1128,8 +1128,6 @@ OBoundControlModel::OBoundControlModel(
         const bool _bCommitable, const bool _bSupportExternalBinding, const bool _bSupportsValidation )
     :OControlModel( _rxFactory, _rUnoControlModelTypeName, _rDefault, false )
     ,OPropertyChangeListener( m_aMutex )
-    ,m_xField()
-    ,m_xAmbientForm()
     ,m_nValuePropertyAggregateHandle( -1 )
     ,m_nFieldType( DataType::OTHER )
     ,m_bValuePropertyMayBeVoid( false )
@@ -1159,8 +1157,6 @@ OBoundControlModel::OBoundControlModel(
         const OBoundControlModel* _pOriginal, const Reference< XComponentContext>& _rxFactory )
     :OControlModel( _pOriginal, _rxFactory, true, false )
     ,OPropertyChangeListener( m_aMutex )
-    ,m_xField()
-    ,m_xAmbientForm()
     ,m_nValuePropertyAggregateHandle( _pOriginal->m_nValuePropertyAggregateHandle )
     ,m_nFieldType( DataType::OTHER )
     ,m_bValuePropertyMayBeVoid( _pOriginal->m_bValuePropertyMayBeVoid )
diff --git a/forms/source/component/FormattedField.cxx b/forms/source/component/FormattedField.cxx
index 00388525a63b..7bef964464e9 100644
--- a/forms/source/component/FormattedField.cxx
+++ b/forms/source/component/FormattedField.cxx
@@ -92,8 +92,7 @@ protected:
 
 WeakReference< XNumberFormatsSupplier > StandardFormatsSupplier::s_xDefaultFormatsSupplier;
 StandardFormatsSupplier::StandardFormatsSupplier(const Reference< XComponentContext > & _rxContext,LanguageType _eSysLanguage)
-    :SvNumberFormatsSupplierObj()
-    ,m_pMyPrivateFormatter(new SvNumberFormatter(_rxContext, _eSysLanguage))
+    :m_pMyPrivateFormatter(new SvNumberFormatter(_rxContext, _eSysLanguage))
 {
     SetNumberFormatter(m_pMyPrivateFormatter.get());
     // #i29147#
diff --git a/forms/source/component/ImageControl.cxx b/forms/source/component/ImageControl.cxx
index f072f5929605..f51988ee4ca2 100644
--- a/forms/source/component/ImageControl.cxx
+++ b/forms/source/component/ImageControl.cxx
@@ -131,8 +131,6 @@ OImageControlModel::OImageControlModel(const Reference<XComponentContext>& _rxFa
                     // use the old control name for compytibility reasons
     ,m_bExternalGraphic( true )
     ,m_bReadOnly( false )
-    ,m_sImageURL()
-    ,m_xGraphicObject()
 {
     m_nClassId = FormComponentType::IMAGECONTROL;
     initOwnValueProperty( PROPERTY_IMAGE_URL );
diff --git a/forms/source/component/ListBox.cxx b/forms/source/component/ListBox.cxx
index e998e701f57c..b58fb00cd8e9 100644
--- a/forms/source/component/ListBox.cxx
+++ b/forms/source/component/ListBox.cxx
@@ -148,7 +148,6 @@ namespace frm
         // use the old control name for compatibility reasons
         ,OEntryListHelper( static_cast<OControlModel&>(*this) )
         ,OErrorBroadcaster( OComponentHelper::rBHelper )
-        ,m_aListRowSet()
         ,m_nConvertedBoundValuesType(0)
         ,m_nNULLPos(-1)
         ,m_nBoundColumnType( DataType::SQLNULL )
@@ -167,7 +166,6 @@ namespace frm
         :OBoundControlModel( _pOriginal, _rxFactory )
         ,OEntryListHelper( *_pOriginal, static_cast<OControlModel&>(*this) )
         ,OErrorBroadcaster( OComponentHelper::rBHelper )
-        ,m_aListRowSet()
         ,m_eListSourceType( _pOriginal->m_eListSourceType )
         ,m_aBoundColumn( _pOriginal->m_aBoundColumn )
         ,m_aListSourceValues( _pOriginal->m_aListSourceValues )
diff --git a/forms/source/component/cachedrowset.cxx b/forms/source/component/cachedrowset.cxx
index f18246a4c177..77368f76cff2 100644
--- a/forms/source/component/cachedrowset.cxx
+++ b/forms/source/component/cachedrowset.cxx
@@ -57,9 +57,7 @@ namespace frm
         bool                            bStatementDirty;
 
         CachedRowSet_Data()
-            :sCommand()
-            ,bEscapeProcessing( false )
-            ,xConnection()
+            :bEscapeProcessing( false )
             ,bStatementDirty( true )
         {
         }
diff --git a/forms/source/component/clickableimage.cxx b/forms/source/component/clickableimage.cxx
index d04ffdf49ffd..8dd3489967f5 100644
--- a/forms/source/component/clickableimage.cxx
+++ b/forms/source/component/clickableimage.cxx
@@ -448,7 +448,6 @@ namespace frm
             const OUString& rDefault )
         :OControlModel( _rxFactory, _rUnoControlModelTypeName, rDefault )
         ,OPropertyChangeListener(m_aMutex)
-        ,m_xGraphicObject()
         ,m_bDispatchUrlInternal(false)
         ,m_bProdStarted(false)
     {
diff --git a/forms/source/richtext/richtextcontrol.cxx b/forms/source/richtext/richtextcontrol.cxx
index 7aeb8410b568..e6416ca2d0da 100644
--- a/forms/source/richtext/richtextcontrol.cxx
+++ b/forms/source/richtext/richtextcontrol.cxx
@@ -53,7 +53,6 @@ namespace frm
     using namespace ::com::sun::star::frame;
 
     ORichTextControl::ORichTextControl()
-        :UnoEditControl()
     {
     }
 
diff --git a/forms/source/solar/component/navbarcontrol.cxx b/forms/source/solar/component/navbarcontrol.cxx
index 14e9c27ce74f..92d7ac4635cc 100644
--- a/forms/source/solar/component/navbarcontrol.cxx
+++ b/forms/source/solar/component/navbarcontrol.cxx
@@ -56,7 +56,7 @@ namespace frm
     }
 
     ONavigationBarControl::ONavigationBarControl( const Reference< XComponentContext >& _rxORB)
-        :UnoControl(), m_xContext(_rxORB)
+        : m_xContext(_rxORB)
     {
     }
 
diff --git a/forms/source/xforms/binding.cxx b/forms/source/xforms/binding.cxx
index 06a21384d8d6..adb66aba283c 100644
--- a/forms/source/xforms/binding.cxx
+++ b/forms/source/xforms/binding.cxx
@@ -112,16 +112,11 @@ using com::sun::star::xsd::XDataType;
 
 
 Binding::Binding() :
-    mxModel(),
-    msBindingID(),
-    maBindingExpression(),
-    maReadonly(),
     mxNamespaces( new NameContainer<OUString>() ),
     mbInCalculate( false ),
     mnDeferModifyNotifications( 0 ),
     mbValueModified( false ),
     mbBindingModified( false )
-
 {
     initializePropertySet();
 }
diff --git a/forms/source/xforms/boolexpression.cxx b/forms/source/xforms/boolexpression.cxx
index 6b3f57564d66..af45c8c38fd8 100644
--- a/forms/source/xforms/boolexpression.cxx
+++ b/forms/source/xforms/boolexpression.cxx
@@ -27,10 +27,7 @@ namespace xforms
  * As this class has no virtual methods, it should never be used
  * polymorphically. */
 
-BoolExpression::BoolExpression()
-    : ComputedExpression()
-{
-}
+BoolExpression::BoolExpression() {}
 
 BoolExpression::~BoolExpression() {}
 
diff --git a/forms/source/xforms/computedexpression.cxx b/forms/source/xforms/computedexpression.cxx
index 633492335be5..add8d4350ac7 100644
--- a/forms/source/xforms/computedexpression.cxx
+++ b/forms/source/xforms/computedexpression.cxx
@@ -44,10 +44,8 @@ namespace xforms
 {
 
 ComputedExpression::ComputedExpression()
-    : msExpression(),
-      mbIsEmpty( true ),
-      mbIsSimple( true ),
-      mxResult()
+    : mbIsEmpty( true ),
+      mbIsSimple( true )
 {
 }
 
diff --git a/forms/source/xforms/convert.cxx b/forms/source/xforms/convert.cxx
index d68018f47d22..332262fdb900 100644
--- a/forms/source/xforms/convert.cxx
+++ b/forms/source/xforms/convert.cxx
@@ -39,7 +39,6 @@ using namespace std;
 using namespace utl;
 
 Convert::Convert()
-    : maMap()
 {
     init();
 }
diff --git a/forms/source/xforms/model.cxx b/forms/source/xforms/model.cxx
index b82b0fc9de80..6320ff732229 100644
--- a/forms/source/xforms/model.cxx
+++ b/forms/source/xforms/model.cxx
@@ -87,7 +87,6 @@ void Model::ensureAtLeastOneInstance()
 
 /** Model default constructor; create empty model */
 Model::Model() :
-    msID(),
     mxInstances( new InstanceCollection ),
     mxNamespaces( new NameContainer<OUString>() ),
     mbInitialized( false ),
diff --git a/forms/source/xforms/pathexpression.cxx b/forms/source/xforms/pathexpression.cxx
index ea8fb8e63fd3..d7ffb6012eca 100644
--- a/forms/source/xforms/pathexpression.cxx
+++ b/forms/source/xforms/pathexpression.cxx
@@ -40,8 +40,6 @@ namespace xforms
 {
 
 PathExpression::PathExpression()
-    : ComputedExpression(),
-      maNodes()
 {
 }
 
diff --git a/forms/source/xforms/submission.cxx b/forms/source/xforms/submission.cxx
index 1acfe50e87d2..c8b28fc0c135 100644
--- a/forms/source/xforms/submission.cxx
+++ b/forms/source/xforms/submission.cxx
@@ -71,21 +71,10 @@ using namespace com::sun::star::lang;
 using namespace com::sun::star::xml::dom;
 
 Submission::Submission() :
-    msID(),
-    msBind(),
-    maRef(),
-    msAction(),
-    msMethod(),
-    msVersion(),
     mbIndent(),
-    msMediaType(),
-    msEncoding(),
     mbOmitXmlDeclaration(),
     mbStandalone(),
-    msCDataSectionElement(),
-    msReplace( "none" ),
-    msSeparator(),
-    msIncludeNamespacePrefixes()
+    msReplace( "none" )
 {
     initializePropertySet();
 }