new loplugin: change virtual methods to non-virtual

Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae

8 files changed, 13 insertions, 13 deletions

diff --git a/forms/source/component/Columns.hxx b/forms/source/component/Columns.hxx
index 669d156c8e4e..d619b6e39c3e 100644
--- a/forms/source/component/Columns.hxx
+++ b/forms/source/component/Columns.hxx
@@ -85,8 +85,8 @@ public:
     virtual void SAL_CALL disposing(const ::com::sun::star::lang::EventObject& _rSource) throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 
     // XPersistObject
-    virtual void SAL_CALL write(const ::com::sun::star::uno::Reference< ::com::sun::star::io::XObjectOutputStream>& _rxOutStream);
-    virtual void SAL_CALL read(const ::com::sun::star::uno::Reference< ::com::sun::star::io::XObjectInputStream>& _rxInStream);
+    void SAL_CALL write(const ::com::sun::star::uno::Reference< ::com::sun::star::io::XObjectOutputStream>& _rxOutStream);
+    void SAL_CALL read(const ::com::sun::star::uno::Reference< ::com::sun::star::io::XObjectInputStream>& _rxInStream);
 
     // XPropertySet
     virtual ::cppu::IPropertyArrayHelper& SAL_CALL getInfoHelper() SAL_OVERRIDE = 0;
diff --git a/forms/source/component/EventThread.hxx b/forms/source/component/EventThread.hxx
index 30ec45f5e3bd..51143f1b974b 100644
--- a/forms/source/component/EventThread.hxx
+++ b/forms/source/component/EventThread.hxx
@@ -65,7 +65,7 @@ protected:
     // XThread
     virtual void SAL_CALL run() SAL_OVERRIDE;
 
-    virtual void SAL_CALL kill();
+    void SAL_CALL kill();
     virtual void SAL_CALL onTerminated() SAL_OVERRIDE;
 
     // The following method is called to duplicate the Event while respecting it's type.
diff --git a/forms/source/component/File.hxx b/forms/source/component/File.hxx
index 5c47c530e1e3..9e5fd5a7b999 100644
--- a/forms/source/component/File.hxx
+++ b/forms/source/component/File.hxx
@@ -78,7 +78,7 @@ public:
     using OControlModel::getFastPropertyValue;
 
 protected:
-    virtual void _reset();
+    void _reset();
 
     virtual css::uno::Reference< css::util::XCloneable > SAL_CALL createClone(  ) throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE;
 };
diff --git a/forms/source/inc/FormComponent.hxx b/forms/source/inc/FormComponent.hxx
index e5b5ffc59ff7..5367ceb29c50 100644
--- a/forms/source/inc/FormComponent.hxx
+++ b/forms/source/inc/FormComponent.hxx
@@ -315,7 +315,7 @@ public:
 protected:
     virtual ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Type>   _getTypes() SAL_OVERRIDE;
     // implement the lock setting
-    virtual void         _setLock(bool _bLock);
+    void         _setLock(bool _bLock);
 };
 
 
@@ -922,14 +922,14 @@ protected:
     virtual void            onConnectedExternalValue( );
     /** called whenever a connection to an external supplier of values (XValueBinding) has been suspended
     */
-    virtual void            onDisconnectedExternalValue();
+    void            onDisconnectedExternalValue();
 
     /** called whenever an external validator has been registered
     */
-    virtual void            onConnectedValidator( );
+    void            onConnectedValidator( );
     /** called whenever an external validator has been revoked
     */
-    virtual void            onDisconnectedValidator( );
+    void            onDisconnectedValidator( );
 
     /** nFieldType is the type of the field, on which the model will be linked.
         The linking happens when sal_True is returned.
diff --git a/forms/source/inc/InterfaceContainer.hxx b/forms/source/inc/InterfaceContainer.hxx
index d04c020e9238..6d5ec45be1c1 100644
--- a/forms/source/inc/InterfaceContainer.hxx
+++ b/forms/source/inc/InterfaceContainer.hxx
@@ -186,7 +186,7 @@ public:
 protected:
     // helper
     virtual void SAL_CALL disposing();
-    virtual void removeElementsNoEvents(sal_Int32 nIndex);
+    void removeElementsNoEvents(sal_Int32 nIndex);
 
     /** to be overridden if elements which are to be inserted into the container shall be checked
 
diff --git a/forms/source/richtext/featuredispatcher.hxx b/forms/source/richtext/featuredispatcher.hxx
index 598141d94fcd..e69bb805a807 100644
--- a/forms/source/richtext/featuredispatcher.hxx
+++ b/forms/source/richtext/featuredispatcher.hxx
@@ -66,7 +66,7 @@ namespace frm
 
     protected:
         // overridables
-        virtual void    newStatusListener( const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XStatusListener >& _rxListener );
+        void    newStatusListener( const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XStatusListener >& _rxListener );
         virtual void    disposing( ::osl::ClearableMutexGuard& _rClearBeforeNotify );
         virtual void    invalidateFeatureState_Broadcast();
 
diff --git a/forms/source/xforms/submission/serialization.hxx b/forms/source/xforms/submission/serialization.hxx
index 405f563dbb1b..f467754fd802 100644
--- a/forms/source/xforms/submission/serialization.hxx
+++ b/forms/source/xforms/submission/serialization.hxx
@@ -49,7 +49,7 @@ public:
     /**
     sets the XObject that is to serialized
     */
-    virtual void setSource(const css::uno::Reference< css::xml::dom::XDocumentFragment >& aFragment)
+    void setSource(const css::uno::Reference< css::xml::dom::XDocumentFragment >& aFragment)
     {
         m_aFragment = aFragment;
     }
diff --git a/forms/source/xforms/submission/submission.hxx b/forms/source/xforms/submission/submission.hxx
index 0cca95090eb7..a8cd11d4a87b 100644
--- a/forms/source/xforms/submission/submission.hxx
+++ b/forms/source/xforms/submission/submission.hxx
@@ -138,13 +138,13 @@ public:
 
     virtual ~CSubmission() {}
 
-    virtual void setEncoding(const OUString& aEncoding)
+    void setEncoding(const OUString& aEncoding)
     {
         m_aEncoding = aEncoding;
     }
     virtual SubmissionResult submit(const css::uno::Reference< css::task::XInteractionHandler >& ) = 0;
 
-    virtual SubmissionResult replace(const OUString&, const css::uno::Reference< css::xml::dom::XDocument >&, const css::uno::Reference< css::frame::XFrame>&);
+    SubmissionResult replace(const OUString&, const css::uno::Reference< css::xml::dom::XDocument >&, const css::uno::Reference< css::frame::XFrame>&);
 
 };