diff options
| author | Luke Deller <luke@deller.id.au> | 2018-03-08 01:11:40 +1100 |
|---|---|---|
| committer | Aron Budea <aron.budea@collabora.com> | 2018-04-03 19:06:47 +0200 |
| commit | e9c69bfa7254106458744bd832b101319ca518d8 (patch) | |
| tree | d34cd2901897333612616a629b34dfcf33064dea /filter | |
| parent | 1cf9fcc723041ceb97dc637de658f3486a755edf (diff) | |
tdf#116179 Support reading "auto" colour from docx
In docx a colour value is represented as a 6-digit hex RGB value, or
alternatively the word "auto" to represent automatic colour.
- Add support for reading the value "auto" as COL_AUTO. Previously
this would be read as if it were a hex value, stopping at the
letter 'u' which is not a valid hex digit, resulting in the colour
0x00000A - a very dark blue, which looks close enough to black that
it went unnoticed for a long time :-)
- Remove code which tried to handle this wrong 0x00000A value,
including the constant OOXML_COLOR_AUTO, as it is no longer needed
and will cause surprises for anyone who really wanted this exact
shade of dark blue
- Fix unit tests that were checking for 0x00000A
Reviewed-on: https://gerrit.libreoffice.org/50995
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/51461
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 3967aebca94be9ceea3e36b43f7f53589473ad4e)
Change-Id: I6000070341931147ff9341ad6281cd3b53c02b46
(cherry picked from commit ccef956c4f11ac6c0612a0d22845d02743c91039)
Diffstat (limited to 'filter')
| -rw-r--r-- | filter/source/msfilter/util.cxx | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/filter/source/msfilter/util.cxx b/filter/source/msfilter/util.cxx index 607791f96a1f..24603aa4d704 100644 --- a/filter/source/msfilter/util.cxx +++ b/filter/source/msfilter/util.cxx @@ -126,14 +126,11 @@ sal_Unicode bestFitOpenSymbolToMSFont(sal_Unicode cChar, } -OString ConvertColor( const Color &rColor, bool bAutoColor ) +OString ConvertColor( const Color &rColor ) { OString color( "auto" ); - if (bAutoColor && rColor.GetColor() == OOXML_COLOR_AUTO) - return color; - - if ( rColor.GetColor() != COL_AUTO ) + if ( rColor != COL_AUTO ) { const char pHexDigits[] = "0123456789ABCDEF"; char pBuffer[] = "000000"; |