summaryrefslogtreecommitdiff
path: root/filter
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2017-03-16 21:22:36 +0000
committerCaolán McNamara <caolanm@redhat.com>2017-04-07 09:01:53 +0000
commit60aac84fc83ca6d527d06cf4ce031d7ef5ffee48 (patch)
treec361002dccdc0c577c0be94b4bc94ffd311f0e9e /filter
parentfef765d68d090bb439f58347afc930f48567673e (diff)
ofz#888: use after free
Change-Id: I6d3f9108b02149165b020fc9c6677880456a1ef4 Reviewed-on: https://gerrit.libreoffice.org/35298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'filter')
-rw-r--r--filter/source/msfilter/svdfppt.cxx13
1 files changed, 12 insertions, 1 deletions
diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index dfd8148bf699..92d9025f75f9 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -2934,7 +2934,18 @@ void SdrPowerPointImport::ImportPage( SdrPage* pRet, const PptSlidePersistEntry*
// obsolete here, too.
pRet->getSdrPageProperties().ClearItem();
pRet->getSdrPageProperties().PutItemSet(rSlidePersist.pBObj->GetMergedItemSet());
- SdrObject::Free( rSlidePersist.pBObj );
+ if (rSlidePersist.pSolverContainer)
+ {
+ for (SvxMSDffConnectorRule* pPtr : rSlidePersist.pSolverContainer->aCList)
+ {
+ // check connections to the group object
+ if (pPtr->pAObj == rSlidePersist.pBObj)
+ pPtr->pAObj = nullptr;
+ if (pPtr->pBObj == rSlidePersist.pBObj)
+ pPtr->pBObj = nullptr;
+ }
+ }
+ SdrObject::Free(rSlidePersist.pBObj);
}
}
}