summaryrefslogtreecommitdiff
path: root/filter
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2015-01-20 12:38:10 +0200
committerNoel Grandin <noel@peralex.com>2015-01-26 08:42:28 +0200
commitb44cbb26efe1d0b0950b1e1613e131b506dc3876 (patch)
tree9b4d5d99e5dad0971079b997a02a6d96536709ca /filter
parent26ad60aec69310fecd918f1c2e09056aa4782320 (diff)
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
Diffstat (limited to 'filter')
-rw-r--r--filter/source/config/cache/basecontainer.hxx2
-rw-r--r--filter/source/config/cache/cacheupdatelistener.hxx4
-rw-r--r--filter/source/config/cache/filtercache.hxx32
-rw-r--r--filter/source/config/cache/querytokenizer.hxx2
-rw-r--r--filter/source/graphicfilter/icgm/outact.hxx2
-rw-r--r--filter/source/graphicfilter/idxf/dxfentrd.hxx2
6 files changed, 22 insertions, 22 deletions
diff --git a/filter/source/config/cache/basecontainer.hxx b/filter/source/config/cache/basecontainer.hxx
index 97091b003a3f..dc8ce7767e88 100644
--- a/filter/source/config/cache/basecontainer.hxx
+++ b/filter/source/config/cache/basecontainer.hxx
@@ -155,7 +155,7 @@ class BaseContainer : public BaseLock
specify, which sub container of the used filter cache
must be wrapped by this container interface.
*/
- virtual void init(const css::uno::Reference< css::uno::XComponentContext >& rxContext ,
+ void init(const css::uno::Reference< css::uno::XComponentContext >& rxContext ,
const OUString& sImplementationName,
const css::uno::Sequence< OUString >& lServiceNames ,
FilterCache::EItemType eType );
diff --git a/filter/source/config/cache/cacheupdatelistener.hxx b/filter/source/config/cache/cacheupdatelistener.hxx
index 1d5572b5517f..a6b2e7410110 100644
--- a/filter/source/config/cache/cacheupdatelistener.hxx
+++ b/filter/source/config/cache/cacheupdatelistener.hxx
@@ -92,13 +92,13 @@ class CacheUpdateListener : public BaseLock // must be the first one to guarante
/** @short starts listening.
*/
- virtual void startListening();
+ void startListening();
/** @short stop listening.
*/
- virtual void stopListening();
+ void stopListening();
// uno interface
diff --git a/filter/source/config/cache/filtercache.hxx b/filter/source/config/cache/filtercache.hxx
index 883ced96e553..1c3d998fc0d2 100644
--- a/filter/source/config/cache/filtercache.hxx
+++ b/filter/source/config/cache/filtercache.hxx
@@ -300,13 +300,13 @@ class FilterCache : public BaseLock
@note The cloned instance is created on the heap. The user of this instance
has to remove it later.
*/
- virtual FilterCache* clone() const;
+ FilterCache* clone() const;
/** @short copy the cache content or rClone back to this instance.
*/
- virtual void takeOver(const FilterCache& rClone);
+ void takeOver(const FilterCache& rClone);
@@ -325,7 +325,7 @@ class FilterCache : public BaseLock
at all if this method does nothing inside, because the cache
is already full filled!
*/
- virtual void load(EFillState eRequired)
+ void load(EFillState eRequired)
throw(css::uno::Exception);
@@ -341,7 +341,7 @@ class FilterCache : public BaseLock
@return sal_True if the required fill state exists for this cache; FALSE
otherwise.
*/
- virtual bool isFillState(EFillState eRequired) const
+ bool isFillState(EFillState eRequired) const
throw(css::uno::Exception);
@@ -377,7 +377,7 @@ class FilterCache : public BaseLock
if some input parameter are wrong or the cache itself is not valid
any longer, because any operation before damage it.
*/
- virtual OUStringList getMatchingItemsByProps( EItemType eType ,
+ OUStringList getMatchingItemsByProps( EItemType eType ,
const CacheItem& lIProps ,
const CacheItem& lEProps = CacheItem()) const
throw(css::uno::Exception);
@@ -405,7 +405,7 @@ class FilterCache : public BaseLock
if some input parameter are wrong or the cache itself is not valid
any longer, because any operation before damage it.
*/
- virtual bool hasItems(EItemType eType) const
+ bool hasItems(EItemType eType) const
throw(css::uno::Exception);
@@ -430,7 +430,7 @@ class FilterCache : public BaseLock
if some input parameter are wrong or the cache itself is not valid
any longer, because any operation before damage it.
*/
- virtual OUStringList getItemNames(EItemType eType) const
+ OUStringList getItemNames(EItemType eType) const
throw(css::uno::Exception);
@@ -454,7 +454,7 @@ class FilterCache : public BaseLock
if some input parameter are wrong or the cache itself is not valid
any longer, because any operation before damage it.
*/
- virtual bool hasItem( EItemType eType,
+ bool hasItem( EItemType eType,
const OUString& sItem)
throw(css::uno::Exception);
@@ -484,7 +484,7 @@ class FilterCache : public BaseLock
if some input parameter are wrong or the cache itself is not valid
any longer, because any operation before damage it.
*/
- virtual CacheItem getItem( EItemType eType,
+ CacheItem getItem( EItemType eType,
const OUString& sItem)
throw(css::uno::Exception);
@@ -492,7 +492,7 @@ class FilterCache : public BaseLock
/** TODO document me ...
*/
- virtual void removeItem( EItemType eType,
+ void removeItem( EItemType eType,
const OUString& sItem)
throw(css::uno::Exception);
@@ -500,7 +500,7 @@ class FilterCache : public BaseLock
/** TODO document me ...
*/
- virtual void setItem( EItemType eType ,
+ void setItem( EItemType eType ,
const OUString& sItem ,
const CacheItem& aValue)
throw(css::uno::Exception, std::exception);
@@ -509,7 +509,7 @@ class FilterCache : public BaseLock
/** TODO document me ...
*/
- virtual void refreshItem( EItemType eType,
+ void refreshItem( EItemType eType,
const OUString& sItem)
throw(css::uno::Exception);
@@ -550,7 +550,7 @@ class FilterCache : public BaseLock
was not migrated to the new one. So we can't provide write access
to such items ...
*/
- virtual void addStatePropsToItem( EItemType eType,
+ void addStatePropsToItem( EItemType eType,
const OUString& sItem,
CacheItem& rItem)
throw(css::uno::Exception);
@@ -559,7 +559,7 @@ class FilterCache : public BaseLock
/** TODO document me
*/
- virtual void removeStatePropsFromItem(CacheItem& aValue)
+ void removeStatePropsFromItem(CacheItem& aValue)
throw(css::uno::Exception);
@@ -573,7 +573,7 @@ class FilterCache : public BaseLock
if the cache itself is not valid
any longer, because any operation before damage it.
*/
- virtual void flush()
+ void flush()
throw(css::uno::Exception);
@@ -604,7 +604,7 @@ class FilterCache : public BaseLock
if the cache itself is not valid
any longer, because any operation before damage it.
*/
- virtual void detectFlatForURL(const css::util::URL& aURL ,
+ void detectFlatForURL(const css::util::URL& aURL ,
FlatDetection& rFlatTypes) const
throw(css::uno::Exception);
diff --git a/filter/source/config/cache/querytokenizer.hxx b/filter/source/config/cache/querytokenizer.hxx
index 2ad810cfefb1..cb754e5a2c6a 100644
--- a/filter/source/config/cache/querytokenizer.hxx
+++ b/filter/source/config/cache/querytokenizer.hxx
@@ -91,7 +91,7 @@ class QueryTokenizer : public std::unordered_map< OUString ,
/** @short can be used to check if analyzing of given query
was successfully or not.
*/
- virtual bool valid() const;
+ bool valid() const;
};
} // namespace config
diff --git a/filter/source/graphicfilter/icgm/outact.hxx b/filter/source/graphicfilter/icgm/outact.hxx
index 49712e1f44ff..2a8dd5f48ec1 100644
--- a/filter/source/graphicfilter/icgm/outact.hxx
+++ b/filter/source/graphicfilter/icgm/outact.hxx
@@ -63,7 +63,7 @@ class CGMOutAct
public:
CGMOutAct( CGM& rCGM );
virtual ~CGMOutAct();
- virtual void FirstOutPut() { mpCGM->mbFirstOutPut = false; } ;
+ void FirstOutPut() { mpCGM->mbFirstOutPut = false; } ;
virtual void InsertPage() { mnCurrentPage++; } ;
virtual void BeginGroup() {} ;
virtual void EndGroup() {};
diff --git a/filter/source/graphicfilter/idxf/dxfentrd.hxx b/filter/source/graphicfilter/idxf/dxfentrd.hxx
index 03c10c53109a..276450e9fc4c 100644
--- a/filter/source/graphicfilter/idxf/dxfentrd.hxx
+++ b/filter/source/graphicfilter/idxf/dxfentrd.hxx
@@ -78,7 +78,7 @@ protected:
public:
virtual ~DXFBasicEntity();
- virtual void Read(DXFGroupReader & rDGR);
+ void Read(DXFGroupReader & rDGR);
// Reads a parameter till the next 0-group
protected: