diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-15 09:17:14 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-15 09:30:05 +0200 |
| commit | 538635e089cac31ddf433f650e86de5e2b7f03cc (patch) | |
| tree | 1f0e246954203f0d480e5ec61c049feec0ec76f1 /filter | |
| parent | c3c4ae5fdac0341f01eeed8d5c633d203eed8b2a (diff) | |
Make OGenericUnoDialog::destoryDialog non-virtual
...it is only ever called:
* either from dtors, where the virtual-ness doesn't acutally help (and would
trigger loplugin:fragiledestructor if that were enabled)
* or, in module filter, from executeDialog members of (final) classes directly
derived from OGenericUnODialog without overriding destroyDialog
Change-Id: If9a7370385a27952189423e5632b3f01e18ddbb5
Diffstat (limited to 'filter')
| -rw-r--r-- | filter/source/flash/swfdialog.hxx | 9 | ||||
| -rw-r--r-- | filter/source/pdf/pdfdialog.hxx | 5 | ||||
| -rw-r--r-- | filter/source/svg/svgdialog.hxx | 9 |
3 files changed, 13 insertions, 10 deletions
diff --git a/filter/source/flash/swfdialog.hxx b/filter/source/flash/swfdialog.hxx index f8a403d4ac92..8875a7e07b61 100644 --- a/filter/source/flash/swfdialog.hxx +++ b/filter/source/flash/swfdialog.hxx @@ -30,10 +30,11 @@ namespace vcl { class Window; } class ResMgr; -class SWFDialog : public ::svt::OGenericUnoDialog, - public ::comphelper::OPropertyArrayUsageHelper< SWFDialog >, - public css::beans::XPropertyAccess, - public css::document::XExporter +class SWFDialog final: + public ::svt::OGenericUnoDialog, + public ::comphelper::OPropertyArrayUsageHelper< SWFDialog >, + public css::beans::XPropertyAccess, + public css::document::XExporter { private: diff --git a/filter/source/pdf/pdfdialog.hxx b/filter/source/pdf/pdfdialog.hxx index b20cd4cd65a7..c40adedd9c13 100644 --- a/filter/source/pdf/pdfdialog.hxx +++ b/filter/source/pdf/pdfdialog.hxx @@ -30,8 +30,9 @@ namespace vcl { class Window; } typedef ::cppu::ImplInheritanceHelper < ::svt::OGenericUnoDialog, XPropertyAccess, XExporter > PDFDialog_Base; -class PDFDialog : public PDFDialog_Base, - public ::comphelper::OPropertyArrayUsageHelper< PDFDialog > +class PDFDialog final: + public PDFDialog_Base, + public ::comphelper::OPropertyArrayUsageHelper< PDFDialog > { private: Sequence< PropertyValue > maMediaDescriptor; diff --git a/filter/source/svg/svgdialog.hxx b/filter/source/svg/svgdialog.hxx index 24f80de25c69..80a4e283aa36 100644 --- a/filter/source/svg/svgdialog.hxx +++ b/filter/source/svg/svgdialog.hxx @@ -30,10 +30,11 @@ class ResMgr; -class SVGDialog : public ::svt::OGenericUnoDialog, - public ::comphelper::OPropertyArrayUsageHelper< SVGDialog >, - public css::beans::XPropertyAccess, - public css::document::XExporter +class SVGDialog final: + public ::svt::OGenericUnoDialog, + public ::comphelper::OPropertyArrayUsageHelper< SVGDialog >, + public css::beans::XPropertyAccess, + public css::document::XExporter { private: |