diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-01-31 14:46:38 +0200 |
---|---|---|
committer | Ashod Nakashian <ashod.nakashian@collabora.co.uk> | 2017-12-05 08:17:11 -0500 |
commit | 9ca19666511b1d44ba554a70cbbc0c8e2db844c6 (patch) | |
tree | 39a0bd694d2f1cf5d5a67082b85717e5bb2cbef0 /filter | |
parent | 6346e8c08e789e6aa4f2041fab97ba14419dedd4 (diff) |
loplugin:useuniqueptr extend to check local vars
just the simple and obvious case for now, of a local var being allocated
and deleted inside a single local block, and the delete happening at the
end of the block
Reviewed-on: https://gerrit.libreoffice.org/33749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 2489000d3fd66319a8355fd4e37cfdfda47296d0)
Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625
(cherry picked from commit e540ccfb5eb43bd4a3d6920074dce8436720ba8e)
Diffstat (limited to 'filter')
-rw-r--r-- | filter/source/xsltdialog/xmlfiltersettingsdialog.cxx | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx index 02b30e958faa..29afee37a3a1 100644 --- a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx +++ b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx @@ -1040,7 +1040,7 @@ void XMLFilterSettingsDialog::initFilterList() Sequence< PropertyValue > aValues; - filter_info_impl* pTempFilter = new filter_info_impl; + std::unique_ptr<filter_info_impl> pTempFilter( new filter_info_impl ); Sequence< OUString > aUserData; for( nFilter = 0; nFilter < nCount; nFilter++, pFilterName++ ) @@ -1187,11 +1187,11 @@ void XMLFilterSettingsDialog::initFilterList() } // add entry to internal container and to ui filter list box - maFilterVector.push_back( pTempFilter ); - m_pFilterListBox->addFilterEntry( pTempFilter ); + maFilterVector.push_back( pTempFilter.get() ); + m_pFilterListBox->addFilterEntry( pTempFilter.release() ); - pTempFilter = new filter_info_impl; + pTempFilter.reset( new filter_info_impl ); } catch( const Exception& ) { @@ -1199,8 +1199,6 @@ void XMLFilterSettingsDialog::initFilterList() } } - - delete pTempFilter; } SvTreeListEntry* pEntry = m_pFilterListBox->GetEntry( 0 ); |