diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-10 11:41:57 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-11 08:44:21 +0200 |
| commit | 19156dccf7040094ce682081545213abb321c559 (patch) | |
| tree | 3ce0affeaa71664089ab92f41d1305712b4ac7d5 /filter/source | |
| parent | a111a7ba4067dc11070c4b1ab6eb24cc89263770 (diff) | |
loplugin:datamembershadow in DXF filter
depending on which version of the DXF file format you look at, elevation
can be either group code 30 or group code 38. But since neither of these
fields is actually in use, lets just remove both until someone has an
actual use-case for them and can test against real data.
Change-Id: I4355b37c4b8513e8f9704272b269b2fe3f1c659f
Reviewed-on: https://gerrit.libreoffice.org/54104
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'filter/source')
| -rw-r--r-- | filter/source/graphicfilter/idxf/dxfentrd.cxx | 4 | ||||
| -rw-r--r-- | filter/source/graphicfilter/idxf/dxfentrd.hxx | 2 |
2 files changed, 0 insertions, 6 deletions
diff --git a/filter/source/graphicfilter/idxf/dxfentrd.cxx b/filter/source/graphicfilter/idxf/dxfentrd.cxx index 7a9074a0a770..bcb698994831 100644 --- a/filter/source/graphicfilter/idxf/dxfentrd.cxx +++ b/filter/source/graphicfilter/idxf/dxfentrd.cxx @@ -29,7 +29,6 @@ DXFBasicEntity::DXFBasicEntity(DXFEntityType eThisType) { eType=eThisType; pSucc=nullptr; - fElevation=0; fThickness=0; nColor=256; nSpace=0; @@ -49,7 +48,6 @@ void DXFBasicEntity::EvaluateGroup(DXFGroupReader & rDGR) { case 8: m_sLayer = rDGR.GetS(); break; case 6: m_sLineType = rDGR.GetS(); break; - case 38: fElevation=rDGR.GetF(); break; case 39: fThickness=rDGR.GetF(); break; case 62: nColor=rDGR.GetI(); break; case 67: nSpace=rDGR.GetI(); break; @@ -374,7 +372,6 @@ void DXFAttribEntity::EvaluateGroup(DXFGroupReader & rDGR) DXFPolyLineEntity::DXFPolyLineEntity() : DXFBasicEntity(DXF_POLYLINE) { - fElevation=0.0; nFlags=0; fSWidth=0.0; fEWidth=0.0; @@ -388,7 +385,6 @@ DXFPolyLineEntity::DXFPolyLineEntity() : DXFBasicEntity(DXF_POLYLINE) void DXFPolyLineEntity::EvaluateGroup(DXFGroupReader & rDGR) { switch (rDGR.GetG()) { - case 30: fElevation=rDGR.GetF(); break; case 70: nFlags=rDGR.GetI(); break; case 40: fSWidth=rDGR.GetF(); break; case 41: fEWidth=rDGR.GetF(); break; diff --git a/filter/source/graphicfilter/idxf/dxfentrd.hxx b/filter/source/graphicfilter/idxf/dxfentrd.hxx index 39d9b12fbff6..f2aa8d3c90aa 100644 --- a/filter/source/graphicfilter/idxf/dxfentrd.hxx +++ b/filter/source/graphicfilter/idxf/dxfentrd.hxx @@ -64,7 +64,6 @@ public: // commented with group codes: OString m_sLayer; // 8 OString m_sLineType; // 6 - double fElevation; // 38 double fThickness; // 39 long nColor; // 62 long nSpace; // 67 @@ -304,7 +303,6 @@ class DXFPolyLineEntity : public DXFBasicEntity { public: - double fElevation; // 30 long nFlags; // 70 double fSWidth; // 40 double fEWidth; // 41 |