summaryrefslogtreecommitdiff
path: root/extensions
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2014-11-18 10:01:21 +0200
committerNoel Grandin <noel@peralex.com>2014-11-18 12:44:28 +0200
commit0063cf285696951e336b9cec1da8881997b286ce (patch)
treebe70dfd8127c35f9e4a6d18d4db459a587813bf4 /extensions
parent250391009aec9930abcc57930ddd4b6f56f4df9c (diff)
java: make fields final where possible
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
Diffstat (limited to 'extensions')
-rw-r--r--extensions/qa/integration/extensions/ComponentFactory.java2
-rw-r--r--extensions/qa/integration/extensions/ConsoleWait.java4
-rw-r--r--extensions/qa/integration/extensions/HelpTextProvider.java9
-rw-r--r--extensions/qa/integration/extensions/ServicesHandler.java4
4 files changed, 6 insertions, 13 deletions
diff --git a/extensions/qa/integration/extensions/ComponentFactory.java b/extensions/qa/integration/extensions/ComponentFactory.java
index 170e19a43667..ec848c4dfb06 100644
--- a/extensions/qa/integration/extensions/ComponentFactory.java
+++ b/extensions/qa/integration/extensions/ComponentFactory.java
@@ -24,7 +24,7 @@ import java.lang.reflect.Constructor;
public class ComponentFactory implements XSingleComponentFactory
{
- private Class m_handlerClass;
+ private final Class m_handlerClass;
private Constructor m_defaultConstructor;
private Constructor m_initConstructor;
diff --git a/extensions/qa/integration/extensions/ConsoleWait.java b/extensions/qa/integration/extensions/ConsoleWait.java
index b68290c83acd..bda281d2902b 100644
--- a/extensions/qa/integration/extensions/ConsoleWait.java
+++ b/extensions/qa/integration/extensions/ConsoleWait.java
@@ -23,14 +23,14 @@ import com.sun.star.lang.XComponent;
public class ConsoleWait implements com.sun.star.lang.XEventListener
{
- private Object m_disposable;
+ private final Object m_disposable;
/** a helper class which waits for a console ENTER key event in a dedicated thread,
and notifies a ConsoleWait object if this event happened
*/
private class WaitForEnter extends java.lang.Thread
{
- private ConsoleWait m_toNotify;
+ private final ConsoleWait m_toNotify;
private boolean m_done;
public WaitForEnter( ConsoleWait _toNotify )
diff --git a/extensions/qa/integration/extensions/HelpTextProvider.java b/extensions/qa/integration/extensions/HelpTextProvider.java
index 73cda71eef2a..8bd6596bc9b5 100644
--- a/extensions/qa/integration/extensions/HelpTextProvider.java
+++ b/extensions/qa/integration/extensions/HelpTextProvider.java
@@ -15,13 +15,6 @@
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-
-/*
- * HelpTextProvider.java
- *
- * Created on 16. November 2006, 09:44
- */
-
package integration.extensions;
import com.sun.star.inspection.XObjectInspectorUI;
@@ -33,7 +26,7 @@ import com.sun.star.lang.NoSupportException;
*/
public class HelpTextProvider implements XPropertyControlObserver
{
- private XObjectInspectorUI m_inspectorUI;
+ private final XObjectInspectorUI m_inspectorUI;
/**
* Creates a new instance of HelpTextProvider
diff --git a/extensions/qa/integration/extensions/ServicesHandler.java b/extensions/qa/integration/extensions/ServicesHandler.java
index 87ebb270ae84..516f2a25cc06 100644
--- a/extensions/qa/integration/extensions/ServicesHandler.java
+++ b/extensions/qa/integration/extensions/ServicesHandler.java
@@ -26,13 +26,13 @@ import com.sun.star.lang.XServiceInfo;
public class ServicesHandler implements XPropertyHandler
{
- private XComponentContext m_context;
+ private final XComponentContext m_context;
private String[] m_supportedServices;
private class ClickHandler implements com.sun.star.awt.XActionListener
{
XComponentContext m_context;
- private String m_serviceName;
+ private final String m_serviceName;
public ClickHandler( XComponentContext _context, String _serviceName )
{