diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-01 15:24:30 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-04 07:24:52 +0100 |
| commit | 68f86457525c60f580954280d1a759aa174e8e96 (patch) | |
| tree | d4f0d44d52cf3e744f1555074217e0f42007ac71 /extensions | |
| parent | 9634a818e8a9432db52bc8fcd534e7437e6bacee (diff) | |
new loplugin salcall: remove unnecessary SAL_CALL
In this first commit, I use the plugin to verify the consistency of our
SAL_CALL annotations.
The point being to make the next commit more mechanical in nature,
purely using the rewriter.
There are various chunks of unix-only code that have never had to be
compiled by MSVC, hence the inconsistencies.
In bridges, I had to inline some typedefs to make the verification code
happy, since it cannot see into typedefs.
Change-Id: Iec6e274bed857febf7295cfcf5e9f21fe4a34da0
Reviewed-on: https://gerrit.libreoffice.org/45502
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/source/propctrlr/eventhandler.hxx | 2 | ||||
| -rw-r--r-- | extensions/source/propctrlr/genericpropertyhandler.hxx | 2 | ||||
| -rw-r--r-- | extensions/source/scanner/scanunx.cxx | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/extensions/source/propctrlr/eventhandler.hxx b/extensions/source/propctrlr/eventhandler.hxx index bf6582623dd1..57274d235d75 100644 --- a/extensions/source/propctrlr/eventhandler.hxx +++ b/extensions/source/propctrlr/eventhandler.hxx @@ -100,7 +100,7 @@ namespace pcr static OUString SAL_CALL getImplementationName_static( ); /// @throws css::uno::RuntimeException static css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames_static( ); - static css::uno::Reference< css::uno::XInterface > Create( const css::uno::Reference< css::uno::XComponentContext >& _rxContext ); + static css::uno::Reference< css::uno::XInterface > SAL_CALL Create( const css::uno::Reference< css::uno::XComponentContext >& _rxContext ); private: explicit EventHandler( diff --git a/extensions/source/propctrlr/genericpropertyhandler.hxx b/extensions/source/propctrlr/genericpropertyhandler.hxx index c85732fc412d..51ac2f61e1a2 100644 --- a/extensions/source/propctrlr/genericpropertyhandler.hxx +++ b/extensions/source/propctrlr/genericpropertyhandler.hxx @@ -83,7 +83,7 @@ namespace pcr static OUString SAL_CALL getImplementationName_static( ); /// @throws css::uno::RuntimeException static css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames_static( ); - static css::uno::Reference< css::uno::XInterface > Create( const css::uno::Reference< css::uno::XComponentContext >& _rxContext ); + static css::uno::Reference< css::uno::XInterface > SAL_CALL Create( const css::uno::Reference< css::uno::XComponentContext >& _rxContext ); private: explicit GenericPropertyHandler( diff --git a/extensions/source/scanner/scanunx.cxx b/extensions/source/scanner/scanunx.cxx index 8d38481ba1d9..45015ef127f1 100644 --- a/extensions/source/scanner/scanunx.cxx +++ b/extensions/source/scanner/scanunx.cxx @@ -129,8 +129,8 @@ class ScannerThread : public osl::Thread ScannerManager* m_pManager; // just for the disposing call public: - virtual void run() override; - virtual void onTerminated() override { delete this; } + virtual void SAL_CALL run() override; + virtual void SAL_CALL onTerminated() override { delete this; } public: ScannerThread( const std::shared_ptr<SaneHolder>& pHolder, const Reference< css::lang::XEventListener >& listener, |