diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-03 11:56:52 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-03 14:54:55 +0200 |
commit | 0e493cae407cca65f58329b3319d9c836cdf5096 (patch) | |
tree | 97e90d58ea005ec20b0197f2c1663ae6275cbd4e /extensions | |
parent | b76037f44660808a978ff39864769a5621eab893 (diff) |
new loplugin:dbgunhandledexception
enforce that DBG_UNHANDLED_EXCEPTION is called first in a catch block,
otherwise it cannot do it's job properly
Change-Id: I906436c6861212c44f8f21552ccbceb54f15c6e1
Reviewed-on: https://gerrit.libreoffice.org/52303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'extensions')
-rw-r--r-- | extensions/source/propctrlr/formcomponenthandler.cxx | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/extensions/source/propctrlr/formcomponenthandler.cxx b/extensions/source/propctrlr/formcomponenthandler.cxx index 37db834b8d62..5f94899b054e 100644 --- a/extensions/source/propctrlr/formcomponenthandler.cxx +++ b/extensions/source/propctrlr/formcomponenthandler.cxx @@ -1937,8 +1937,8 @@ namespace pcr } catch( const Exception& ) { - OSL_FAIL( "FormComponentPropertyHandler::impl_updateDependentProperty_nothrow: caught an exception!" ); DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); + OSL_FAIL( "FormComponentPropertyHandler::impl_updateDependentProperty_nothrow: caught an exception!" ); } } @@ -2014,8 +2014,8 @@ namespace pcr } catch( const Exception& ) { - OSL_FAIL( "FormComponentPropertyHandler::onNewComponent: caught an exception!" ); DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); + OSL_FAIL( "FormComponentPropertyHandler::onNewComponent: caught an exception!" ); } } @@ -2268,8 +2268,8 @@ namespace pcr } catch( const Exception& ) { - OSL_FAIL( "FormComponentPropertyHandler::impl_getRowSet_nothrow: caught an exception!" ); DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); + OSL_FAIL( "FormComponentPropertyHandler::impl_getRowSet_nothrow: caught an exception!" ); } return xReturn; } @@ -2303,8 +2303,8 @@ namespace pcr } catch (const Exception&) { - OSL_FAIL( "FormComponentPropertyHandler::impl_initFieldList_nothrow: caught an exception!" ); DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); + OSL_FAIL( "FormComponentPropertyHandler::impl_initFieldList_nothrow: caught an exception!" ); } } @@ -2354,8 +2354,8 @@ namespace pcr } catch( const Exception& ) { - OSL_FAIL( "FormComponentPropertyHandler::impl_ensureRowsetConnection_nothrow: caught an exception during error handling!" ); DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); + OSL_FAIL( "FormComponentPropertyHandler::impl_ensureRowsetConnection_nothrow: caught an exception during error handling!" ); } // additional info about what happened INetURLObject aParser( sDataSourceName ); @@ -2413,8 +2413,8 @@ namespace pcr } catch (const Exception&) { - OSL_FAIL("FormComponentPropertyHandler::impl_describeCursorSource_nothrow: caught an exception !"); DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); + OSL_FAIL("FormComponentPropertyHandler::impl_describeCursorSource_nothrow: caught an exception !"); } } @@ -2586,8 +2586,8 @@ namespace pcr catch (const SQLException& e) { aErrorInfo = e; } catch( const Exception& ) { - OSL_FAIL( "FormComponentPropertyHandler::impl_dialogFilterOrSort_nothrow: caught an exception!" ); DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); + OSL_FAIL( "FormComponentPropertyHandler::impl_dialogFilterOrSort_nothrow: caught an exception!" ); } if ( aErrorInfo.isValid() ) @@ -2681,8 +2681,8 @@ namespace pcr } catch( const Exception& ) { - OSL_FAIL( "FormComponentPropertyHandler::impl_dialogFormatting_nothrow: : caught an exception!" ); DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); + OSL_FAIL( "FormComponentPropertyHandler::impl_dialogFormatting_nothrow: : caught an exception!" ); } return bChanged; } @@ -3196,8 +3196,8 @@ namespace pcr } catch( const Exception& ) { - OSL_FAIL( "FormComponentPropertyHandler::impl_hasValidDataSourceSignature_nothrow: caught an exception!" ); DBG_UNHANDLED_EXCEPTION("extensions.propctrlr"); + OSL_FAIL( "FormComponentPropertyHandler::impl_hasValidDataSourceSignature_nothrow: caught an exception!" ); } } return bHas; |