diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-01-30 16:38:54 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-01-31 08:56:20 +0000 |
| commit | 1c3e84d8192218befebcddae2ed9842d081dc6c7 (patch) | |
| tree | f4fc5cddd181d6d49bf55f74e6d3d107b8ae8d18 /embeddedobj | |
| parent | e1e6cdbb1e9ff37f0bb740a70045c66953bec50c (diff) | |
teach lolugin:stringconstant about calling constructors
so we can remove unnecessary calls to the OUString(literal) constructor
when calling constructors like this:
Foo(OUString("xxx"), 1)
Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36
Reviewed-on: https://gerrit.libreoffice.org/33698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'embeddedobj')
| -rw-r--r-- | embeddedobj/source/commonembedding/visobj.cxx | 4 | ||||
| -rw-r--r-- | embeddedobj/source/general/docholder.cxx | 2 | ||||
| -rw-r--r-- | embeddedobj/source/msole/oleembed.cxx | 2 | ||||
| -rw-r--r-- | embeddedobj/source/msole/olevisual.cxx | 8 |
4 files changed, 8 insertions, 8 deletions
diff --git a/embeddedobj/source/commonembedding/visobj.cxx b/embeddedobj/source/commonembedding/visobj.cxx index 8c7217d30256..d5d5ec744600 100644 --- a/embeddedobj/source/commonembedding/visobj.cxx +++ b/embeddedobj/source/commonembedding/visobj.cxx @@ -188,8 +188,8 @@ embed::VisualRepresentation SAL_CALL OCommonEmbeddedObject::getPreferredVisualRe throw uno::RuntimeException(); datatransfer::DataFlavor aDataFlavor( - OUString( "application/x-openoffice-gdimetafile;windows_formatname=\"GDIMetaFile\"" ), - OUString( "GDIMetaFile" ), + "application/x-openoffice-gdimetafile;windows_formatname=\"GDIMetaFile\"", + "GDIMetaFile", cppu::UnoType<uno::Sequence< sal_Int8 >>::get() ); if( xTransferable->isDataFlavorSupported( aDataFlavor )) diff --git a/embeddedobj/source/general/docholder.cxx b/embeddedobj/source/general/docholder.cxx index d06a690c437a..f9b2bcdd4204 100644 --- a/embeddedobj/source/general/docholder.cxx +++ b/embeddedobj/source/general/docholder.cxx @@ -430,7 +430,7 @@ bool DocumentHolder::ShowInplace( const uno::Reference< awt::XWindowPeer >& xPar } awt::WindowDescriptor aOwnWinDescriptor( awt::WindowClass_TOP, - OUString("dockingwindow"), + "dockingwindow", xMyParent, 0, awt::Rectangle(),//aOwnRectangle, diff --git a/embeddedobj/source/msole/oleembed.cxx b/embeddedobj/source/msole/oleembed.cxx index bb6bc4cea537..3bd35a7d4ac7 100644 --- a/embeddedobj/source/msole/oleembed.cxx +++ b/embeddedobj/source/msole/oleembed.cxx @@ -289,7 +289,7 @@ bool OleEmbeddedObject::TryToConvertToOOo() { // create the model uno::Sequence< uno::Any > aArguments(1); - aArguments[0] <<= beans::NamedValue( OUString( "EmbeddedObject" ), uno::makeAny( true )); + aArguments[0] <<= beans::NamedValue( "EmbeddedObject", uno::makeAny( true )); uno::Reference< util::XCloseable > xDocument( m_xFactory->createInstanceWithArguments( aDocServiceName, aArguments ), uno::UNO_QUERY_THROW ); uno::Reference< frame::XLoadable > xLoadable( xDocument, uno::UNO_QUERY_THROW ); diff --git a/embeddedobj/source/msole/olevisual.cxx b/embeddedobj/source/msole/olevisual.cxx index 6b197b547d35..03045f3c6ac2 100644 --- a/embeddedobj/source/msole/olevisual.cxx +++ b/embeddedobj/source/msole/olevisual.cxx @@ -55,16 +55,16 @@ embed::VisualRepresentation OleEmbeddedObject::GetVisualRepresentationInNativeFo { // it's a bitmap aVisualRepr.Flavor = datatransfer::DataFlavor( - OUString( "application/x-openoffice-bitmap;windows_formatname=\"Bitmap\"" ), - OUString( "Bitmap" ), + "application/x-openoffice-bitmap;windows_formatname=\"Bitmap\"", + "Bitmap", cppu::UnoType<uno::Sequence< sal_Int8 >>::get() ); } else { // it's a metafile aVisualRepr.Flavor = datatransfer::DataFlavor( - OUString( "application/x-openoffice-wmf;windows_formatname=\"Image WMF\"" ), - OUString( "Windows Metafile" ), + "application/x-openoffice-wmf;windows_formatname=\"Image WMF\"", + "Windows Metafile", cppu::UnoType<uno::Sequence< sal_Int8 >>::get() ); } |