diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2021-09-06 16:53:29 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2021-10-14 19:50:30 +0200 |
| commit | 04af4e4f55f3ef319a78edd4d0109e2e7eba90b6 (patch) | |
| tree | 66e321fcf89f2dc4895f60d0f8bb1840ce8f6cd6 /editeng | |
| parent | 6f761939196eb0963c218b2ac9263f358f946675 (diff) | |
[API CHANGE] Fix all bad UNOIDL identifiers across offapi
Identifiers containing underscores must start with an uppercase letter. (So
that the UNO implementation can use identifiers containing underscores and
starting with a lowercase letter for internal purposes, see e.g. the static_type
member functions in the C++ *.hdl files. idlc checks that with the -cid option,
while unoidl-write silently allows bad identifiers for now, see the TODO in
unoidl/source/sourceprovider-scanner.l, which can be dropped after this change.)
All of the affected identifiers were present since early OOo times, but none of
them appear to be used much, at least not across LO itself, so there is hope
that we can get away with these incompatible changes. (For the constant group
members, we could roll this out in two steps, introducing the new members
alongside the old ones and deprecating the old ones in a first step, then
removing the old, deprecated ones in a second step, so that third-party code
would have more time to adapt. But that would not work for the enum members and
interface methods, so just do all of this in one breaking step.)
udkapi happened to not contain any bad identifiers.
Change-Id: If2d4c16563606f9efb48b937c76af54746377428
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121725
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'editeng')
| -rw-r--r-- | editeng/source/misc/svxacorr.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index d809f373fbb3..0cd4e8d0d161 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -147,7 +147,7 @@ static bool lcl_IsUnsupportedUnicodeChar( CharClass const & rCC, const OUString& case css::i18n::UnicodeScript_kHangulCompatibilityJamo: case css::i18n::UnicodeScript_kEnclosedCJKLetterMonth: case css::i18n::UnicodeScript_kCJKCompatibility: - case css::i18n::UnicodeScript_k_CJKUnifiedIdeographsExtensionA: + case css::i18n::UnicodeScript_kCJKUnifiedIdeographsExtensionA: case css::i18n::UnicodeScript_kCJKUnifiedIdeograph: case css::i18n::UnicodeScript_kHangulSyllable: case css::i18n::UnicodeScript_kCJKCompatibilityIdeograph: |