summaryrefslogtreecommitdiff
path: root/dbaccess
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2020-04-08 12:36:53 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2020-05-10 12:02:44 +0200
commit366d08f2f6d4de922f6099c62bb81b49d89e0a68 (patch)
treeb232884af6e844c2f0994859e4b42efbc1ce654c /dbaccess
parent75a2257a5bd716a9f937abe5e53f305c983afd5d (diff)
new loplugin:simplifypointertobool
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
-rw-r--r--dbaccess/source/core/api/RowSet.cxx2
-rw-r--r--dbaccess/source/core/api/RowSetCache.cxx2
-rw-r--r--dbaccess/source/filter/xml/xmlExport.cxx2
-rw-r--r--dbaccess/source/ui/browser/dataview.cxx2
-rw-r--r--dbaccess/source/ui/uno/copytablewizard.cxx2
5 files changed, 5 insertions, 5 deletions
diff --git a/dbaccess/source/core/api/RowSet.cxx b/dbaccess/source/core/api/RowSet.cxx
index b197d28787a1..62383ecd5479 100644
--- a/dbaccess/source/core/api/RowSet.cxx
+++ b/dbaccess/source/core/api/RowSet.cxx
@@ -1488,7 +1488,7 @@ Reference< XIndexAccess > SAL_CALL ORowSet::getParameters( )
// complete command, and thus the parameters, changed
impl_disposeParametersContainer_nothrow();
- if ( !m_pParameters.get() && !m_aCommand.isEmpty() )
+ if ( !m_pParameters && !m_aCommand.isEmpty() )
{
try
{
diff --git a/dbaccess/source/core/api/RowSetCache.cxx b/dbaccess/source/core/api/RowSetCache.cxx
index e683a74e9c7a..eea0ecde4ae2 100644
--- a/dbaccess/source/core/api/RowSetCache.cxx
+++ b/dbaccess/source/core/api/RowSetCache.cxx
@@ -1555,7 +1555,7 @@ bool ORowSetCache::checkJoin(const Reference< XConnection>& _xConnection,
OUString sErrorMsg;
::connectivity::OSQLParser aSqlParser( m_aContext );
std::unique_ptr< ::connectivity::OSQLParseNode> pSqlParseNode( aSqlParser.parseTree(sErrorMsg,sSql));
- if ( pSqlParseNode.get() && SQL_ISRULE(pSqlParseNode, select_statement) )
+ if ( pSqlParseNode && SQL_ISRULE(pSqlParseNode, select_statement) )
{
OSQLParseNode* pTableRefCommalist = pSqlParseNode->getByRule(::connectivity::OSQLParseNode::table_ref_commalist);
OSL_ENSURE(pTableRefCommalist,"NO tables why!?");
diff --git a/dbaccess/source/filter/xml/xmlExport.cxx b/dbaccess/source/filter/xml/xmlExport.cxx
index 299c59eb1dad..64d84729c6e3 100644
--- a/dbaccess/source/filter/xml/xmlExport.cxx
+++ b/dbaccess/source/filter/xml/xmlExport.cxx
@@ -753,7 +753,7 @@ void ODBExport::exportCharSet()
void ODBExport::exportDelimiter()
{
- if ( m_aDelimiter.get() && m_aDelimiter->bUsed )
+ if ( m_aDelimiter && m_aDelimiter->bUsed )
{
AddAttribute(XML_NAMESPACE_DB, XML_FIELD,m_aDelimiter->sField);
AddAttribute(XML_NAMESPACE_DB, XML_STRING,m_aDelimiter->sText);
diff --git a/dbaccess/source/ui/browser/dataview.cxx b/dbaccess/source/ui/browser/dataview.cxx
index 123a329ee282..099199bc2ae4 100644
--- a/dbaccess/source/ui/browser/dataview.cxx
+++ b/dbaccess/source/ui/browser/dataview.cxx
@@ -112,7 +112,7 @@ namespace dbaui
{
const KeyEvent* pKeyEvent = _rNEvt.GetKeyEvent();
const vcl::KeyCode& aKeyCode = pKeyEvent->GetKeyCode();
- if ( m_pAccel.get() && m_pAccel->execute( aKeyCode ) )
+ if ( m_pAccel && m_pAccel->execute( aKeyCode ) )
// the accelerator consumed the event
return true;
[[fallthrough]];
diff --git a/dbaccess/source/ui/uno/copytablewizard.cxx b/dbaccess/source/ui/uno/copytablewizard.cxx
index 22591dedc00d..aed45a4846e9 100644
--- a/dbaccess/source/ui/uno/copytablewizard.cxx
+++ b/dbaccess/source/ui/uno/copytablewizard.cxx
@@ -187,7 +187,7 @@ namespace dbaui
public:
::osl::Mutex& getMutex() { return m_aMutex; }
- bool isInitialized() const { return m_xSourceConnection.is() && m_pSourceObject.get() && m_xDestConnection.is(); }
+ bool isInitialized() const { return m_xSourceConnection.is() && m_pSourceObject && m_xDestConnection.is(); }
protected:
explicit CopyTableWizard( const Reference< XComponentContext >& _rxORB );