diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-31 12:26:12 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-31 14:23:39 +0200 |
| commit | 56be2245bf11ddb64fcfbf8175a864d688ac5c1a (patch) | |
| tree | 567e7e061a2d1caf653fd44cc02e9c26512cb230 /dbaccess | |
| parent | 2702c2d1eb9af2d03d5e0a1b7704ab170a5e8d31 (diff) | |
loplugin:constparams in dbaccess
Change-Id: I4994c4f0ae614c8f98466f440412f28380ddd6a6
Reviewed-on: https://gerrit.libreoffice.org/40589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
72 files changed, 164 insertions, 164 deletions
diff --git a/dbaccess/qa/unit/dbtest_base.cxx b/dbaccess/qa/unit/dbtest_base.cxx index 9d3183b21e93..86914faee5c2 100644 --- a/dbaccess/qa/unit/dbtest_base.cxx +++ b/dbaccess/qa/unit/dbtest_base.cxx @@ -30,7 +30,7 @@ public: uno::Reference< XConnection > getConnectionForDocument( - uno::Reference< XOfficeDatabaseDocument >& xDocument); + uno::Reference< XOfficeDatabaseDocument > const & xDocument); }; uno::Reference< XOfficeDatabaseDocument > @@ -48,7 +48,7 @@ uno::Reference< XOfficeDatabaseDocument > } uno::Reference< XConnection > DBTestBase::getConnectionForDocument( - uno::Reference< XOfficeDatabaseDocument >& xDocument) + uno::Reference< XOfficeDatabaseDocument > const & xDocument) { uno::Reference< XDataSource > xDataSource = xDocument->getDataSource(); CPPUNIT_ASSERT(xDataSource.is()); diff --git a/dbaccess/source/core/api/KeySet.cxx b/dbaccess/source/core/api/KeySet.cxx index bab0851063d3..849b83620fa8 100644 --- a/dbaccess/source/core/api/KeySet.cxx +++ b/dbaccess/source/core/api/KeySet.cxx @@ -151,7 +151,7 @@ void OKeySet::findTableColumnsMatching_throw( const Any& i_aTable, const OUString& i_rUpdateTableName, const Reference<XDatabaseMetaData>& i_xMeta, const Reference<XNameAccess>& i_xQueryColumns, - std::unique_ptr<SelectColumnsMetaData>& o_pKeyColumnNames) + std::unique_ptr<SelectColumnsMetaData> const & o_pKeyColumnNames) { // first ask the database itself for the best columns which can be used Sequence< OUString> aBestColumnNames; @@ -822,7 +822,7 @@ void OKeySet::tryRefetch(const ORowSetRow& _rInsertRow,bool bRefetch) } } -void OKeySet::copyRowValue(const ORowSetRow& _rInsertRow,ORowSetRow& _rKeyRow,sal_Int32 i_nBookmark) +void OKeySet::copyRowValue(const ORowSetRow& _rInsertRow, ORowSetRow const & _rKeyRow, sal_Int32 i_nBookmark) { connectivity::ORowVector< ORowSetValue >::Vector::iterator aIter = _rKeyRow->get().begin(); diff --git a/dbaccess/source/core/api/KeySet.hxx b/dbaccess/source/core/api/KeySet.hxx index 266b51ca28a0..d72643385d87 100644 --- a/dbaccess/source/core/api/KeySet.hxx +++ b/dbaccess/source/core/api/KeySet.hxx @@ -114,7 +114,7 @@ namespace dbaccess * \param _rKeyRow The current key row of the row set. + \param i_nBookmark The bookmark is used to update the parameter */ - void copyRowValue(const ORowSetRow& _rInsertRow,ORowSetRow& _rKeyRow,sal_Int32 i_nBookmark); + void copyRowValue(const ORowSetRow& _rInsertRow, ORowSetRow const & _rKeyRow, sal_Int32 i_nBookmark); css::uno::Reference< css::container::XNameAccess > getKeyColumns() const; // returns true if it did any work @@ -128,7 +128,7 @@ namespace dbaccess const OUString& i_rUpdateTableName, const css::uno::Reference< css::sdbc::XDatabaseMetaData>& i_xMeta, const css::uno::Reference< css::container::XNameAccess>& i_xQueryColumns, - std::unique_ptr<SelectColumnsMetaData>& o_pKeyColumnNames); + std::unique_ptr<SelectColumnsMetaData> const & o_pKeyColumnNames); void ensureStatement( ); virtual void makeNewStatement( ); static void setOneKeyColumnParameter( sal_Int32 &nPos, diff --git a/dbaccess/source/core/api/RowSet.cxx b/dbaccess/source/core/api/RowSet.cxx index 68da787a81dc..78eebe9c53cd 100644 --- a/dbaccess/source/core/api/RowSet.cxx +++ b/dbaccess/source/core/api/RowSet.cxx @@ -598,7 +598,7 @@ void ORowSet::freeResources( bool _bComplete ) } } -void ORowSet::setActiveConnection( Reference< XConnection >& _rxNewConn, bool _bFireEvent ) +void ORowSet::setActiveConnection( Reference< XConnection > const & _rxNewConn, bool _bFireEvent ) { if (_rxNewConn.get() == m_xActiveConnection.get()) // nothing to do diff --git a/dbaccess/source/core/api/RowSet.hxx b/dbaccess/source/core/api/RowSet.hxx index c580264574e3..b4dc3e067837 100644 --- a/dbaccess/source/core/api/RowSet.hxx +++ b/dbaccess/source/core/api/RowSet.hxx @@ -403,7 +403,7 @@ namespace dbaccess void approveExecution(); /// set m_xActiveConnection, fire a PropertyChangeEvent if necessary, do the event listener handling etc - void setActiveConnection( css::uno::Reference< css::sdbc::XConnection >& _rxNewConn, bool _bFireEvent = true ); + void setActiveConnection( css::uno::Reference< css::sdbc::XConnection > const & _rxNewConn, bool _bFireEvent = true ); void implCancelRowUpdates( bool _bNotifyModified ); diff --git a/dbaccess/source/core/api/RowSetBase.cxx b/dbaccess/source/core/api/RowSetBase.cxx index 6a4dfbfe4587..44296286f0f0 100644 --- a/dbaccess/source/core/api/RowSetBase.cxx +++ b/dbaccess/source/core/api/RowSetBase.cxx @@ -776,8 +776,8 @@ void SAL_CALL ORowSetBase::afterLast( ) SAL_INFO("dbaccess", "ORowSetBase::afterLast() Clone = " << m_bClone); } -bool SAL_CALL ORowSetBase::move( std::mem_fun_t<bool,ORowSetBase>& _aCheckFunctor, - std::mem_fun_t<bool,ORowSetCache>& _aMovementFunctor) +bool SAL_CALL ORowSetBase::move( std::mem_fun_t<bool,ORowSetBase> const & _aCheckFunctor, + std::mem_fun_t<bool,ORowSetCache> const & _aMovementFunctor) { SAL_INFO("dbaccess", "ORowSetBase::move() Clone = " << m_bClone); ::connectivity::checkDisposed(m_rBHelper.bDisposed); diff --git a/dbaccess/source/core/api/RowSetBase.hxx b/dbaccess/source/core/api/RowSetBase.hxx index 51caea40de89..4f1334277fb1 100644 --- a/dbaccess/source/core/api/RowSetBase.hxx +++ b/dbaccess/source/core/api/RowSetBase.hxx @@ -203,8 +203,8 @@ namespace dbaccess @return <TRUE/> if movement was successful. */ - bool SAL_CALL move( std::mem_fun_t<bool,ORowSetBase>& _aCheckFunctor, - std::mem_fun_t<bool,ORowSetCache>& _aMovementFunctor); + bool SAL_CALL move( std::mem_fun_t<bool,ORowSetBase> const & _aCheckFunctor, + std::mem_fun_t<bool,ORowSetCache> const & _aMovementFunctor); /** same meaning as isFirst. Only need by mem_fun @return diff --git a/dbaccess/source/core/api/RowSetCache.cxx b/dbaccess/source/core/api/RowSetCache.cxx index 8bd299112e1c..529b33917463 100644 --- a/dbaccess/source/core/api/RowSetCache.cxx +++ b/dbaccess/source/core/api/RowSetCache.cxx @@ -1327,7 +1327,7 @@ void ORowSetCache::cancelRowModification() resetInsertRow(false); } -void ORowSetCache::updateRow( ORowSetMatrix::iterator& _rUpdateRow,std::vector< Any >& o_aBookmarks ) +void ORowSetCache::updateRow( ORowSetMatrix::iterator const & _rUpdateRow, std::vector< Any >& o_aBookmarks ) { if(isAfterLast() || isBeforeFirst()) throw SQLException(DBA_RES(RID_STR_NO_UPDATEROW),nullptr,SQLSTATE_GENERAL,1000,Any() ); @@ -1719,7 +1719,7 @@ void ORowSetCache::reset(const Reference< XResultSet>& _xDriverSet) } void ORowSetCache::impl_updateRowFromCache_throw(ORowSetValueVector::Vector& io_aRow - ,std::vector<sal_Int32>& o_ChangedColumns) + ,std::vector<sal_Int32> const & o_ChangedColumns) { if ( o_ChangedColumns.size() > 1 ) { diff --git a/dbaccess/source/core/api/RowSetCache.hxx b/dbaccess/source/core/api/RowSetCache.hxx index 9488c76e7078..2a90278afd5f 100644 --- a/dbaccess/source/core/api/RowSetCache.hxx +++ b/dbaccess/source/core/api/RowSetCache.hxx @@ -104,7 +104,7 @@ namespace dbaccess ); void impl_updateRowFromCache_throw(ORowSetValueVector::Vector& io_aRow - ,std::vector<sal_Int32>& o_ChangedColumns + ,std::vector<sal_Int32> const & o_ChangedColumns ); // checks and set the flags isAfterLast isLast and position when afterlast is true void checkPositionFlags(); @@ -190,7 +190,7 @@ namespace dbaccess bool insertRow(std::vector< css::uno::Any >& o_aBookmarks); void resetInsertRow(bool _bClearInsertRow); - void updateRow( ORowSetMatrix::iterator& _rUpdateRow,std::vector< css::uno::Any >& o_aBookmarks ); + void updateRow( ORowSetMatrix::iterator const & _rUpdateRow, std::vector< css::uno::Any >& o_aBookmarks ); bool deleteRow(); void cancelRowUpdates( ); void moveToInsertRow( ); diff --git a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx index d284a3e21e21..8767e47b7e65 100644 --- a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx +++ b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx @@ -961,7 +961,7 @@ Reference< XNameAccess > SAL_CALL OSingleSelectQueryComposer::getColumns( ) return m_aCurrentColumns[SelectColumns]; } -bool OSingleSelectQueryComposer::setORCriteria(OSQLParseNode* pCondition, OSQLParseTreeIterator& _rIterator, +bool OSingleSelectQueryComposer::setORCriteria(OSQLParseNode const * pCondition, OSQLParseTreeIterator& _rIterator, std::vector< std::vector < PropertyValue > >& rFilters, const Reference< css::util::XNumberFormatter > & xFormatter) const { // Round brackets around the expression @@ -997,7 +997,7 @@ bool OSingleSelectQueryComposer::setORCriteria(OSQLParseNode* pCondition, OSQLPa } } -bool OSingleSelectQueryComposer::setANDCriteria( OSQLParseNode * pCondition, +bool OSingleSelectQueryComposer::setANDCriteria( OSQLParseNode const * pCondition, OSQLParseTreeIterator& _rIterator, std::vector < PropertyValue >& rFilter, const Reference< XNumberFormatter > & xFormatter) const { // Round brackets @@ -1084,7 +1084,7 @@ bool OSingleSelectQueryComposer::setANDCriteria( OSQLParseNode * pCondition, return true; } -sal_Int32 OSingleSelectQueryComposer::getPredicateType(OSQLParseNode * _pPredicate) +sal_Int32 OSingleSelectQueryComposer::getPredicateType(OSQLParseNode const * _pPredicate) { sal_Int32 nPredicate = SQLFilterOperator::EQUAL; switch (_pPredicate->getNodeType()) @@ -1113,7 +1113,7 @@ sal_Int32 OSingleSelectQueryComposer::getPredicateType(OSQLParseNode * _pPredica return nPredicate; } -bool OSingleSelectQueryComposer::setComparsionPredicate(OSQLParseNode * pCondition, OSQLParseTreeIterator& _rIterator, +bool OSingleSelectQueryComposer::setComparsionPredicate(OSQLParseNode const * pCondition, OSQLParseTreeIterator const & _rIterator, std::vector < PropertyValue >& rFilter, const Reference< css::util::XNumberFormatter > & xFormatter) const { OSL_ENSURE(SQL_ISRULE(pCondition, comparison_predicate),"setComparsionPredicate: pCondition is not a ComparsionPredicate"); @@ -1221,7 +1221,7 @@ bool OSingleSelectQueryComposer::setComparsionPredicate(OSQLParseNode * pConditi } // Functions for analysing SQL -OUString OSingleSelectQueryComposer::getColumnName( ::connectivity::OSQLParseNode* pColumnRef, OSQLParseTreeIterator& _rIterator ) +OUString OSingleSelectQueryComposer::getColumnName( ::connectivity::OSQLParseNode const * pColumnRef, OSQLParseTreeIterator const & _rIterator ) { OUString aTableRange, aColumnName; _rIterator.getColumnRange(pColumnRef,aColumnName,aTableRange); @@ -1425,7 +1425,7 @@ OUString SAL_CALL OSingleSelectQueryComposer::getQueryWithSubstitution( ) return sSqlStatement; } -OUString OSingleSelectQueryComposer::getStatementPart( TGetParseNode& _aGetFunctor, OSQLParseTreeIterator& _rIterator ) +OUString OSingleSelectQueryComposer::getStatementPart( TGetParseNode const & _aGetFunctor, OSQLParseTreeIterator& _rIterator ) { OUString sResult; @@ -1529,7 +1529,7 @@ void SAL_CALL OSingleSelectQueryComposer::setStructuredHavingClause( const Seque setHavingClause(lcl_getCondition(filter, aPredicateInput, getColumns(), m_xMetaData->getIdentifierQuoteString())); } -void OSingleSelectQueryComposer::setConditionByColumn( const Reference< XPropertySet >& column, bool andCriteria ,std::mem_fun1_t<bool,OSingleSelectQueryComposer,const OUString& >& _aSetFunctor,sal_Int32 filterOperator) +void OSingleSelectQueryComposer::setConditionByColumn( const Reference< XPropertySet >& column, bool andCriteria, std::mem_fun1_t<bool,OSingleSelectQueryComposer,const OUString& > const & _aSetFunctor, sal_Int32 filterOperator) { try { @@ -1705,7 +1705,7 @@ void OSingleSelectQueryComposer::setConditionByColumn( const Reference< XPropert } } -Sequence< Sequence< PropertyValue > > OSingleSelectQueryComposer::getStructuredCondition( TGetParseNode& _aGetFunctor ) +Sequence< Sequence< PropertyValue > > OSingleSelectQueryComposer::getStructuredCondition( TGetParseNode const & _aGetFunctor ) { ::connectivity::checkDisposed(OSubComponent::rBHelper.bDisposed); diff --git a/dbaccess/source/core/dataaccess/connection.cxx b/dbaccess/source/core/dataaccess/connection.cxx index 30166707664d..f0dd27ebd7c5 100644 --- a/dbaccess/source/core/dataaccess/connection.cxx +++ b/dbaccess/source/core/dataaccess/connection.cxx @@ -262,7 +262,7 @@ void OConnection::setTypeMap(const Reference< XNameAccess > & typeMap) // OConnection OConnection::OConnection(ODatabaseSource& _rDB - , Reference< XConnection >& _rxMaster + , Reference< XConnection > const & _rxMaster , const Reference< XComponentContext >& _rxORB) :OSubComponent(m_aMutex, static_cast< OWeakObject* >(&_rDB)) // as the queries reroute their refcounting to us, this m_aMutex is okey. If the queries diff --git a/dbaccess/source/core/dataaccess/connection.hxx b/dbaccess/source/core/dataaccess/connection.hxx index dddeb3ec10af..a1c3eb0acfac 100644 --- a/dbaccess/source/core/dataaccess/connection.hxx +++ b/dbaccess/source/core/dataaccess/connection.hxx @@ -107,7 +107,7 @@ protected: virtual ~OConnection() override; public: OConnection(ODatabaseSource& _rDB - ,css::uno::Reference< css::sdbc::XConnection >& _rxMaster + ,css::uno::Reference< css::sdbc::XConnection > const & _rxMaster ,const css::uno::Reference< css::uno::XComponentContext >& _rxORB); // css::lang::XTypeProvider diff --git a/dbaccess/source/core/dataaccess/datasource.cxx b/dbaccess/source/core/dataaccess/datasource.cxx index 5f5aa0a4cede..1bf3af5fcd6c 100644 --- a/dbaccess/source/core/dataaccess/datasource.cxx +++ b/dbaccess/source/core/dataaccess/datasource.cxx @@ -306,7 +306,7 @@ public: const OUString& password, const Sequence< PropertyValue >& _aInfo, ODatabaseSource* _pDataSource); - void addEventListener(const Reference<XConnection>& _rxConnection,TConnectionMap::iterator& _rIter); + void addEventListener(const Reference<XConnection>& _rxConnection, TConnectionMap::iterator const & _rIter); }; OSharedConnectionManager::OSharedConnectionManager(const Reference< XComponentContext >& _rxContext) @@ -384,7 +384,7 @@ Reference<XConnection> OSharedConnectionManager::getConnection( const OUString& return xRet; } -void OSharedConnectionManager::addEventListener(const Reference<XConnection>& _rxConnection,TConnectionMap::iterator& _rIter) +void OSharedConnectionManager::addEventListener(const Reference<XConnection>& _rxConnection, TConnectionMap::iterator const & _rIter) { Reference<XComponent> xComp(_rxConnection,UNO_QUERY); xComp->addEventListener(this); diff --git a/dbaccess/source/core/dataaccess/documentdefinition.cxx b/dbaccess/source/core/dataaccess/documentdefinition.cxx index ed8f2b0aa045..360876726591 100644 --- a/dbaccess/source/core/dataaccess/documentdefinition.cxx +++ b/dbaccess/source/core/dataaccess/documentdefinition.cxx @@ -1407,7 +1407,7 @@ namespace namespace { - Reference< XFrame > lcl_getDatabaseDocumentFrame( ODatabaseModelImpl& _rImpl ) + Reference< XFrame > lcl_getDatabaseDocumentFrame( ODatabaseModelImpl const & _rImpl ) { Reference< XModel > xDatabaseDocumentModel( _rImpl.getModel_noCreate() ); @@ -1775,7 +1775,7 @@ Reference< util::XCloseable > ODocumentDefinition::getComponent() namespace { - Reference< XDatabaseDocumentUI > lcl_getDatabaseDocumentUI( ODatabaseModelImpl& _rModelImpl ) + Reference< XDatabaseDocumentUI > lcl_getDatabaseDocumentUI( ODatabaseModelImpl const & _rModelImpl ) { Reference< XDatabaseDocumentUI > xUI; diff --git a/dbaccess/source/core/dataaccess/documenteventexecutor.cxx b/dbaccess/source/core/dataaccess/documenteventexecutor.cxx index ff823f811875..2a4bce63bf8d 100644 --- a/dbaccess/source/core/dataaccess/documenteventexecutor.cxx +++ b/dbaccess/source/core/dataaccess/documenteventexecutor.cxx @@ -71,7 +71,7 @@ namespace dbaccess namespace { - void lcl_dispatchScriptURL_throw( DocumentEventExecutor_Data& _rDocExecData, + void lcl_dispatchScriptURL_throw( DocumentEventExecutor_Data const & _rDocExecData, const OUString& _rScriptURL, const DocumentEvent& _rTrigger ) { Reference< XModel > xDocument( _rDocExecData.xDocument.get(), UNO_QUERY_THROW ); diff --git a/dbaccess/source/core/inc/SingleSelectQueryComposer.hxx b/dbaccess/source/core/inc/SingleSelectQueryComposer.hxx index a10d84bfbc83..c2c8fd4136fa 100644 --- a/dbaccess/source/core/inc/SingleSelectQueryComposer.hxx +++ b/dbaccess/source/core/inc/SingleSelectQueryComposer.hxx @@ -108,16 +108,16 @@ namespace dbaccess // </properties> - bool setORCriteria(::connectivity::OSQLParseNode* pCondition, ::connectivity::OSQLParseTreeIterator& _rIterator, + bool setORCriteria(::connectivity::OSQLParseNode const * pCondition, ::connectivity::OSQLParseTreeIterator& _rIterator, std::vector< std::vector < css::beans::PropertyValue > >& rFilters, const css::uno::Reference< css::util::XNumberFormatter > & xFormatter) const; - bool setANDCriteria(::connectivity::OSQLParseNode* pCondition, ::connectivity::OSQLParseTreeIterator& _rIterator, + bool setANDCriteria(::connectivity::OSQLParseNode const * pCondition, ::connectivity::OSQLParseTreeIterator& _rIterator, std::vector < css::beans::PropertyValue > & rFilters, const css::uno::Reference< css::util::XNumberFormatter > & xFormatter) const; - bool setComparsionPredicate(::connectivity::OSQLParseNode* pCondition, ::connectivity::OSQLParseTreeIterator& _rIterator, + bool setComparsionPredicate(::connectivity::OSQLParseNode const * pCondition, ::connectivity::OSQLParseTreeIterator const & _rIterator, std::vector < css::beans::PropertyValue > & rFilters, const css::uno::Reference< css::util::XNumberFormatter > & xFormatter) const; - static OUString getColumnName(::connectivity::OSQLParseNode* pColumnRef,::connectivity::OSQLParseTreeIterator& _rIterator); + static OUString getColumnName(::connectivity::OSQLParseNode const * pColumnRef, ::connectivity::OSQLParseTreeIterator const & _rIterator); OUString getTableAlias(const css::uno::Reference< css::beans::XPropertySet >& column ) const; - static sal_Int32 getPredicateType(::connectivity::OSQLParseNode * _pPredicate); + static sal_Int32 getPredicateType(::connectivity::OSQLParseNode const * _pPredicate); // clears all Columns,Parameters and tables and insert it to their vectors void clearCurrentCollections(); // clears the columns collection given by EColumnType @@ -127,12 +127,12 @@ namespace dbaccess @param _rIterator the iterator to use. */ - OUString getStatementPart( TGetParseNode& _aGetFunctor, ::connectivity::OSQLParseTreeIterator& _rIterator ); + OUString getStatementPart( TGetParseNode const & _aGetFunctor, ::connectivity::OSQLParseTreeIterator& _rIterator ); void setQuery_Impl( const OUString& command ); void setConditionByColumn( const css::uno::Reference< css::beans::XPropertySet >& column , bool andCriteria - ,std::mem_fun1_t<bool,OSingleSelectQueryComposer,const OUString& >& _aSetFunctor + ,std::mem_fun1_t<bool,OSingleSelectQueryComposer,const OUString& > const & _aSetFunctor ,sal_Int32 filterOperator); /** getStructuredCondition returns the structured condition for the where or having clause @@ -143,7 +143,7 @@ namespace dbaccess The structured filter */ css::uno::Sequence< css::uno::Sequence< css::beans::PropertyValue > > - getStructuredCondition( TGetParseNode& _aGetFunctor ); + getStructuredCondition( TGetParseNode const & _aGetFunctor ); css::uno::Reference< css::container::XIndexAccess > setCurrentColumns( EColumnType _eType, const ::rtl::Reference< ::connectivity::OSQLColumns >& _rCols ); diff --git a/dbaccess/source/filter/xml/dbloader2.cxx b/dbaccess/source/filter/xml/dbloader2.cxx index 5f8d2d07fbcc..b1181bd46bb9 100644 --- a/dbaccess/source/filter/xml/dbloader2.cxx +++ b/dbaccess/source/filter/xml/dbloader2.cxx @@ -256,7 +256,7 @@ public: virtual void SAL_CALL cancel() override; private: - bool impl_executeNewDatabaseWizard( Reference< XModel >& _rxModel, bool& _bShouldStartTableWizard ); + bool impl_executeNewDatabaseWizard( Reference< XModel > const & _rxModel, bool& _bShouldStartTableWizard ); }; @@ -337,7 +337,7 @@ namespace } } -bool DBContentLoader::impl_executeNewDatabaseWizard( Reference< XModel >& _rxModel, bool& _bShouldStartTableWizard ) +bool DBContentLoader::impl_executeNewDatabaseWizard( Reference< XModel > const & _rxModel, bool& _bShouldStartTableWizard ) { Sequence<Any> aWizardArgs(comphelper::InitAnyPropertySequence( { diff --git a/dbaccess/source/ui/app/AppController.cxx b/dbaccess/source/ui/app/AppController.cxx index f283d0b5646f..86c6d7df25ad 100644 --- a/dbaccess/source/ui/app/AppController.cxx +++ b/dbaccess/source/ui/app/AppController.cxx @@ -1713,7 +1713,7 @@ bool OApplicationController::onContainerSelect(ElementType _eType) return true; } -bool OApplicationController::onEntryDoubleClick( SvTreeListBox& _rTree ) +bool OApplicationController::onEntryDoubleClick( SvTreeListBox const & _rTree ) { if ( getContainer() && getContainer()->isLeaf( _rTree.GetHdlEntry() ) ) { diff --git a/dbaccess/source/ui/app/AppController.hxx b/dbaccess/source/ui/app/AppController.hxx index 654f0c238c6a..d20375179298 100644 --- a/dbaccess/source/ui/app/AppController.hxx +++ b/dbaccess/source/ui/app/AppController.hxx @@ -459,7 +459,7 @@ namespace dbaui <TRUE/> if the double click event has been handled by the called, and should not be processed further. */ - bool onEntryDoubleClick(SvTreeListBox& _rTree); + bool onEntryDoubleClick(SvTreeListBox const & _rTree); /** called when a container (category) in the application view has been selected @param _pTree The tree list box. diff --git a/dbaccess/source/ui/app/AppDetailPageHelper.cxx b/dbaccess/source/ui/app/AppDetailPageHelper.cxx index d717c43eafaa..f259e609b701 100644 --- a/dbaccess/source/ui/app/AppDetailPageHelper.cxx +++ b/dbaccess/source/ui/app/AppDetailPageHelper.cxx @@ -95,7 +95,7 @@ namespace dbaui namespace { - SvTreeListEntry* lcl_findEntry_impl(DBTreeListBox& rTree,const OUString& _rName,SvTreeListEntry* _pFirst) + SvTreeListEntry* lcl_findEntry_impl(DBTreeListBox const & rTree, const OUString& _rName, SvTreeListEntry* _pFirst) { SvTreeListEntry* pReturn = nullptr; sal_Int32 nIndex = 0; @@ -122,7 +122,7 @@ namespace } return pReturn; } - SvTreeListEntry* lcl_findEntry(DBTreeListBox& rTree,const OUString& _rName,SvTreeListEntry* _pFirst) + SvTreeListEntry* lcl_findEntry(DBTreeListBox const & rTree, const OUString& _rName,SvTreeListEntry* _pFirst) { sal_Int32 nIndex = 0; OUString sErase = _rName.getToken(0,'/',nIndex); // we don't want to have the "private:forms" part @@ -512,7 +512,7 @@ sal_Int32 OAppDetailPageHelper::getElementCount() return nCount; } -bool OAppDetailPageHelper::isLeaf(SvTreeListEntry* _pEntry) +bool OAppDetailPageHelper::isLeaf(SvTreeListEntry const * _pEntry) { if ( !_pEntry ) return false; diff --git a/dbaccess/source/ui/app/AppDetailPageHelper.hxx b/dbaccess/source/ui/app/AppDetailPageHelper.hxx index b6c05d50ec7f..15f6970ae487 100644 --- a/dbaccess/source/ui/app/AppDetailPageHelper.hxx +++ b/dbaccess/source/ui/app/AppDetailPageHelper.hxx @@ -255,7 +255,7 @@ namespace dbaui @return <TRUE/> if the entry is a leaf, otherwise <FALSE/> */ - static bool isLeaf(SvTreeListEntry* _pEntry); + static bool isLeaf(SvTreeListEntry const * _pEntry); /** returns if one of the selected entries is a leaf @return diff --git a/dbaccess/source/ui/app/AppDetailView.cxx b/dbaccess/source/ui/app/AppDetailView.cxx index 90a6e77ac507..67d3d92d79f5 100644 --- a/dbaccess/source/ui/app/AppDetailView.cxx +++ b/dbaccess/source/ui/app/AppDetailView.cxx @@ -301,7 +301,7 @@ void OCreationList::updateHelpText() m_rTaskWindow.setHelpText(pHelpTextId); } -void OCreationList::onSelected( SvTreeListEntry* _pEntry ) const +void OCreationList::onSelected( SvTreeListEntry const * _pEntry ) const { OSL_ENSURE( _pEntry, "OCreationList::onSelected: invalid entry!" ); URL aCommand; @@ -599,7 +599,7 @@ void OApplicationDetailView::DataChanged( const DataChangedEvent& rDCEvt ) } } -void OApplicationDetailView::setTaskExternalMnemonics( MnemonicGenerator& _rMnemonics ) +void OApplicationDetailView::setTaskExternalMnemonics( MnemonicGenerator const & _rMnemonics ) { m_aExternalMnemonics = _rMnemonics; } @@ -732,7 +732,7 @@ OUString OApplicationDetailView::getQualifiedName( SvTreeListEntry* _pEntry ) co return m_pControlHelper->getQualifiedName( _pEntry ); } -bool OApplicationDetailView::isLeaf(SvTreeListEntry* _pEntry) +bool OApplicationDetailView::isLeaf(SvTreeListEntry const * _pEntry) { return OAppDetailPageHelper::isLeaf(_pEntry); } diff --git a/dbaccess/source/ui/app/AppDetailView.hxx b/dbaccess/source/ui/app/AppDetailView.hxx index 09093e2d2d5d..a3decc46ccda 100644 --- a/dbaccess/source/ui/app/AppDetailView.hxx +++ b/dbaccess/source/ui/app/AppDetailView.hxx @@ -79,7 +79,7 @@ namespace dbaui virtual void ExecuteSearchEntry( const void* _pEntry ) const override; private: - void onSelected( SvTreeListEntry* _pEntry ) const; + void onSelected( SvTreeListEntry const * _pEntry ) const; /** sets a new current entry, and invalidates the old and the new one, if necessary @return <TRUE/> if and only if the "current entry" changed */ @@ -177,7 +177,7 @@ namespace dbaui */ void createPage(ElementType _eType,const css::uno::Reference< css::container::XNameAccess >& _xContainer); - void setTaskExternalMnemonics( MnemonicGenerator& _rMnemonics ); + void setTaskExternalMnemonics( MnemonicGenerator const & _rMnemonics ); /** called to give the window the chance to intercept key events, while it has not the focus @@ -212,7 +212,7 @@ namespace dbaui @return <TRUE/> if the entry is a leaf, otherwise <FALSE/> */ - static bool isLeaf(SvTreeListEntry* _pEntry); + static bool isLeaf(SvTreeListEntry const * _pEntry); /** returns if one of the selected entries is a leaf @return diff --git a/dbaccess/source/ui/app/AppView.cxx b/dbaccess/source/ui/app/AppView.cxx index aa6518820570..73b6f93a7829 100644 --- a/dbaccess/source/ui/app/AppView.cxx +++ b/dbaccess/source/ui/app/AppView.cxx @@ -212,7 +212,7 @@ void OApplicationView::createIconAutoMnemonics( MnemonicGenerator& _rMnemonics ) m_pWin->getPanel()->createIconAutoMnemonics( _rMnemonics ); } -void OApplicationView::setTaskExternalMnemonics( MnemonicGenerator& _rMnemonics ) +void OApplicationView::setTaskExternalMnemonics( MnemonicGenerator const & _rMnemonics ) { if ( m_pWin && m_pWin->getDetailView() ) m_pWin->getDetailView()->setTaskExternalMnemonics( _rMnemonics ); @@ -334,7 +334,7 @@ OUString OApplicationView::getQualifiedName( SvTreeListEntry* _pEntry ) const return getDetailView()->getQualifiedName( _pEntry ); } -bool OApplicationView::isLeaf(SvTreeListEntry* _pEntry) const +bool OApplicationView::isLeaf(SvTreeListEntry const * _pEntry) const { OSL_ENSURE(m_pWin && getDetailView(),"Detail view is NULL! -> GPF"); return OApplicationDetailView::isLeaf(_pEntry); diff --git a/dbaccess/source/ui/app/AppView.hxx b/dbaccess/source/ui/app/AppView.hxx index cc34525ae665..6995cb4edb58 100644 --- a/dbaccess/source/ui/app/AppView.hxx +++ b/dbaccess/source/ui/app/AppView.hxx @@ -111,7 +111,7 @@ namespace dbaui void createIconAutoMnemonics( MnemonicGenerator& _rMnemonics ); /// automatically creates mnemonics for the texts in our task pane - void setTaskExternalMnemonics( MnemonicGenerator& _rMnemonics ); + void setTaskExternalMnemonics( MnemonicGenerator const & _rMnemonics ); // Window overrides virtual bool PreNotify( NotifyEvent& rNEvt ) override; @@ -147,7 +147,7 @@ namespace dbaui @return <TRUE/> if the entry is a leaf, otherwise <FALSE/> */ - bool isLeaf(SvTreeListEntry* _pEntry) const; + bool isLeaf(SvTreeListEntry const * _pEntry) const; /** returns if one of the selected entries is a leaf @return diff --git a/dbaccess/source/ui/browser/dsEntriesNoExp.cxx b/dbaccess/source/ui/browser/dsEntriesNoExp.cxx index f65391f910b9..76d23d7c955f 100644 --- a/dbaccess/source/ui/browser/dsEntriesNoExp.cxx +++ b/dbaccess/source/ui/browser/dsEntriesNoExp.cxx @@ -38,7 +38,7 @@ using namespace ::svx; namespace dbaui { -SbaTableQueryBrowser::EntryType SbaTableQueryBrowser::getChildType( SvTreeListEntry* _pEntry ) const +SbaTableQueryBrowser::EntryType SbaTableQueryBrowser::getChildType( SvTreeListEntry const * _pEntry ) const { OSL_ENSURE(isContainer(_pEntry), "SbaTableQueryBrowser::getChildType: invalid entry!"); switch (getEntryType(_pEntry)) diff --git a/dbaccess/source/ui/browser/dsbrowserDnD.cxx b/dbaccess/source/ui/browser/dsbrowserDnD.cxx index 850d514d2157..75e2bb1df2f9 100644 --- a/dbaccess/source/ui/browser/dsbrowserDnD.cxx +++ b/dbaccess/source/ui/browser/dsbrowserDnD.cxx @@ -199,7 +199,7 @@ namespace dbaui if( isEntryCopyAllowed( pSelected ) ) copyEntry( pSelected ); } - bool SbaTableQueryBrowser::isEntryCopyAllowed(SvTreeListEntry* _pEntry) const + bool SbaTableQueryBrowser::isEntryCopyAllowed(SvTreeListEntry const * _pEntry) const { EntryType eType = getEntryType(_pEntry); return ( eType == etTableOrView || eType == etQuery ); diff --git a/dbaccess/source/ui/browser/unodatbr.cxx b/dbaccess/source/ui/browser/unodatbr.cxx index b51a926b3d60..c2078eb2bd54 100644 --- a/dbaccess/source/ui/browser/unodatbr.cxx +++ b/dbaccess/source/ui/browser/unodatbr.cxx @@ -812,7 +812,7 @@ bool SbaTableQueryBrowser::InitializeGridModel(const Reference< css::form::XForm return true; } -Reference<XPropertySet> getColumnHelper(SvTreeListEntry* _pCurrentlyDisplayed,const Reference<XPropertySet>& _rxSource) +Reference<XPropertySet> getColumnHelper(SvTreeListEntry const * _pCurrentlyDisplayed, const Reference<XPropertySet>& _rxSource) { Reference<XPropertySet> xRet; if(_pCurrentlyDisplayed) @@ -2767,7 +2767,7 @@ void SAL_CALL SbaTableQueryBrowser::elementInserted( const ContainerEvent& _rEve SbaXDataBrowserController::elementInserted(_rEvent); } -bool SbaTableQueryBrowser::isCurrentlyDisplayedChanged(const OUString& _sName,SvTreeListEntry* _pContainer) +bool SbaTableQueryBrowser::isCurrentlyDisplayedChanged(const OUString& _sName, SvTreeListEntry const * _pContainer) { return m_pCurrentlyDisplayed && getEntryType(m_pCurrentlyDisplayed) == getChildType(_pContainer) diff --git a/dbaccess/source/ui/control/FieldControls.cxx b/dbaccess/source/ui/control/FieldControls.cxx index c2b8ee260375..d53518e8e435 100644 --- a/dbaccess/source/ui/control/FieldControls.cxx +++ b/dbaccess/source/ui/control/FieldControls.cxx @@ -38,10 +38,10 @@ void lcl_setSpecialReadOnly( bool _bReadOnly, vcl::Window* _pWin ) } OPropColumnEditCtrl::OPropColumnEditCtrl(vcl::Window* pParent, - rtl::OUString& _rAllowedChars, - const char* pHelpId, - short nPosition, - WinBits nWinStyle) + OUString const & _rAllowedChars, + const char* pHelpId, + short nPosition, + WinBits nWinStyle) :OSQLNameEdit(pParent, nWinStyle, _rAllowedChars) ,m_nPos(nPosition) { diff --git a/dbaccess/source/ui/control/FieldDescControl.cxx b/dbaccess/source/ui/control/FieldDescControl.cxx index 3b9ed80a3159..4308f7f780a2 100644 --- a/dbaccess/source/ui/control/FieldDescControl.cxx +++ b/dbaccess/source/ui/control/FieldDescControl.cxx @@ -248,7 +248,7 @@ IMPL_LINK(OFieldDescControl, OnScroll, ScrollBar*, /*pBar*/, void) namespace { - void getMaxXPosition(vcl::Window* _pWindow,long& _rnMaxXPosition) + void getMaxXPosition(vcl::Window const * _pWindow, long& _rnMaxXPosition) { if (_pWindow) { @@ -989,7 +989,7 @@ void OFieldDescControl::DeactivateAggregate( EControlType eType ) } } -void OFieldDescControl::SetPosSize( VclPtr<Control>& rControl, long nRow, sal_uInt16 nCol ) +void OFieldDescControl::SetPosSize( VclPtr<Control> const & rControl, long nRow, sal_uInt16 nCol ) { // Calculate size @@ -1497,7 +1497,7 @@ void OFieldDescControl::SaveData( OFieldDescription* pFieldDescr ) pFieldDescr->SetAutoIncrementValue(m_pAutoIncrementValue->GetText()); } -void OFieldDescControl::UpdateFormatSample(OFieldDescription* pFieldDescr) +void OFieldDescControl::UpdateFormatSample(OFieldDescription const * pFieldDescr) { if ( pFieldDescr && pFormatSample ) pFormatSample->SetText(getControlDefault(pFieldDescr,false)); diff --git a/dbaccess/source/ui/dlg/DbAdminImpl.cxx b/dbaccess/source/ui/dlg/DbAdminImpl.cxx index 8437c36f7e0b..04a6214198a8 100644 --- a/dbaccess/source/ui/dlg/DbAdminImpl.cxx +++ b/dbaccess/source/ui/dlg/DbAdminImpl.cxx @@ -91,7 +91,7 @@ using namespace com::sun::star::frame; namespace { - bool implCheckItemType( SfxItemSet& _rSet, const sal_uInt16 _nId, const std::function<bool ( const SfxPoolItem* )>& isItemType ) + bool implCheckItemType( SfxItemSet const & _rSet, const sal_uInt16 _nId, const std::function<bool ( const SfxPoolItem* )>& isItemType ) { bool bCorrectType = false; @@ -996,7 +996,7 @@ void ODbDataSourceAdministrationHelper::implTranslateProperty( SfxItemSet& _rSet } } -OUString ODbDataSourceAdministrationHelper::getDocumentUrl(SfxItemSet& _rDest) +OUString ODbDataSourceAdministrationHelper::getDocumentUrl(SfxItemSet const & _rDest) { const SfxStringItem* pUrlItem = _rDest.GetItem<SfxStringItem>(DSID_DOCUMENT_URL); OSL_ENSURE(pUrlItem,"Document URL is NULL. -> GPF!"); diff --git a/dbaccess/source/ui/dlg/DbAdminImpl.hxx b/dbaccess/source/ui/dlg/DbAdminImpl.hxx index e3ddd58d59d1..b86a6ff9dd24 100644 --- a/dbaccess/source/ui/dlg/DbAdminImpl.hxx +++ b/dbaccess/source/ui/dlg/DbAdminImpl.hxx @@ -105,7 +105,7 @@ namespace dbaui */ css::uno::Reference< css::beans::XPropertySet > const & getCurrentDataSource(); // returns the Url of a database document - static OUString getDocumentUrl(SfxItemSet& _rDest); + static OUString getDocumentUrl(SfxItemSet const & _rDest); void setDataSourceOrName( const css::uno::Any& _rDataSourceOrName ); diff --git a/dbaccess/source/ui/dlg/adminpages.cxx b/dbaccess/source/ui/dlg/adminpages.cxx index 8862f712ac0a..d5850a03961b 100644 --- a/dbaccess/source/ui/dlg/adminpages.cxx +++ b/dbaccess/source/ui/dlg/adminpages.cxx @@ -119,7 +119,7 @@ namespace dbaui { callModifiedHdl(&rCtrl); } - bool OGenericAdministrationPage::getSelectedDataSource(OUString& _sReturn, OUString& _sCurr) + bool OGenericAdministrationPage::getSelectedDataSource(OUString& _sReturn, OUString const & _sCurr) { // collect all ODBC data source names StringBag aOdbcDatasources; @@ -192,7 +192,7 @@ namespace dbaui { return true; } - void OGenericAdministrationPage::fillBool( SfxItemSet& _rSet, CheckBox* _pCheckBox, sal_uInt16 _nID, bool& _bChangedSomething, bool _bRevertValue ) + void OGenericAdministrationPage::fillBool( SfxItemSet& _rSet, CheckBox const * _pCheckBox, sal_uInt16 _nID, bool& _bChangedSomething, bool _bRevertValue ) { if ( _pCheckBox && _pCheckBox->IsValueChangedFromSaved() ) { @@ -213,7 +213,7 @@ namespace dbaui _bChangedSomething = true; } } - void OGenericAdministrationPage::fillInt32(SfxItemSet& _rSet, NumericField* _pEdit, sal_uInt16 _nID, bool& _bChangedSomething) + void OGenericAdministrationPage::fillInt32(SfxItemSet& _rSet, NumericField const * _pEdit, sal_uInt16 _nID, bool& _bChangedSomething) { if( _pEdit && _pEdit->IsValueChangedFromSaved() ) { @@ -221,7 +221,7 @@ namespace dbaui _bChangedSomething = true; } } - void OGenericAdministrationPage::fillString(SfxItemSet& _rSet, Edit* _pEdit, sal_uInt16 _nID, bool& _bChangedSomething) + void OGenericAdministrationPage::fillString(SfxItemSet& _rSet, Edit const * _pEdit, sal_uInt16 _nID, bool& _bChangedSomething) { if( _pEdit && _pEdit->IsValueChangedFromSaved() ) { diff --git a/dbaccess/source/ui/dlg/adminpages.hxx b/dbaccess/source/ui/dlg/adminpages.hxx index b276bbe61e5f..c31942b12fce 100644 --- a/dbaccess/source/ui/dlg/adminpages.hxx +++ b/dbaccess/source/ui/dlg/adminpages.hxx @@ -113,7 +113,7 @@ namespace dbaui @return <FALSE/> if an error occurred, otherwise <TRUE/> */ - bool getSelectedDataSource(OUString& _sReturn, OUString& _sCurr); + bool getSelectedDataSource(OUString& _sReturn, OUString const & _sCurr); // svt::IWizardPageController virtual void initializePage() override; @@ -176,7 +176,7 @@ namespace dbaui @param _bRevertValue set to <TRUE/> if the display value should be reverted before putting it into the set */ - static void fillBool( SfxItemSet& _rSet, CheckBox* _pCheckBox, sal_uInt16 _nID, bool& _bChangedSomething, bool _bRevertValue = false); + static void fillBool( SfxItemSet& _rSet, CheckBox const * _pCheckBox, sal_uInt16 _nID, bool& _bChangedSomething, bool _bRevertValue = false); /** fills the int value into the item set when the value changed. @param _rSet @@ -188,7 +188,7 @@ namespace dbaui @param _bChangedSomething <TRUE/> if something changed otherwise <FALSE/> */ - static void fillInt32(SfxItemSet& _rSet,NumericField* _pEdit,sal_uInt16 _nID, bool& _bChangedSomething); + static void fillInt32(SfxItemSet& _rSet,NumericField const * _pEdit,sal_uInt16 _nID, bool& _bChangedSomething); /** fills the String value into the item set when the value changed. @param _rSet @@ -200,7 +200,7 @@ namespace dbaui @param _bChangedSomething <TRUE/> if something changed otherwise <FALSE/> */ - static void fillString(SfxItemSet& _rSet,Edit* _pEdit,sal_uInt16 _nID, bool& _bChangedSomething); + static void fillString(SfxItemSet& _rSet,Edit const * _pEdit,sal_uInt16 _nID, bool& _bChangedSomething); protected: /** This link be used for controls where the tabpage does not need to take any special action when the control diff --git a/dbaccess/source/ui/dlg/adtabdlg.cxx b/dbaccess/source/ui/dlg/adtabdlg.cxx index 3bfdb51278bd..4850e06d60e1 100644 --- a/dbaccess/source/ui/dlg/adtabdlg.cxx +++ b/dbaccess/source/ui/dlg/adtabdlg.cxx @@ -461,7 +461,7 @@ bool OAddTableDlg::impl_isAddAllowed() return m_rContext.allowAddition(); } -OUString OAddTableDlg::getDialogTitleForContext( IAddTableDialogContext& _rContext ) +OUString OAddTableDlg::getDialogTitleForContext( IAddTableDialogContext const & _rContext ) { OUString sTitle; diff --git a/dbaccess/source/ui/dlg/dbadmin.cxx b/dbaccess/source/ui/dlg/dbadmin.cxx index cc761520ac94..4291e1560343 100644 --- a/dbaccess/source/ui/dlg/dbadmin.cxx +++ b/dbaccess/source/ui/dlg/dbadmin.cxx @@ -49,7 +49,7 @@ using namespace com::sun::star::container; // ODbAdminDialog ODbAdminDialog::ODbAdminDialog(vcl::Window* _pParent - , SfxItemSet* _pItems + , SfxItemSet const * _pItems , const Reference< XComponentContext >& _rxContext) : SfxTabDialog(_pParent, "AdminDialog", "dbaccess/ui/admindialog.ui", _pItems) diff --git a/dbaccess/source/ui/dlg/dbwiz.cxx b/dbaccess/source/ui/dlg/dbwiz.cxx index f887f8be4094..77acc2c0302f 100644 --- a/dbaccess/source/ui/dlg/dbwiz.cxx +++ b/dbaccess/source/ui/dlg/dbwiz.cxx @@ -65,7 +65,7 @@ using namespace com::sun::star::container; // ODbTypeWizDialog ODbTypeWizDialog::ODbTypeWizDialog(vcl::Window* _pParent - ,SfxItemSet* _pItems + ,SfxItemSet const * _pItems ,const Reference< XComponentContext >& _rxORB ,const css::uno::Any& _aDataSourceName ) diff --git a/dbaccess/source/ui/dlg/dbwizsetup.cxx b/dbaccess/source/ui/dlg/dbwizsetup.cxx index 233d98effaa6..eddcc86800de 100644 --- a/dbaccess/source/ui/dlg/dbwizsetup.cxx +++ b/dbaccess/source/ui/dlg/dbwizsetup.cxx @@ -104,7 +104,7 @@ using namespace ::cppu; // ODbTypeWizDialogSetup ODbTypeWizDialogSetup::ODbTypeWizDialogSetup(vcl::Window* _pParent - ,SfxItemSet* _pItems + ,SfxItemSet const * _pItems ,const Reference< XComponentContext >& _rxORB ,const css::uno::Any& _aDataSourceName ) diff --git a/dbaccess/source/ui/dlg/indexdialog.cxx b/dbaccess/source/ui/dlg/indexdialog.cxx index 2f3a95e82ae8..b9ec5a710e02 100644 --- a/dbaccess/source/ui/dlg/indexdialog.cxx +++ b/dbaccess/source/ui/dlg/indexdialog.cxx @@ -324,7 +324,7 @@ namespace dbaui ModalDialog::dispose(); } - bool DbaIndexDialog::implCommit(SvTreeListEntry* _pEntry) + bool DbaIndexDialog::implCommit(SvTreeListEntry const * _pEntry) { OSL_ENSURE(_pEntry, "DbaIndexDialog::implCommit: invalid entry!"); @@ -428,7 +428,7 @@ namespace dbaui } } - bool DbaIndexDialog::implDropIndex(SvTreeListEntry* _pEntry, bool _bRemoveFromCollection) + bool DbaIndexDialog::implDropIndex(SvTreeListEntry const * _pEntry, bool _bRemoveFromCollection) { // do the drop Indexes::iterator aDropPos = m_pIndexes->begin() + reinterpret_cast<sal_IntPtr>(_pEntry->GetUserData()); diff --git a/dbaccess/source/ui/inc/FieldControls.hxx b/dbaccess/source/ui/inc/FieldControls.hxx index 6691a05c897a..225f6ef3bd99 100644 --- a/dbaccess/source/ui/inc/FieldControls.hxx +++ b/dbaccess/source/ui/inc/FieldControls.hxx @@ -34,7 +34,7 @@ namespace dbaui short m_nPos; OUString m_strHelpText; public: - OPropColumnEditCtrl(vcl::Window* pParent, OUString& _rAllowedChars, const char* pHelpId, short nPosition = -1, WinBits nWinStyle = 0); + OPropColumnEditCtrl(vcl::Window* pParent, OUString const & _rAllowedChars, const char* pHelpId, short nPosition = -1, WinBits nWinStyle = 0); virtual bool IsModified() const override { return IsValueChangedFromSaved(); } diff --git a/dbaccess/source/ui/inc/FieldDescControl.hxx b/dbaccess/source/ui/inc/FieldDescControl.hxx index 7abbda015b36..d5e74566156e 100644 --- a/dbaccess/source/ui/inc/FieldDescControl.hxx +++ b/dbaccess/source/ui/inc/FieldDescControl.hxx @@ -123,10 +123,10 @@ namespace dbaui DECL_LINK( OnControlFocusLost, Control&, void ); DECL_LINK( OnControlFocusGot, Control&, void ); - void UpdateFormatSample(OFieldDescription* pFieldDescr); + void UpdateFormatSample(OFieldDescription const * pFieldDescr); void ArrangeAggregates(); - void SetPosSize( VclPtr<Control>& rControl, long nRow, sal_uInt16 nCol ); + void SetPosSize( VclPtr<Control> const & rControl, long nRow, sal_uInt16 nCol ); static void ScrollAggregate(Control* pText, Control* pInput, Control* pButton, long nDeltaX, long nDeltaY); void ScrollAllAggregates(); diff --git a/dbaccess/source/ui/inc/JoinController.hxx b/dbaccess/source/ui/inc/JoinController.hxx index 4af8a9846100..b03e5f6bfa52 100644 --- a/dbaccess/source/ui/inc/JoinController.hxx +++ b/dbaccess/source/ui/inc/JoinController.hxx @@ -112,7 +112,7 @@ namespace dbaui void SaveTabWinsPosSize( OJoinTableView::OTableWindowMap* pTabWinList, long nOffsetX, long nOffsetY ); - static void SaveTabWinPosSize(OTableWindow* pTabWin, long nOffsetX, long nOffsetY); + static void SaveTabWinPosSize(OTableWindow const * pTabWin, long nOffsetX, long nOffsetY); // UNO interface overridables // XEventListener diff --git a/dbaccess/source/ui/inc/JoinDesignView.hxx b/dbaccess/source/ui/inc/JoinDesignView.hxx index c22e549e6116..b953f121902c 100644 --- a/dbaccess/source/ui/inc/JoinDesignView.hxx +++ b/dbaccess/source/ui/inc/JoinDesignView.hxx @@ -54,7 +54,7 @@ namespace dbaui virtual void initialize() override; virtual void KeyInput( const KeyEvent& rEvt ) override; - void SaveTabWinUIConfig(OTableWindow* pWin); + void SaveTabWinUIConfig(OTableWindow const * pWin); OJoinController& getController() const { return m_rController; } // called when fields are deleted diff --git a/dbaccess/source/ui/inc/QueryDesignView.hxx b/dbaccess/source/ui/inc/QueryDesignView.hxx index 493ea9296f68..b231e47f50d3 100644 --- a/dbaccess/source/ui/inc/QueryDesignView.hxx +++ b/dbaccess/source/ui/inc/QueryDesignView.hxx @@ -106,7 +106,7 @@ namespace dbaui const OUString& getDecimalSeparator() const { return m_sDecimalSep;} SqlParseError InsertField( const OTableFieldDescRef& rInfo, bool bActivate = true); - bool HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef& rInfo) const; + bool HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef const & rInfo) const; // called when a table from tabview was deleted void TableDeleted(const OUString& rAliasName); diff --git a/dbaccess/source/ui/inc/QueryTableView.hxx b/dbaccess/source/ui/inc/QueryTableView.hxx index 3af0da506faf..ce56e3dc15fd 100644 --- a/dbaccess/source/ui/inc/QueryTableView.hxx +++ b/dbaccess/source/ui/inc/QueryTableView.hxx @@ -57,7 +57,7 @@ namespace dbaui void AddTabWin(const OUString& strDatabase, const OUString& strTableName, const OUString& strAlias, bool bNewTable); /// search TabWin OQueryTableWindow* FindTable(const OUString& rAliasName); - bool FindTableFromField(const OUString& rFieldName, OTableFieldDescRef& rInfo, sal_uInt16& rCnt); + bool FindTableFromField(const OUString& rFieldName, OTableFieldDescRef const & rInfo, sal_uInt16& rCnt); /// base class overwritten: create and delete Connections virtual void AddConnection(const OJoinExchangeData& jxdSource, const OJoinExchangeData& jxdDest) override; @@ -73,7 +73,7 @@ namespace dbaui This results effectively in complete reset of request form, as all windows are hidden, as are all Connections to these windows and all request columns based on those tables */ - void DropConnection(VclPtr<OQueryTableConnection>& rConn); + void DropConnection(VclPtr<OQueryTableConnection> const & rConn); // show and hide TabWin (NOT create or delete) bool ShowTabWin(OQueryTableWindow* pTabWin, OQueryTabWinUndoAct* pUndoAction, bool _bAppend); diff --git a/dbaccess/source/ui/inc/TableController.hxx b/dbaccess/source/ui/inc/TableController.hxx index 613b8422ca7e..e229483c9c27 100644 --- a/dbaccess/source/ui/inc/TableController.hxx +++ b/dbaccess/source/ui/inc/TableController.hxx @@ -60,8 +60,8 @@ namespace dbaui /// @throws css::sdbc::SQLException /// @throws css::uno::RuntimeException bool checkColumns(bool _bNew); // check if we have double column names - void appendColumns(css::uno::Reference< css::sdbcx::XColumnsSupplier>& _rxColSup, bool _bNew, bool _bKeyColumns = false); - void appendPrimaryKey(css::uno::Reference< css::sdbcx::XKeysSupplier>& _rxSup, bool _bNew); + void appendColumns(css::uno::Reference< css::sdbcx::XColumnsSupplier> const & _rxColSup, bool _bNew, bool _bKeyColumns = false); + void appendPrimaryKey(css::uno::Reference< css::sdbcx::XKeysSupplier> const & _rxSup, bool _bNew); void alterColumns(); void dropPrimaryKey(); css::uno::Reference< css::container::XNameAccess> getKeyColumns() const; diff --git a/dbaccess/source/ui/inc/TableCopyHelper.hxx b/dbaccess/source/ui/inc/TableCopyHelper.hxx index 376dd600e785..281fd2feea25 100644 --- a/dbaccess/source/ui/inc/TableCopyHelper.hxx +++ b/dbaccess/source/ui/inc/TableCopyHelper.hxx @@ -122,7 +122,7 @@ namespace dbaui @param _xConnection The connection */ - bool copyTagTable( DropDescriptor& _rDesc, + bool copyTagTable( DropDescriptor const & _rDesc, bool _bCheck, const SharedConnection& _xConnection); diff --git a/dbaccess/source/ui/inc/TokenWriter.hxx b/dbaccess/source/ui/inc/TokenWriter.hxx index 1ef136e58abf..3d8540ba9214 100644 --- a/dbaccess/source/ui/inc/TokenWriter.hxx +++ b/dbaccess/source/ui/inc/TokenWriter.hxx @@ -118,7 +118,7 @@ namespace dbaui class ORTFImportExport : public ODatabaseImportExport { - void appendRow(OString* pHorzChar,sal_Int32 _nColumnCount,sal_Int32& k,sal_Int32& kk); + void appendRow(OString const * pHorzChar,sal_Int32 _nColumnCount,sal_Int32& k,sal_Int32& kk); public: // export data ORTFImportExport( const svx::ODataAccessDescriptor& _aDataDescriptor, diff --git a/dbaccess/source/ui/inc/UITools.hxx b/dbaccess/source/ui/inc/UITools.hxx index 4dae7caf265f..bf730100eaaf 100644 --- a/dbaccess/source/ui/inc/UITools.hxx +++ b/dbaccess/source/ui/inc/UITools.hxx @@ -88,7 +88,7 @@ namespace dbaui const OUString& _rsDataSourceName, const css::uno::Reference< css::container::XNameAccess >& _xDatabaseContext, const css::uno::Reference< css::uno::XComponentContext >& _rxContext, - css::uno::Reference< css::lang::XEventListener>& _rEvtLst, + css::uno::Reference< css::lang::XEventListener> const & _rEvtLst, css::uno::Reference< css::sdbc::XConnection>& _rOUTConnection ); /** creates a new connection and appends the eventlistener @param _xDataSource the datasource @@ -100,7 +100,7 @@ namespace dbaui ::dbtools::SQLExceptionInfo createConnection( const css::uno::Reference< css::beans::XPropertySet >& _xDataSource, const css::uno::Reference< css::uno::XComponentContext >& _rxContext, - css::uno::Reference< css::lang::XEventListener>& _rEvtLst, + css::uno::Reference< css::lang::XEventListener> const & _rEvtLst, css::uno::Reference< css::sdbc::XConnection>& _rOUTConnection ); /** creates a error dialog which displays the SQLExceptionInfo. Also it supports a "more" button where detailed information are available @@ -222,7 +222,7 @@ namespace dbaui ::comphelper::mem_fun(&TaskPaneList::AddWindow) ::comphelper::mem_fun(&TaskPaneList::RemoveWindow) */ - void notifySystemWindow(vcl::Window* _pWindow, + void notifySystemWindow(vcl::Window const * _pWindow, vcl::Window* _pToRegister, const ::comphelper::mem_fun1_t<TaskPaneList,vcl::Window*>& _rMemFunc); @@ -281,7 +281,7 @@ namespace dbaui /** set the evaluation flag at the number formatter @param _rxFormatter */ - void setEvalDateFormatForFormatter(css::uno::Reference< css::util::XNumberFormatter >& _rxFormatter); + void setEvalDateFormatForFormatter(css::uno::Reference< css::util::XNumberFormatter > const & _rxFormatter); /** query for a type info which can be used to create a primary key column @param _rTypeInfo diff --git a/dbaccess/source/ui/inc/WColumnSelect.hxx b/dbaccess/source/ui/inc/WColumnSelect.hxx index 9f08c6ca19de..e8ba08f17206 100644 --- a/dbaccess/source/ui/inc/WColumnSelect.hxx +++ b/dbaccess/source/ui/inc/WColumnSelect.hxx @@ -46,11 +46,11 @@ namespace dbaui DECL_LINK( ListDoubleClickHdl, ListBox&, void ); static void clearListBox(ListBox& _rListBox); - static void fillColumns( ListBox* pRight, + static void fillColumns( ListBox const * pRight, std::vector< OUString> &_rRightColumns); void createNewColumn( ListBox* _pListbox, - OFieldDescription* _pSrcField, + OFieldDescription const * _pSrcField, std::vector< OUString>& _rRightColumns, const OUString& _sColumnName, const OUString& _sExtraChars, @@ -58,7 +58,7 @@ namespace dbaui const ::comphelper::UStringMixEqual& _aCase); void moveColumn( ListBox* _pRight, - ListBox* _pLeft, + ListBox const * _pLeft, std::vector< OUString>& _rRightColumns, const OUString& _sColumnName, const OUString& _sExtraChars, @@ -67,7 +67,7 @@ namespace dbaui void enableButtons(); - sal_Int32 adjustColumnPosition(ListBox* _pLeft, + sal_Int32 adjustColumnPosition(ListBox const * _pLeft, const OUString& _sColumnName, ODatabaseExport::TColumnVector::size_type nCurrentPos, const ::comphelper::UStringMixEqual& _aCase); diff --git a/dbaccess/source/ui/inc/WCopyTable.hxx b/dbaccess/source/ui/inc/WCopyTable.hxx index 893499d16ed5..0d411c15cd04 100644 --- a/dbaccess/source/ui/inc/WCopyTable.hxx +++ b/dbaccess/source/ui/inc/WCopyTable.hxx @@ -288,8 +288,8 @@ namespace dbaui ODatabaseExport::TColumnVector& _rColVector ); void construct(); // need for table creation - static void appendColumns( css::uno::Reference< css::sdbcx::XColumnsSupplier>& _rxColSup, const ODatabaseExport::TColumnVector* _pVec, bool _bKeyColumns = false ); - static void appendKey(css::uno::Reference< css::sdbcx::XKeysSupplier>& _rxSup,const ODatabaseExport::TColumnVector* _pVec); + static void appendColumns( css::uno::Reference< css::sdbcx::XColumnsSupplier> const & _rxColSup, const ODatabaseExport::TColumnVector* _pVec, bool _bKeyColumns = false ); + static void appendKey(css::uno::Reference< css::sdbcx::XKeysSupplier> const & _rxSup,const ODatabaseExport::TColumnVector* _pVec); // checks if the type is supported in the destination database bool supportsType(sal_Int32 _nDataType,sal_Int32& _rNewDataType); diff --git a/dbaccess/source/ui/inc/adtabdlg.hxx b/dbaccess/source/ui/inc/adtabdlg.hxx index 3e06cf598b1f..29666214237d 100644 --- a/dbaccess/source/ui/inc/adtabdlg.hxx +++ b/dbaccess/source/ui/inc/adtabdlg.hxx @@ -86,7 +86,7 @@ namespace dbaui void Update(); static OUString getDialogTitleForContext( - IAddTableDialogContext& _rContext ); + IAddTableDialogContext const & _rContext ); private: virtual bool Close() override; diff --git a/dbaccess/source/ui/inc/dbadmin.hxx b/dbaccess/source/ui/inc/dbadmin.hxx index 215b6c760d22..bab5c0a55128 100644 --- a/dbaccess/source/ui/inc/dbadmin.hxx +++ b/dbaccess/source/ui/inc/dbadmin.hxx @@ -61,7 +61,7 @@ public: after the dialog has been destroyed */ ODbAdminDialog(vcl::Window* pParent, - SfxItemSet* _pItems, + SfxItemSet const * _pItems, const css::uno::Reference< css::uno::XComponentContext >& _rxORB ); virtual ~ODbAdminDialog() override; diff --git a/dbaccess/source/ui/inc/dbwiz.hxx b/dbaccess/source/ui/inc/dbwiz.hxx index 29280e01c897..6d43a639dcee 100644 --- a/dbaccess/source/ui/inc/dbwiz.hxx +++ b/dbaccess/source/ui/inc/dbwiz.hxx @@ -67,7 +67,7 @@ public: after the dialog has been destroyed */ ODbTypeWizDialog(vcl::Window* pParent - ,SfxItemSet* _pItems + ,SfxItemSet const * _pItems ,const css::uno::Reference< css::uno::XComponentContext >& _rxORB ,const css::uno::Any& _aDataSourceName ); diff --git a/dbaccess/source/ui/inc/dbwizsetup.hxx b/dbaccess/source/ui/inc/dbwizsetup.hxx index ec4fe02bca21..952ce5e29492 100644 --- a/dbaccess/source/ui/inc/dbwizsetup.hxx +++ b/dbaccess/source/ui/inc/dbwizsetup.hxx @@ -93,7 +93,7 @@ public: after the dialog has been destroyed */ ODbTypeWizDialogSetup(vcl::Window* pParent - ,SfxItemSet* _pItems + ,SfxItemSet const * _pItems ,const css::uno::Reference< css::uno::XComponentContext >& _rxORB ,const css::uno::Any& _aDataSourceName ); diff --git a/dbaccess/source/ui/inc/indexdialog.hxx b/dbaccess/source/ui/inc/indexdialog.hxx index bea8ed780266..2f379ea54158 100644 --- a/dbaccess/source/ui/inc/indexdialog.hxx +++ b/dbaccess/source/ui/inc/indexdialog.hxx @@ -159,11 +159,11 @@ namespace dbaui void OnSaveIndex(); void OnResetIndex(); - bool implCommit(SvTreeListEntry* _pEntry); + bool implCommit(SvTreeListEntry const * _pEntry); bool implSaveModified(bool _bPlausibility = true); bool implCommitPreviouslySelected(); - bool implDropIndex(SvTreeListEntry* _pEntry, bool _bRemoveFromCollection); + bool implDropIndex(SvTreeListEntry const * _pEntry, bool _bRemoveFromCollection); bool implCheckPlausibility(const Indexes::const_iterator& _rPos); }; diff --git a/dbaccess/source/ui/inc/unodatbr.hxx b/dbaccess/source/ui/inc/unodatbr.hxx index 2b13b34f5be9..e6953517a1f3 100644 --- a/dbaccess/source/ui/inc/unodatbr.hxx +++ b/dbaccess/source/ui/inc/unodatbr.hxx @@ -335,7 +335,7 @@ namespace dbaui implCopyObject( SvTreeListEntry* _pApplyTo, sal_Int32 _nCommandType ); EntryType getEntryType( const SvTreeListEntry* _pEntry ) const; - EntryType getChildType( SvTreeListEntry* _pEntry ) const; + EntryType getChildType( SvTreeListEntry const * _pEntry ) const; static bool isObject( EntryType _eType ) { return ( etTableOrView== _eType ) || ( etQuery == _eType ); } static bool isContainer( EntryType _eType ) { return (etTableContainer == _eType) || (etQueryContainer == _eType); } bool isContainer( const SvTreeListEntry* _pEntry ) const { return isContainer( getEntryType( _pEntry ) ); } @@ -437,7 +437,7 @@ namespace dbaui */ bool implGetQuerySignature( OUString& _rCommand, bool& _bEscapeProcessing ); - bool isEntryCopyAllowed(SvTreeListEntry* _pEntry) const; + bool isEntryCopyAllowed(SvTreeListEntry const * _pEntry) const; void copyEntry(SvTreeListEntry* _pEntry); @@ -452,7 +452,7 @@ namespace dbaui @return <TRUE/> if it is the currently displayed otherwise <FALSE/> */ - bool isCurrentlyDisplayedChanged(const OUString& _sName, SvTreeListEntry* _pContainer); + bool isCurrentlyDisplayedChanged(const OUString& _sName, SvTreeListEntry const * _pContainer); /** called whenever the content of the browser is used for preview, as the very last action of the load process diff --git a/dbaccess/source/ui/misc/TableCopyHelper.cxx b/dbaccess/source/ui/misc/TableCopyHelper.cxx index 9fc346f5440e..3cfcb0c536e7 100644 --- a/dbaccess/source/ui/misc/TableCopyHelper.cxx +++ b/dbaccess/source/ui/misc/TableCopyHelper.cxx @@ -234,7 +234,7 @@ void OTableCopyHelper::pasteTable( const TransferableDataHelper& _rTransData pasteTable( SotClipboardFormatId::RTF,_rTransData,i_rDestDataSource,_xConnection); } -bool OTableCopyHelper::copyTagTable(OTableCopyHelper::DropDescriptor& _rDesc, bool _bCheck, const SharedConnection& _xConnection) +bool OTableCopyHelper::copyTagTable(OTableCopyHelper::DropDescriptor const & _rDesc, bool _bCheck, const SharedConnection& _xConnection) { Reference<XEventListener> xEvt; ODatabaseImportExport* pImport = nullptr; diff --git a/dbaccess/source/ui/misc/TokenWriter.cxx b/dbaccess/source/ui/misc/TokenWriter.cxx index 8bbf60e1eb56..c92c7af6df52 100644 --- a/dbaccess/source/ui/misc/TokenWriter.cxx +++ b/dbaccess/source/ui/misc/TokenWriter.cxx @@ -509,7 +509,7 @@ bool ORTFImportExport::Write() return ((*m_pStream).GetError() == ERRCODE_NONE); } -void ORTFImportExport::appendRow(OString* pHorzChar,sal_Int32 _nColumnCount,sal_Int32& k,sal_Int32& kk) +void ORTFImportExport::appendRow(OString const * pHorzChar,sal_Int32 _nColumnCount,sal_Int32& k,sal_Int32& kk) { ++kk; m_pStream->WriteCharPtr( OOO_STRING_SVTOOLS_RTF_TROWD ).WriteCharPtr( OOO_STRING_SVTOOLS_RTF_TRGAPH ); diff --git a/dbaccess/source/ui/misc/UITools.cxx b/dbaccess/source/ui/misc/UITools.cxx index 1458bb93a853..5e3ffe421962 100644 --- a/dbaccess/source/ui/misc/UITools.cxx +++ b/dbaccess/source/ui/misc/UITools.cxx @@ -134,7 +134,7 @@ using ::com::sun::star::ucb::IOErrorCode_NOT_EXISTING; SQLExceptionInfo createConnection( const OUString& _rsDataSourceName, const Reference< css::container::XNameAccess >& _xDatabaseContext, const Reference< css::uno::XComponentContext >& _rxContext, - Reference< css::lang::XEventListener>& _rEvtLst, + Reference< css::lang::XEventListener> const & _rEvtLst, Reference< css::sdbc::XConnection>& _rOUTConnection ) { Reference<XPropertySet> xProp; @@ -152,7 +152,7 @@ SQLExceptionInfo createConnection( const OUString& _rsDataSourceName, SQLExceptionInfo createConnection( const Reference< css::beans::XPropertySet>& _xDataSource, const Reference< css::uno::XComponentContext >& _rxContext, - Reference< css::lang::XEventListener>& _rEvtLst, + Reference< css::lang::XEventListener> const & _rEvtLst, Reference< css::sdbc::XConnection>& _rOUTConnection ) { SQLExceptionInfo aInfo; @@ -951,7 +951,7 @@ bool appendToFilter(const Reference<XConnection>& _xConnection, return bRet; } -void notifySystemWindow(vcl::Window* _pWindow, vcl::Window* _pToRegister, const ::comphelper::mem_fun1_t<TaskPaneList,vcl::Window*>& _rMemFunc) +void notifySystemWindow(vcl::Window const * _pWindow, vcl::Window* _pToRegister, const ::comphelper::mem_fun1_t<TaskPaneList,vcl::Window*>& _rMemFunc) { OSL_ENSURE(_pWindow,"Window can not be null!"); SystemWindow* pSystemWindow = _pWindow ? _pWindow->GetSystemWindow() : nullptr; @@ -1083,7 +1083,7 @@ OUString getStrippedDatabaseName(const Reference<XPropertySet>& _xDataSource,OUS return sName; } -void setEvalDateFormatForFormatter(Reference< css::util::XNumberFormatter >& _rxFormatter) +void setEvalDateFormatForFormatter(Reference< css::util::XNumberFormatter > const & _rxFormatter) { OSL_ENSURE( _rxFormatter.is(),"setEvalDateFormatForFormatter: Formatter is NULL!"); if ( _rxFormatter.is() ) diff --git a/dbaccess/source/ui/misc/WColumnSelect.cxx b/dbaccess/source/ui/misc/WColumnSelect.cxx index ac702ece7af1..84e5d30dc434 100644 --- a/dbaccess/source/ui/misc/WColumnSelect.cxx +++ b/dbaccess/source/ui/misc/WColumnSelect.cxx @@ -284,7 +284,7 @@ void OWizColumnSelect::clearListBox(ListBox& _rListBox) _rListBox.Clear(); } -void OWizColumnSelect::fillColumns(ListBox* pRight,std::vector< OUString> &_rRightColumns) +void OWizColumnSelect::fillColumns(ListBox const * pRight,std::vector< OUString> &_rRightColumns) { const sal_Int32 nCount = pRight->GetEntryCount(); _rRightColumns.reserve(nCount); @@ -293,7 +293,7 @@ void OWizColumnSelect::fillColumns(ListBox* pRight,std::vector< OUString> &_rRig } void OWizColumnSelect::createNewColumn( ListBox* _pListbox, - OFieldDescription* _pSrcField, + OFieldDescription const * _pSrcField, std::vector< OUString>& _rRightColumns, const OUString& _sColumnName, const OUString& _sExtraChars, @@ -319,7 +319,7 @@ void OWizColumnSelect::createNewColumn( ListBox* _pListbox, } void OWizColumnSelect::moveColumn( ListBox* _pRight, - ListBox* _pLeft, + ListBox const * _pLeft, std::vector< OUString>& _rRightColumns, const OUString& _sColumnName, const OUString& _sExtraChars, @@ -364,7 +364,7 @@ void OWizColumnSelect::moveColumn( ListBox* _pRight, // not enough. We need to take into account what fields have // been removed earlier and adjust accordingly. Based on the // algorithm employed in moveColumn(). -sal_Int32 OWizColumnSelect::adjustColumnPosition( ListBox* _pLeft, +sal_Int32 OWizColumnSelect::adjustColumnPosition( ListBox const * _pLeft, const OUString& _sColumnName, ODatabaseExport::TColumnVector::size_type nCurrentPos, const ::comphelper::UStringMixEqual& _aCase) diff --git a/dbaccess/source/ui/misc/WCopyTable.cxx b/dbaccess/source/ui/misc/WCopyTable.cxx index 780a03013f43..7152811bb81f 100644 --- a/dbaccess/source/ui/misc/WCopyTable.cxx +++ b/dbaccess/source/ui/misc/WCopyTable.cxx @@ -1092,7 +1092,7 @@ void OCopyTableWizard::clearDestColumns() m_mNameMapping.clear(); } -void OCopyTableWizard::appendColumns( Reference<XColumnsSupplier>& _rxColSup, const ODatabaseExport::TColumnVector* _pVec, bool _bKeyColumns) +void OCopyTableWizard::appendColumns( Reference<XColumnsSupplier> const & _rxColSup, const ODatabaseExport::TColumnVector* _pVec, bool _bKeyColumns) { // now append the columns OSL_ENSURE(_rxColSup.is(),"No columns supplier"); @@ -1142,7 +1142,7 @@ void OCopyTableWizard::appendColumns( Reference<XColumnsSupplier>& _rxColSup, co } } -void OCopyTableWizard::appendKey( Reference<XKeysSupplier>& _rxSup, const ODatabaseExport::TColumnVector* _pVec) +void OCopyTableWizard::appendKey( Reference<XKeysSupplier> const & _rxSup, const ODatabaseExport::TColumnVector* _pVec) { if(!_rxSup.is()) return; // the database doesn't support keys diff --git a/dbaccess/source/ui/querydesign/JoinController.cxx b/dbaccess/source/ui/querydesign/JoinController.cxx index bd74faf16769..0ab7984581f6 100644 --- a/dbaccess/source/ui/querydesign/JoinController.cxx +++ b/dbaccess/source/ui/querydesign/JoinController.cxx @@ -184,7 +184,7 @@ void OJoinController::impl_onModifyChanged() InvalidateFeature( SID_RELATION_ADD_RELATION ); } -void OJoinController::SaveTabWinPosSize(OTableWindow* pTabWin, long nOffsetX, long nOffsetY) +void OJoinController::SaveTabWinPosSize(OTableWindow const * pTabWin, long nOffsetX, long nOffsetY) { // the data for the window TTableWindowData::value_type pData = pTabWin->GetData(); diff --git a/dbaccess/source/ui/querydesign/JoinDesignView.cxx b/dbaccess/source/ui/querydesign/JoinDesignView.cxx index 1661a3a6aad1..fc399c246915 100644 --- a/dbaccess/source/ui/querydesign/JoinDesignView.cxx +++ b/dbaccess/source/ui/querydesign/JoinDesignView.cxx @@ -99,7 +99,7 @@ void OJoinDesignView::setReadOnly(bool /*_bReadOnly*/) { } -void OJoinDesignView::SaveTabWinUIConfig(OTableWindow* pWin) +void OJoinDesignView::SaveTabWinUIConfig(OTableWindow const * pWin) { OJoinController::SaveTabWinPosSize(pWin, m_pScrollWindow->GetHScrollBar().GetThumbPos(), m_pScrollWindow->GetVScrollBar().GetThumbPos()); } diff --git a/dbaccess/source/ui/querydesign/QTableWindow.cxx b/dbaccess/source/ui/querydesign/QTableWindow.cxx index dd667a7cabdc..2bb7a503aaf8 100644 --- a/dbaccess/source/ui/querydesign/QTableWindow.cxx +++ b/dbaccess/source/ui/querydesign/QTableWindow.cxx @@ -138,7 +138,7 @@ void OQueryTableWindow::OnEntryDoubleClicked(SvTreeListEntry* pEntry) static_cast<OQueryTableView*>(getTableView())->InsertField(aInfo); } -bool OQueryTableWindow::ExistsField(const OUString& strFieldName, OTableFieldDescRef& rInfo) +bool OQueryTableWindow::ExistsField(const OUString& strFieldName, OTableFieldDescRef const & rInfo) { OSL_ENSURE(m_xListBox != nullptr, "OQueryTableWindow::ExistsField : doesn't have css::form::ListBox !"); OSL_ENSURE(rInfo.is(),"OQueryTableWindow::ExistsField: invalid argument for OTableFieldDescRef!"); diff --git a/dbaccess/source/ui/querydesign/QTableWindow.hxx b/dbaccess/source/ui/querydesign/QTableWindow.hxx index e9ac4e63c4d6..a7832021b16d 100644 --- a/dbaccess/source/ui/querydesign/QTableWindow.hxx +++ b/dbaccess/source/ui/querydesign/QTableWindow.hxx @@ -44,7 +44,7 @@ namespace dbaui // late Constructor, the base class CREATES Listbox on first call virtual bool Init() override; - bool ExistsField(const OUString& strFieldName, OTableFieldDescRef& rInfo); + bool ExistsField(const OUString& strFieldName, OTableFieldDescRef const & rInfo); bool ExistsAVisitedConn() const; virtual OUString GetName() const override { return GetWinName(); } diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx b/dbaccess/source/ui/querydesign/QueryDesignView.cxx index add95f7cac3a..e67123ae18aa 100644 --- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx +++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx @@ -98,7 +98,7 @@ namespace OSelectionBrowseBox* _pSelectionBrw, const ::connectivity::OSQLParseNode* pParseRoot ); - SqlParseError AddFunctionCondition(OQueryDesignView* _pView, + SqlParseError AddFunctionCondition(OQueryDesignView const * _pView, OSelectionBrowseBox* _pSelectionBrw, const ::connectivity::OSQLParseNode * pCondition, const sal_uInt16 nLevel, @@ -208,7 +208,7 @@ namespace } return aCondition; } - SqlParseError FillOuterJoins(OQueryDesignView* _pView, + SqlParseError FillOuterJoins(OQueryDesignView const * _pView, const ::connectivity::OSQLParseNode* pTableRefList) { SqlParseError eErrorCode = eOk; @@ -242,7 +242,7 @@ namespace */ SqlParseError FillDragInfo( const OQueryDesignView* _pView, const ::connectivity::OSQLParseNode* pColumnRef, - OTableFieldDescRef& _rDragInfo) + OTableFieldDescRef const & _rDragInfo) { SqlParseError eErrorCode = eOk; @@ -474,7 +474,7 @@ namespace } void GetNextJoin( const Reference< XConnection>& _xConnection, OQueryTableConnection* pEntryConn, - OQueryTableWindow* pEntryTabTo, + OQueryTableWindow const * pEntryTabTo, OUString &aJoin, tableNames_t &_rTableNames) { @@ -1234,7 +1234,7 @@ namespace sal_uInt16& nLevel, bool bHaving, bool bAddOrOnOneLine); - SqlParseError ComparisonPredicate(OQueryDesignView* _pView, + SqlParseError ComparisonPredicate(OQueryDesignView const * _pView, OSelectionBrowseBox* _pSelectionBrw, const ::connectivity::OSQLParseNode * pCondition, const sal_uInt16 nLevel, @@ -1465,7 +1465,7 @@ namespace // Pass on the error code return eErrorCode; } - SqlParseError AddFunctionCondition(OQueryDesignView* _pView, + SqlParseError AddFunctionCondition(OQueryDesignView const * _pView, OSelectionBrowseBox* _pSelectionBrw, const ::connectivity::OSQLParseNode * pCondition, const sal_uInt16 nLevel, @@ -1555,7 +1555,7 @@ namespace return eErrorCode; } - SqlParseError ComparisonPredicate(OQueryDesignView* _pView, + SqlParseError ComparisonPredicate(OQueryDesignView const * _pView, OSelectionBrowseBox* _pSelectionBrw, const ::connectivity::OSQLParseNode * pCondition, const sal_uInt16 nLevel, @@ -1717,7 +1717,7 @@ namespace namespace { - OQueryTableWindow* lcl_findColumnInTables( const OUString& _rColumName, const OJoinTableView::OTableWindowMap& _rTabList, OTableFieldDescRef& _rInfo ) + OQueryTableWindow* lcl_findColumnInTables( const OUString& _rColumName, const OJoinTableView::OTableWindowMap& _rTabList, OTableFieldDescRef const & _rInfo ) { OJoinTableView::OTableWindowMap::const_iterator aIter = _rTabList.begin(); OJoinTableView::OTableWindowMap::const_iterator aEnd = _rTabList.end(); @@ -1736,8 +1736,8 @@ namespace OUString& aColumnName, const OUString& aColumnAlias, OUString& aTableRange, - OTableFieldDescRef& _raInfo, - OJoinTableView::OTableWindowMap* pTabList) + OTableFieldDescRef const & _raInfo, + OJoinTableView::OTableWindowMap const * pTabList) { // Put the table names together @@ -1877,7 +1877,7 @@ namespace return true; } - void insertUnUsedFields(OQueryDesignView* _pView,OSelectionBrowseBox* _pSelectionBrw) + void insertUnUsedFields(OQueryDesignView const * _pView,OSelectionBrowseBox* _pSelectionBrw) { // now we have to insert the fields which aren't in the statement OQueryController& rController = static_cast<OQueryController&>(_pView->getController()); @@ -2670,7 +2670,7 @@ void OQueryDesignView::TableDeleted(const OUString& rAliasName) static_cast<OQueryController&>(getController()).InvalidateFeature(ID_BROWSER_ADDTABLE); // inform the view again } -bool OQueryDesignView::HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef& rInfo) const +bool OQueryDesignView::HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef const & rInfo) const { return m_pSelectionBox->HasFieldByAliasName( rFieldName, rInfo); } diff --git a/dbaccess/source/ui/querydesign/QueryTableView.cxx b/dbaccess/source/ui/querydesign/QueryTableView.cxx index e6fb6dfb2fcb..1422179a18bf 100644 --- a/dbaccess/source/ui/querydesign/QueryTableView.cxx +++ b/dbaccess/source/ui/querydesign/QueryTableView.cxx @@ -67,7 +67,7 @@ namespace @param _pConnection the connection for which the undo action should be appended @param _bOwner is the undo action the owner */ - void addUndoAction( OQueryTableView* _pView, + void addUndoAction( OQueryTableView const * _pView, OQueryTabConnUndoAction* _pUndoAction, OQueryTableConnection* _pConnection, bool _bOwner = false) @@ -655,7 +655,7 @@ OQueryTableWindow* OQueryTableView::FindTable(const OUString& rAliasName) return nullptr; } -bool OQueryTableView::FindTableFromField(const OUString& rFieldName, OTableFieldDescRef& rInfo, sal_uInt16& rCnt) +bool OQueryTableView::FindTableFromField(const OUString& rFieldName, OTableFieldDescRef const & rInfo, sal_uInt16& rCnt) { rCnt = 0; OTableWindowMap::const_iterator aIter = GetTabWinMap().begin(); @@ -735,7 +735,7 @@ void OQueryTableView::GetConnection(OQueryTableConnection* pConn) addConnection( pConn ); } -void OQueryTableView::DropConnection(VclPtr<OQueryTableConnection>& rConn) +void OQueryTableView::DropConnection(VclPtr<OQueryTableConnection> const & rConn) { // Pay attention to the selection // remove from me and the document diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx index c64f95cbab10..9ca82f428876 100644 --- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx +++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx @@ -561,7 +561,7 @@ void OSelectionBrowseBox::notifyFunctionFieldChanged(const OUString& _sOldFuncti RowModified(GetBrowseRow(BROW_FUNCTION_ROW), _nColumnId); } -void OSelectionBrowseBox::clearEntryFunctionField(const OUString& _sFieldName,OTableFieldDescRef& _pEntry, bool& _bListAction,sal_uInt16 _nColumnId) +void OSelectionBrowseBox::clearEntryFunctionField(const OUString& _sFieldName,OTableFieldDescRef const & _pEntry, bool& _bListAction,sal_uInt16 _nColumnId) { if ( isFieldNameAsterisk( _sFieldName ) && (!_pEntry->isNoneFunction() || _pEntry->IsGroupBy()) ) { @@ -579,7 +579,7 @@ void OSelectionBrowseBox::clearEntryFunctionField(const OUString& _sFieldName,OT } } -bool OSelectionBrowseBox::fillColumnRef(const OSQLParseNode* _pColumnRef, const Reference< XConnection >& _rxConnection, OTableFieldDescRef& _pEntry, bool& _bListAction ) +bool OSelectionBrowseBox::fillColumnRef(const OSQLParseNode* _pColumnRef, const Reference< XConnection >& _rxConnection, OTableFieldDescRef const & _pEntry, bool& _bListAction ) { OSL_ENSURE(_pColumnRef,"No valid parsenode!"); OUString sColumnName,sTableRange; @@ -587,7 +587,7 @@ bool OSelectionBrowseBox::fillColumnRef(const OSQLParseNode* _pColumnRef, const return fillColumnRef(sColumnName,sTableRange,_rxConnection->getMetaData(),_pEntry,_bListAction); } -bool OSelectionBrowseBox::fillColumnRef(const OUString& _sColumnName, const OUString& _sTableRange, const Reference<XDatabaseMetaData>& _xMetaData, OTableFieldDescRef& _pEntry, bool& _bListAction) +bool OSelectionBrowseBox::fillColumnRef(const OUString& _sColumnName, const OUString& _sTableRange, const Reference<XDatabaseMetaData>& _xMetaData, OTableFieldDescRef const & _pEntry, bool& _bListAction) { bool bError = false; ::comphelper::UStringMixEqual bCase(_xMetaData->supportsMixedCaseQuotedIdentifiers()); @@ -628,7 +628,7 @@ bool OSelectionBrowseBox::fillColumnRef(const OUString& _sColumnName, const OUSt return bError; } -bool OSelectionBrowseBox::saveField(OUString& _sFieldName ,OTableFieldDescRef& _pEntry, bool& _bListAction) +bool OSelectionBrowseBox::saveField(OUString& _sFieldName ,OTableFieldDescRef const & _pEntry, bool& _bListAction) { bool bError = false; @@ -2583,7 +2583,7 @@ OUString OSelectionBrowseBox::GetAccessibleObjectName( ::svt::AccessibleBrowseBo return sRetText; } -bool OSelectionBrowseBox::fillEntryTable(OTableFieldDescRef& _pEntry,const OUString& _sTableName) +bool OSelectionBrowseBox::fillEntryTable(OTableFieldDescRef const & _pEntry,const OUString& _sTableName) { bool bRet = false; OJoinTableView::OTableWindowMap& rTabWinList = getDesignView()->getTableView()->GetTabWinMap(); @@ -2601,7 +2601,7 @@ bool OSelectionBrowseBox::fillEntryTable(OTableFieldDescRef& _pEntry,const OUStr return bRet; } -void OSelectionBrowseBox::setFunctionCell(OTableFieldDescRef& _pEntry) +void OSelectionBrowseBox::setFunctionCell(OTableFieldDescRef const & _pEntry) { Reference< XConnection> xConnection = static_cast<OQueryController&>(getDesignView()->getController()).getConnection(); if ( xConnection.is() ) @@ -2665,7 +2665,7 @@ Reference< XAccessible > OSelectionBrowseBox::CreateAccessibleCell( sal_Int32 _n return EditBrowseBox::CreateAccessibleCell( _nRow, _nColumnPos ); } -bool OSelectionBrowseBox::HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef& rInfo) const +bool OSelectionBrowseBox::HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef const & rInfo) const { OTableFields& aFields = getFields(); OTableFields::const_iterator aIter = aFields.begin(); diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx b/dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx index f4cad626d5f7..911e28f3a9ee 100644 --- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx +++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx @@ -88,7 +88,7 @@ namespace dbaui void RemoveColumn( sal_uInt16 _nColumnId ); void DeleteFields( const OUString& rAliasName ); - bool HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef& rInfo) const; + bool HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef const & rInfo) const; // AddGroupBy:: inserts a field with function == grouping. If the fields already exists and uses an aggregate function, // the flag is not set @@ -243,7 +243,7 @@ namespace dbaui @return <TRUE/> if an error occurred otherwise <FALSE/> */ - bool saveField(OUString& _sFieldName, OTableFieldDescRef& _pEntry, bool& _bListAction); + bool saveField(OUString& _sFieldName, OTableFieldDescRef const & _pEntry, bool& _bListAction); /** sets the table window at the _pEntry @param _pEntry @@ -253,7 +253,7 @@ namespace dbaui @return <TRUE/> if the table name was set otherwise <FALSE/> */ - bool fillEntryTable(OTableFieldDescRef& _pEntry,const OUString& _sTableName); + bool fillEntryTable(OTableFieldDescRef const & _pEntry,const OUString& _sTableName); /** uses the parse node to fill all information into the field @param _pColumnRef @@ -269,12 +269,12 @@ namespace dbaui */ bool fillColumnRef( const ::connectivity::OSQLParseNode* _pColumnRef, const css::uno::Reference< css::sdbc::XConnection >& _rxConnection, - OTableFieldDescRef& _pEntry, + OTableFieldDescRef const & _pEntry, bool& _bListAction); bool fillColumnRef( const OUString& _sColumnName, const OUString& _sTableRange, const css::uno::Reference< css::sdbc::XDatabaseMetaData >& _xMetaData, - OTableFieldDescRef& _pEntry, + OTableFieldDescRef const & _pEntry, bool& _bListAction); /** append an undo action for the table field @@ -306,13 +306,13 @@ namespace dbaui @param _bListAction When <TRUE/> an list action will be created. */ - void clearEntryFunctionField(const OUString& _sFieldName,OTableFieldDescRef& _pEntry, bool& _bListAction,sal_uInt16 _nColumnId); + void clearEntryFunctionField(const OUString& _sFieldName,OTableFieldDescRef const & _pEntry, bool& _bListAction,sal_uInt16 _nColumnId); /** remove or insert the necessary function types @param _pEntry The currently edited entry. */ - void setFunctionCell(OTableFieldDescRef& _pEntry); + void setFunctionCell(OTableFieldDescRef const & _pEntry); private: using ::svt::EditBrowseBox::AcceptDrop; diff --git a/dbaccess/source/ui/querydesign/querycontroller.cxx b/dbaccess/source/ui/querydesign/querycontroller.cxx index 4472d9375441..03d997895519 100644 --- a/dbaccess/source/ui/querydesign/querycontroller.cxx +++ b/dbaccess/source/ui/querydesign/querycontroller.cxx @@ -142,7 +142,7 @@ namespace dbaui #if OSL_DEBUG_LEVEL > 0 namespace { - void insertParseTree(SvTreeListBox* _pBox,::connectivity::OSQLParseNode* _pNode,SvTreeListEntry* _pParent = nullptr) + void insertParseTree(SvTreeListBox* _pBox, ::connectivity::OSQLParseNode const * _pNode,SvTreeListEntry* _pParent = nullptr) { OUString rString; if (!_pNode->isToken()) diff --git a/dbaccess/source/ui/tabledesign/TableController.cxx b/dbaccess/source/ui/tabledesign/TableController.cxx index 41982efe4631..618a342568fa 100644 --- a/dbaccess/source/ui/tabledesign/TableController.cxx +++ b/dbaccess/source/ui/tabledesign/TableController.cxx @@ -660,7 +660,7 @@ TOTypeInfoSP OTableController::getTypeInfoByType(sal_Int32 _nDataType) const return queryTypeInfoByType(_nDataType,m_aTypeInfo); } -void OTableController::appendColumns(Reference<XColumnsSupplier>& _rxColSup, bool _bNew, bool _bKeyColumns) +void OTableController::appendColumns(Reference<XColumnsSupplier> const & _rxColSup, bool _bNew, bool _bKeyColumns) { try { @@ -721,7 +721,7 @@ void OTableController::appendColumns(Reference<XColumnsSupplier>& _rxColSup, boo } } -void OTableController::appendPrimaryKey(Reference<XKeysSupplier>& _rxSup, bool _bNew) +void OTableController::appendPrimaryKey(Reference<XKeysSupplier> const & _rxSup, bool _bNew) { if(!_rxSup.is()) return; // the database doesn't support keys |