summaryrefslogtreecommitdiff
path: root/dbaccess
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-07-24 09:05:18 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-07-24 11:02:19 +0200
commit3e4b0bde6252b80ccc99c8b9ae261d79456ba026 (patch)
tree2013dd4708bea9d1ae542704ef8bb85704e12573 /dbaccess
parent351202fd9bff1a9cf5b82d6aef5df14a4222a5e9 (diff)
loplugin:unusedfields some untouched fields
which lead to a whole bunch of dead code in vcl/.../i18n_status.cxx Change-Id: Id8eeadeb9cbc6107e1a0dac5801ce20b2b9ae6dc Reviewed-on: https://gerrit.libreoffice.org/40355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
-rw-r--r--dbaccess/source/core/api/RowSetBase.cxx1
-rw-r--r--dbaccess/source/core/dataaccess/ContentHelper.cxx1
-rw-r--r--dbaccess/source/core/dataaccess/documentcontainer.cxx7
-rw-r--r--dbaccess/source/sdbtools/connection/objectnames.cxx6
-rw-r--r--dbaccess/source/ui/app/AppControllerGen.cxx2
-rw-r--r--dbaccess/source/ui/browser/brwctrlr.cxx2
6 files changed, 6 insertions, 13 deletions
diff --git a/dbaccess/source/core/api/RowSetBase.cxx b/dbaccess/source/core/api/RowSetBase.cxx
index a0a680e9113b..6a4dfbfe4587 100644
--- a/dbaccess/source/core/api/RowSetBase.cxx
+++ b/dbaccess/source/core/api/RowSetBase.cxx
@@ -84,7 +84,6 @@ ORowSetBase::ORowSetBase( const Reference<XComponentContext>& _rContext, ::cppu:
,m_rBHelper(_rBHelper)
,m_pEmptyCollection( nullptr )
,m_aContext( _rContext )
- ,m_aErrors( _rContext )
,m_nLastColumnIndex(-1)
,m_nDeletedPosition(-1)
,m_nResultSetType( ResultSetType::FORWARD_ONLY )
diff --git a/dbaccess/source/core/dataaccess/ContentHelper.cxx b/dbaccess/source/core/dataaccess/ContentHelper.cxx
index e365e94d6367..01d7d7b811d2 100644
--- a/dbaccess/source/core/dataaccess/ContentHelper.cxx
+++ b/dbaccess/source/core/dataaccess/ContentHelper.cxx
@@ -67,7 +67,6 @@ OContentHelper::OContentHelper(const Reference< XComponentContext >& _xORB
,m_aPropertyChangeListeners(m_aMutex)
,m_xParentContainer( _xParentContainer )
,m_aContext( _xORB )
- ,m_aErrorHelper( m_aContext )
,m_pImpl(_pImpl)
,m_nCommandId(0)
{
diff --git a/dbaccess/source/core/dataaccess/documentcontainer.cxx b/dbaccess/source/core/dataaccess/documentcontainer.cxx
index 9674fe45ba61..2d1f03d8cd87 100644
--- a/dbaccess/source/core/dataaccess/documentcontainer.cxx
+++ b/dbaccess/source/core/dataaccess/documentcontainer.cxx
@@ -64,11 +64,6 @@ class LocalNameApproval : public IContainerApprove
::connectivity::SQLError m_aErrors;
public:
- explicit LocalNameApproval( const Reference< XComponentContext >& _rxContext )
- :m_aErrors( _rxContext )
- {
- }
-
void SAL_CALL approveElement( const OUString& _rName, const Reference< XInterface >& _rxElement ) override;
};
@@ -96,7 +91,7 @@ ODocumentContainer::ODocumentContainer(const Reference< XComponentContext >& _xO
registerProperty(PROPERTY_NAME, PROPERTY_ID_NAME, PropertyAttribute::BOUND | PropertyAttribute::READONLY | PropertyAttribute::CONSTRAINED,
&m_pImpl->m_aProps.aTitle, cppu::UnoType<decltype(m_pImpl->m_aProps.aTitle)>::get());
- setElementApproval( PContainerApprove( new LocalNameApproval ( _xORB ) ) );
+ setElementApproval( PContainerApprove( new LocalNameApproval ) );
}
ODocumentContainer::~ODocumentContainer()
diff --git a/dbaccess/source/sdbtools/connection/objectnames.cxx b/dbaccess/source/sdbtools/connection/objectnames.cxx
index 9bc0e42b5c90..42f58e9d5b5c 100644
--- a/dbaccess/source/sdbtools/connection/objectnames.cxx
+++ b/dbaccess/source/sdbtools/connection/objectnames.cxx
@@ -94,7 +94,7 @@ namespace sdbtools
if ( validateName( _rName ) )
return;
- ::connectivity::SQLError aErrors( m_aContext );
+ ::connectivity::SQLError aErrors;
SQLException aError( aErrors.getSQLException( ErrorCondition::DB_OBJECT_NAME_IS_USED, m_xConnection, _rName ) );
::dbtools::DatabaseMetaData aMeta( m_xConnection );
@@ -142,7 +142,7 @@ namespace sdbtools
if ( validateName( _rName ) )
return;
- ::connectivity::SQLError aErrors( m_aContext );
+ ::connectivity::SQLError aErrors;
aErrors.raiseException( ErrorCondition::DB_INVALID_SQL_NAME, m_xConnection, _rName );
}
};
@@ -187,7 +187,7 @@ namespace sdbtools
::connectivity::ErrorCondition nErrorCondition = validateName_getErrorCondition( _rName );
if ( nErrorCondition != 0 )
{
- ::connectivity::SQLError aErrors( m_aContext );
+ ::connectivity::SQLError aErrors;
aErrors.raiseException( nErrorCondition, m_xConnection );
}
}
diff --git a/dbaccess/source/ui/app/AppControllerGen.cxx b/dbaccess/source/ui/app/AppControllerGen.cxx
index 28e0860c3b51..3fda1ec29e3b 100644
--- a/dbaccess/source/ui/app/AppControllerGen.cxx
+++ b/dbaccess/source/ui/app/AppControllerGen.cxx
@@ -384,7 +384,7 @@ void OApplicationController::impl_validateObjectTypeAndName_throw( const sal_Int
// ensure we're connected
if ( !isConnected() )
{
- SQLError aError( getORB() );
+ SQLError aError;
aError.raiseException( ErrorCondition::DB_NOT_CONNECTED, *this );
}
diff --git a/dbaccess/source/ui/browser/brwctrlr.cxx b/dbaccess/source/ui/browser/brwctrlr.cxx
index e7e9a1f0a6e4..af094e97620d 100644
--- a/dbaccess/source/ui/browser/brwctrlr.cxx
+++ b/dbaccess/source/ui/browser/brwctrlr.cxx
@@ -616,7 +616,7 @@ void SbaXDataBrowserController::onStartLoading( const Reference< XLoadable >& _r
void SbaXDataBrowserController::impl_checkForCannotSelectUnfiltered( const SQLExceptionInfo& _rError )
{
- ::connectivity::SQLError aError( getORB() );
+ ::connectivity::SQLError aError;
::connectivity::ErrorCode nErrorCode( connectivity::SQLError::getErrorCode( sdb::ErrorCondition::DATA_CANNOT_SELECT_UNFILTERED ) );
if ( static_cast<const SQLException*>(_rError)->ErrorCode == nErrorCode )
{