diff options
author | Noel Grandin <noel@peralex.com> | 2016-05-16 10:11:04 +0200 |
---|---|---|
committer | Ashod Nakashian <ashod.nakashian@collabora.co.uk> | 2016-07-12 22:06:19 -0400 |
commit | 2d2ae27b7e7aa147351655a40ed324b67cecf828 (patch) | |
tree | eb52bec1a946d147e3e8b9f3d5db6e250d533f85 /dbaccess | |
parent | c5cdfe39d3afca716e7b11f8f8e169ce378861ea (diff) |
update unusedmethods plugin to deal with constructors
and fix the operator< implementations in some of the other
plugins too.
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae)
Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Diffstat (limited to 'dbaccess')
-rw-r--r-- | dbaccess/source/core/api/RowSetRow.hxx | 1 | ||||
-rw-r--r-- | dbaccess/source/core/api/datasettings.cxx | 15 | ||||
-rw-r--r-- | dbaccess/source/core/inc/core_resource.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/inc/datasettings.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/recovery/subcomponents.hxx | 6 | ||||
-rw-r--r-- | dbaccess/source/ext/macromigration/migrationerror.hxx | 6 | ||||
-rw-r--r-- | dbaccess/source/filter/xml/xmlExport.hxx | 3 | ||||
-rw-r--r-- | dbaccess/source/ui/dlg/TextConnectionHelper.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/ui/dlg/dbfindex.hxx | 1 | ||||
-rw-r--r-- | dbaccess/source/ui/dlg/detailpages.hxx | 7 | ||||
-rw-r--r-- | dbaccess/source/ui/inc/SqlNameEdit.hxx | 10 | ||||
-rw-r--r-- | dbaccess/source/ui/inc/TokenWriter.hxx | 6 | ||||
-rw-r--r-- | dbaccess/source/ui/inc/defaultobjectnamecheck.hxx | 6 | ||||
-rw-r--r-- | dbaccess/source/ui/inc/indexes.hxx | 3 |
14 files changed, 3 insertions, 67 deletions
diff --git a/dbaccess/source/core/api/RowSetRow.hxx b/dbaccess/source/core/api/RowSetRow.hxx index 2f23b03f91ad..b2a025cc5582 100644 --- a/dbaccess/source/core/api/RowSetRow.hxx +++ b/dbaccess/source/core/api/RowSetRow.hxx @@ -38,7 +38,6 @@ namespace dbaccess ORowSetOldRowHelper& operator=(const ORowSetOldRowHelper& _rRH) = delete; ORowSetOldRowHelper(const ORowSetOldRowHelper& _rRh) = delete; public: - ORowSetOldRowHelper(){} explicit ORowSetOldRowHelper(const ORowSetRow& _rRow) : m_aRow(_rRow) {} diff --git a/dbaccess/source/core/api/datasettings.cxx b/dbaccess/source/core/api/datasettings.cxx index 9f1cc3c33c95..2503539e9bd2 100644 --- a/dbaccess/source/core/api/datasettings.cxx +++ b/dbaccess/source/core/api/datasettings.cxx @@ -111,21 +111,6 @@ ODataSettings_Base::ODataSettings_Base() { } -ODataSettings_Base::ODataSettings_Base(const ODataSettings_Base& _rSource) - :m_sFilter( _rSource.m_sFilter ) - ,m_sHavingClause( _rSource.m_sHavingClause ) - ,m_sGroupBy( _rSource.m_sGroupBy ) - ,m_sOrder( _rSource.m_sOrder ) - ,m_bApplyFilter( _rSource.m_bApplyFilter ) - ,m_aFont( _rSource.m_aFont ) - ,m_aRowHeight( _rSource.m_aRowHeight ) - ,m_aTextColor( _rSource.m_aTextColor ) - ,m_aTextLineColor( _rSource.m_aTextLineColor ) - ,m_nFontEmphasis( _rSource.m_nFontEmphasis ) - ,m_nFontRelief( _rSource.m_nFontRelief ) -{ -} - ODataSettings_Base::~ODataSettings_Base() { } diff --git a/dbaccess/source/core/inc/core_resource.hxx b/dbaccess/source/core/inc/core_resource.hxx index 4db3848417fe..e09f96847050 100644 --- a/dbaccess/source/core/inc/core_resource.hxx +++ b/dbaccess/source/core/inc/core_resource.hxx @@ -44,7 +44,7 @@ namespace dbaccess private: // no instantiation allowed - ResourceManager() { } + ResourceManager() = delete; ~ResourceManager() { } protected: diff --git a/dbaccess/source/core/inc/datasettings.hxx b/dbaccess/source/core/inc/datasettings.hxx index 3cd28041598f..b3291c6e540c 100644 --- a/dbaccess/source/core/inc/datasettings.hxx +++ b/dbaccess/source/core/inc/datasettings.hxx @@ -53,7 +53,7 @@ public: protected: ODataSettings_Base(); - ODataSettings_Base(const ODataSettings_Base& _rSource); + ODataSettings_Base(const ODataSettings_Base& _rSource) = delete; ~ODataSettings_Base(); }; // ODataSettings - a base class which implements the property handling diff --git a/dbaccess/source/core/recovery/subcomponents.hxx b/dbaccess/source/core/recovery/subcomponents.hxx index e48d32be6392..763b23f396fa 100644 --- a/dbaccess/source/core/recovery/subcomponents.hxx +++ b/dbaccess/source/core/recovery/subcomponents.hxx @@ -54,12 +54,6 @@ namespace dbaccess ,bForEditing( false ) { } - - SubComponentDescriptor( const OUString& i_rName, const bool i_bForEditing ) - :sName( i_rName ) - ,bForEditing( i_bForEditing ) - { - } }; typedef std::unordered_map< OUString, SubComponentDescriptor, OUStringHash > MapStringToCompDesc; diff --git a/dbaccess/source/ext/macromigration/migrationerror.hxx b/dbaccess/source/ext/macromigration/migrationerror.hxx index a714388b72b3..00be94df94be 100644 --- a/dbaccess/source/ext/macromigration/migrationerror.hxx +++ b/dbaccess/source/ext/macromigration/migrationerror.hxx @@ -65,12 +65,6 @@ namespace dbmm ::std::vector< OUString > aErrorDetails; const css::uno::Any aCaughtException; - explicit MigrationError( - const MigrationErrorType _eType ) - :eType( _eType ) - { - } - MigrationError( const MigrationErrorType _eType, const css::uno::Any& _rCaughtException ) diff --git a/dbaccess/source/filter/xml/xmlExport.hxx b/dbaccess/source/filter/xml/xmlExport.hxx index 8cc1187bebea..6a90a8316b04 100644 --- a/dbaccess/source/filter/xml/xmlExport.hxx +++ b/dbaccess/source/filter/xml/xmlExport.hxx @@ -155,8 +155,7 @@ class ODBExport : public SvXMLExport rtl::Reference < XMLPropertySetMapper > GetTableStylesPropertySetMapper() const; -private: - ODBExport(); + ODBExport() = delete; protected: virtual void _ExportStyles( bool bUsed ) override; diff --git a/dbaccess/source/ui/dlg/TextConnectionHelper.hxx b/dbaccess/source/ui/dlg/TextConnectionHelper.hxx index c07f669d2d27..294ed1eeb8c9 100644 --- a/dbaccess/source/ui/dlg/TextConnectionHelper.hxx +++ b/dbaccess/source/ui/dlg/TextConnectionHelper.hxx @@ -42,8 +42,6 @@ namespace dbaui // OTextConnectionPage class OTextConnectionHelper : public TabPage { - OTextConnectionHelper(); - public: OTextConnectionHelper( vcl::Window* pParent, const short _nAvailableSections ); virtual ~OTextConnectionHelper(); diff --git a/dbaccess/source/ui/dlg/dbfindex.hxx b/dbaccess/source/ui/dlg/dbfindex.hxx index e7fcbd76d755..a82649c5d95f 100644 --- a/dbaccess/source/ui/dlg/dbfindex.hxx +++ b/dbaccess/source/ui/dlg/dbfindex.hxx @@ -60,7 +60,6 @@ private: TableIndexList aIndexList; public: - OTableInfo() { } explicit OTableInfo( const OUString& rName ) : aTableName(rName) { } void WriteInfFile( const OUString& rDSN ) const; diff --git a/dbaccess/source/ui/dlg/detailpages.hxx b/dbaccess/source/ui/dlg/detailpages.hxx index c6a6eb874956..5ce4eabf3e51 100644 --- a/dbaccess/source/ui/dlg/detailpages.hxx +++ b/dbaccess/source/ui/dlg/detailpages.hxx @@ -240,13 +240,6 @@ namespace dbaui DECL_LINK_TYPED( OnCheckBoxClick, Button*, void ); }; - // OMozillaDetailsPage Detail page for Mozilla and Thunderbird addressbook - class OMozillaDetailsPage : public OCommonBehaviourTabPage - { - public: - OMozillaDetailsPage( vcl::Window* pParent, const SfxItemSet& _rCoreAttrs ); - }; - // OTextDetailsPage class OTextDetailsPage : public OCommonBehaviourTabPage { diff --git a/dbaccess/source/ui/inc/SqlNameEdit.hxx b/dbaccess/source/ui/inc/SqlNameEdit.hxx index ee5fb14d401e..9889c9815d48 100644 --- a/dbaccess/source/ui/inc/SqlNameEdit.hxx +++ b/dbaccess/source/ui/inc/SqlNameEdit.hxx @@ -56,11 +56,6 @@ namespace dbaui ,OSQLNameChecker(_rAllowedChars) { } - OSQLNameEdit(vcl::Window* _pParent,const ResId& _rRes,const OUString& _rAllowedChars = OUString()) - : Edit(_pParent,_rRes) - ,OSQLNameChecker(_rAllowedChars) - { - } // Window overrides // virtual bool PreNotify( NotifyEvent& rNEvt ); @@ -77,11 +72,6 @@ namespace dbaui , OSQLNameChecker(_rAllowedChars) { } - OSQLNameComboBox(vcl::Window* _pParent,const ResId& _rRes,const OUString& _rAllowedChars = OUString()) - : ComboBox(_pParent,_rRes) - , OSQLNameChecker(_rAllowedChars) - { - } // Window overrides // Edit diff --git a/dbaccess/source/ui/inc/TokenWriter.hxx b/dbaccess/source/ui/inc/TokenWriter.hxx index edee89a421c8..db45468ffc88 100644 --- a/dbaccess/source/ui/inc/TokenWriter.hxx +++ b/dbaccess/source/ui/inc/TokenWriter.hxx @@ -212,12 +212,6 @@ namespace dbaui const css::uno::Reference< css::uno::XComponentContext >& _rM, const OUString& rExchange = OUString()); - // import data - ORowSetImportExport(const SharedConnection& _rxConnection, - const css::uno::Reference< css::uno::XComponentContext >& _rM) - : ODatabaseImportExport(_rxConnection,nullptr,_rM) - {} - virtual bool Write() override; virtual bool Read() override; diff --git a/dbaccess/source/ui/inc/defaultobjectnamecheck.hxx b/dbaccess/source/ui/inc/defaultobjectnamecheck.hxx index b0e2fdfd4007..fc3a4affee64 100644 --- a/dbaccess/source/ui/inc/defaultobjectnamecheck.hxx +++ b/dbaccess/source/ui/inc/defaultobjectnamecheck.hxx @@ -65,9 +65,6 @@ namespace dbaui const OUString& _rObjectName, ::dbtools::SQLExceptionInfo& _out_rErrorToDisplay ) const override; - - private: - HierarchicalNameCheck(); // never implemented }; // DynamicTableOrQueryNameCheck @@ -115,9 +112,6 @@ namespace dbaui const OUString& _rObjectName, ::dbtools::SQLExceptionInfo& _out_rErrorToDisplay ) const override; - - private: - DynamicTableOrQueryNameCheck(); // never implemented }; } // namespace dbaui diff --git a/dbaccess/source/ui/inc/indexes.hxx b/dbaccess/source/ui/inc/indexes.hxx index 91f5d40fa0c8..b7c765ffc99c 100644 --- a/dbaccess/source/ui/inc/indexes.hxx +++ b/dbaccess/source/ui/inc/indexes.hxx @@ -73,9 +73,6 @@ namespace dbaui bool isNew() const { return getOriginalName().isEmpty(); } void flagAsNew(const GrantIndexAccess&) { sOriginalName.clear(); } void flagAsCommitted(const GrantIndexAccess&) { sOriginalName = sName; } - - private: - OIndex(); // not implemented }; typedef std::vector<OIndex> Indexes; |