diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-30 09:20:58 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-30 10:57:04 +0100 |
| commit | a4b60b78ea36d55a2abf0e5efccd8530568d2209 (patch) | |
| tree | 9468dc489d37b11e14e190502816f3ed55edd0c9 /dbaccess | |
| parent | 034a462475c2878e1eba13f10b2fcaf8c1755c4a (diff) | |
loplugin:returnconstant
Change-Id: I5b859de6ccd908eee4356acbe1f12b441ab36df3
Reviewed-on: https://gerrit.libreoffice.org/62539
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
| -rw-r--r-- | dbaccess/source/ui/inc/DExport.hxx | 2 | ||||
| -rw-r--r-- | dbaccess/source/ui/misc/DExport.cxx | 5 |
2 files changed, 3 insertions, 4 deletions
diff --git a/dbaccess/source/ui/inc/DExport.hxx b/dbaccess/source/ui/inc/DExport.hxx index 0224943fbd53..580a46577d79 100644 --- a/dbaccess/source/ui/inc/DExport.hxx +++ b/dbaccess/source/ui/inc/DExport.hxx @@ -114,7 +114,7 @@ namespace dbaui void adjustFormat(); void eraseTokens(); void insertValueIntoColumn(); - bool createRowSet(); + void createRowSet(); void showErrorDialog(const css::sdbc::SQLException& e); void ensureFormatter(); diff --git a/dbaccess/source/ui/misc/DExport.cxx b/dbaccess/source/ui/misc/DExport.cxx index e2f87ec2d979..f070b730f9ab 100644 --- a/dbaccess/source/ui/misc/DExport.cxx +++ b/dbaccess/source/ui/misc/DExport.cxx @@ -670,10 +670,9 @@ void ODatabaseExport::CreateDefaultColumn(const OUString& _rColumnName) m_vDestVector.emplace_back(m_aDestColumns.emplace(aAlias,pField).first); } -bool ODatabaseExport::createRowSet() +void ODatabaseExport::createRowSet() { m_pUpdateHelper.reset(new OParameterUpdateHelper(createPreparedStatment(m_xConnection->getMetaData(),m_xTable,m_vColumnPositions))); - return true; } bool ODatabaseExport::executeWizard(const OUString& _rTableName, const Any& _aTextColor, const FontDescriptor& _rFont) @@ -725,7 +724,7 @@ bool ODatabaseExport::executeWizard(const OUString& _rTableName, const Any& _aTe bError = true; if(!bError) - bError = !createRowSet(); + createRowSet(); } catch( const SQLException&) { |