new compilerplugin returnbyref

Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7

1 files changed, 3 insertions, 3 deletions

diff --git a/dbaccess/source/ui/relationdesign/RTableConnection.cxx b/dbaccess/source/ui/relationdesign/RTableConnection.cxx
index c05f561c2515..03a9b56c8826 100644
--- a/dbaccess/source/ui/relationdesign/RTableConnection.cxx
+++ b/dbaccess/source/ui/relationdesign/RTableConnection.cxx
@@ -65,9 +65,9 @@ void ORelationTableConnection::Draw( const Rectangle& rRect )
     long nTemp;
 
     const OConnectionLine* pTopLine = NULL;
-    const ::std::vector<OConnectionLine*>* pConnLineList = GetConnLineList();
-    ::std::vector<OConnectionLine*>::const_iterator aIter = pConnLineList->begin();
-    ::std::vector<OConnectionLine*>::const_iterator aEnd = pConnLineList->end();
+    const ::std::vector<OConnectionLine*>& rConnLineList = GetConnLineList();
+    ::std::vector<OConnectionLine*>::const_iterator aIter = rConnLineList.begin();
+    ::std::vector<OConnectionLine*>::const_iterator aEnd = rConnLineList.end();
     for(;aIter != aEnd;++aIter)
     {
         if( (*aIter)->IsValid() )