loplugin:flatten in dbaccess

Change-Id: Ifcfd3637fbce6dc3a07a1859f102a6ac85149190
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92237
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 14 insertions, 14 deletions

diff --git a/dbaccess/source/ui/querydesign/TableFieldDescription.cxx b/dbaccess/source/ui/querydesign/TableFieldDescription.cxx
index ca4c89ac81df..95476cafd51e 100644
--- a/dbaccess/source/ui/querydesign/TableFieldDescription.cxx
+++ b/dbaccess/source/ui/querydesign/TableFieldDescription.cxx
@@ -175,22 +175,22 @@ void OTableFieldDesc::Save( ::comphelper::NamedValueCollection& o_rSettings, con
     o_rSettings.put( "GroupBy", m_bGroupBy );
     o_rSettings.put( "Visible", m_bVisible );
 
-    if ( i_bIncludingCriteria )
+    if ( !i_bIncludingCriteria )
+        return;
+
+    if ( m_aCriteria.empty() )
+        return;
+
+    sal_Int32 c = 0;
+    Sequence< PropertyValue > aCriteria( m_aCriteria.size() );
+    for (auto const& criteria : m_aCriteria)
     {
-        if ( !m_aCriteria.empty() )
-        {
-            sal_Int32 c = 0;
-            Sequence< PropertyValue > aCriteria( m_aCriteria.size() );
-            for (auto const& criteria : m_aCriteria)
-            {
-                aCriteria[c].Name = "Criterion_" + OUString::number( c );
-                aCriteria[c].Value <<= criteria;
-                ++c;
-            }
-
-            o_rSettings.put( "Criteria", aCriteria );
-        }
+        aCriteria[c].Name = "Criterion_" + OUString::number( c );
+        aCriteria[c].Value <<= criteria;
+        ++c;
     }
+
+    o_rSettings.put( "Criteria", aCriteria );
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */