diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-04 20:58:00 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-05 07:21:22 +0100 |
| commit | 9bd60e28d8257f2cac1f4e0da89c75336910b197 (patch) | |
| tree | 5ac4a4cc07e48f2282aa7ba20608e991d258dfad /cui | |
| parent | b5d7f596f26e3e086a6584fe69a8bbcc9c51d0bd (diff) | |
tdf#120703 PVS: V547 Expression is always true/false
Change-Id: I8217b1a0b6ccc29052257d54ba7844c0970ad9a4
Reviewed-on: https://gerrit.libreoffice.org/62859
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'cui')
| -rw-r--r-- | cui/source/options/optgdlg.cxx | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx index c6b01cd9754d..bc2510fb8e7a 100644 --- a/cui/source/options/optgdlg.cxx +++ b/cui/source/options/optgdlg.cxx @@ -1785,16 +1785,13 @@ IMPL_LINK( OfaLanguagesTabPage, LocaleSettingHdl, ListBox&, rListBox, void ) SupportHdl( m_pAsianSupportCB ); } - const NfCurrencyEntry* pCurr = &SvNumberFormatter::GetCurrencyEntry( + const NfCurrencyEntry& rCurr = SvNumberFormatter::GetCurrencyEntry( (eLang == LANGUAGE_USER_SYSTEM_CONFIG) ? MsLangId::getSystemLanguage() : eLang); sal_Int32 nPos = m_pCurrencyLB->GetEntryPos( nullptr ); - if (pCurr) - { - // Update the "Default ..." currency. - m_pCurrencyLB->RemoveEntry( nPos ); - OUString aDefaultCurr = m_sSystemDefaultString + " - " + pCurr->GetBankSymbol(); - nPos = m_pCurrencyLB->InsertEntry( aDefaultCurr ); - } + // Update the "Default ..." currency. + m_pCurrencyLB->RemoveEntry(nPos); + OUString aDefaultCurr = m_sSystemDefaultString + " - " + rCurr.GetBankSymbol(); + nPos = m_pCurrencyLB->InsertEntry(aDefaultCurr); m_pCurrencyLB->SelectEntryPos( nPos ); // obtain corresponding locale data |