update unusedmethods plugin to deal with constructors

and fix the operator< implementations in some of the other
plugins too.

Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae)

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035

5 files changed, 3 insertions, 21 deletions

diff --git a/cui/source/dialogs/SpellAttrib.hxx b/cui/source/dialogs/SpellAttrib.hxx
index 4069af899875..8578914890d0 100644
--- a/cui/source/dialogs/SpellAttrib.hxx
+++ b/cui/source/dialogs/SpellAttrib.hxx
@@ -44,9 +44,6 @@ struct SpellErrorDescription
     css::uno::Sequence< OUString >  aSuggestions;
     OUString                                     sRuleId;
 
-    SpellErrorDescription() :
-        bIsGrammarError( false ){}
-
     SpellErrorDescription( bool bGrammar,
                       const OUString& rText,
                       const css::lang::Locale& rLocale,
@@ -99,8 +96,7 @@ public:
 private:
     SpellErrorDescription        m_aSpellErrorDescription;
 
-                            //not accessible
-                            SpellErrorAttrib();
+                            SpellErrorAttrib() = delete;
 public:
                             SpellErrorAttrib( const SpellErrorDescription& );
                             SpellErrorAttrib( const SpellErrorAttrib& rAttr );
@@ -119,8 +115,7 @@ class SpellLanguageAttrib : public TextAttrib
 {
     LanguageType m_eLanguage;
 
-                            //not accessible
-                            SpellLanguageAttrib();
+                            SpellLanguageAttrib() = delete;
 
 public:
                             SpellLanguageAttrib(LanguageType eLanguage);
@@ -139,8 +134,7 @@ class SpellBackgroundAttrib : public TextAttrib
 {
     Color   m_aBackgroundColor;
 
-                            //not accessible
-                            SpellBackgroundAttrib();
+                            SpellBackgroundAttrib() = delete;
 
 public:
                             SpellBackgroundAttrib(const Color& rCol);
diff --git a/cui/source/inc/autocdlg.hxx b/cui/source/inc/autocdlg.hxx
index 8ea2d9a5ce74..1d3fae0f1cf5 100644
--- a/cui/source/inc/autocdlg.hxx
+++ b/cui/source/inc/autocdlg.hxx
@@ -191,13 +191,6 @@ class AutoCorrEdit : public Edit
     void dispose() override;
 
 public:
-    AutoCorrEdit(vcl::Window* pParent, const ResId& rResId)
-        : Edit(pParent, rResId)
-        , m_nCol(0)
-        , bSpaces(false)
-    {
-    }
-
     AutoCorrEdit(vcl::Window* pParent)
         : Edit(pParent)
         , m_nCol(0)
diff --git a/cui/source/inc/macropg.hxx b/cui/source/inc/macropg.hxx
index 74eb46e54a67..3fd4e10ece8e 100644
--- a/cui/source/inc/macropg.hxx
+++ b/cui/source/inc/macropg.hxx
@@ -42,7 +42,6 @@ struct EventDisplayName
 {
     const sal_Char* pAsciiEventName;
     sal_uInt16          nEventResourceID;
-    EventDisplayName() : pAsciiEventName( nullptr ), nEventResourceID(0) { }
     EventDisplayName( const sal_Char* _pAsciiName, const sal_uInt16 _nResId )
         : pAsciiEventName( _pAsciiName )
         , nEventResourceID( _nResId )
diff --git a/cui/source/inc/optdict.hxx b/cui/source/inc/optdict.hxx
index 7f4d665e0d83..8194c90cd75b 100644
--- a/cui/source/inc/optdict.hxx
+++ b/cui/source/inc/optdict.hxx
@@ -82,8 +82,6 @@ class SvxDictEdit : public Edit
     bool                     bSpaces;
 
     public:
-                    SvxDictEdit(vcl::Window* pParent, const ResId& rResId) :
-                        Edit(pParent, rResId), bSpaces(false){}
                     SvxDictEdit(vcl::Window* pParent, WinBits aWB) :
                         Edit(pParent, aWB), bSpaces(false){}
 
diff --git a/cui/source/inc/scriptdlg.hxx b/cui/source/inc/scriptdlg.hxx
index e717b97502a8..4d039f365e0a 100644
--- a/cui/source/inc/scriptdlg.hxx
+++ b/cui/source/inc/scriptdlg.hxx
@@ -117,9 +117,7 @@ private:
     bool            loaded;
         css::uno::Reference< css::script::browse::XBrowseNode > nodes;
         css::uno::Reference< css::frame::XModel > model;
-    SFEntry(){}
 public:
-                    SFEntry( sal_uInt8 nT )             { nType = nT; loaded=false; }
                     SFEntry( sal_uInt8 nT,
                             const css::uno::Reference< css::script::browse::XBrowseNode >& entryNodes ,
                             const css::uno::Reference< css::frame::XModel >& entryModel) { nType = nT; nodes = entryNodes; loaded=false; model = entryModel; }