Reverts a commit series that cripple windows ci.

Revert "SvxShadowTabPage::Construct was removed"
 f9a2c1c12ecad833c63b894c89d6008907477eb5.
Revert "replace OColorPopup with SvxColorWindow"
 f300754bb1c6a347c92bb9548be7a65237176542.
Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID"
 347c2c334589b18cc62af292674bb3df1dd54b71.
Revert "replace last ColorLB use with a listbox of colors"
 604b35bf55351751a396e34dcca3f85e75860fd5.
Revert "simplify, its just a vector of colors"
 351a97ce6bda3075677b59fa1387ba3d1ab17d7a.
Revert "replace user draw with an Image of the color"
 df738e0f8ceedb4bad756960be14d9c41adc165d.
Revert "strip down to the used pieces"
 commit 08d6cd788f2584ce10ab8fa10665245e953c59d9.
Revert "move now combined ColorLB to location of last user"
 a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e.
Revert "fold ColorListBox and ColorLB together"
 a989a0b1f2b425f05b58d0e44ce2de31c842ed65.
Revert "move ColorListBox beside sole thing that uses it"
 760a198e697f3070a5e0e029e4eff7be220eb9cd.
Revert "extensions leaks out details of Color Selector, patch it up"
 8bea644d6117a49405e6426dc97214220fc869d1.
Revert "inherit FillAttrLB from ListBox not ColorListBox"
 d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0.
Revert "unify color selectors"
 43bc3031483d172eccd72c3804e2d4fc2ef37de4.

10 files changed, 62 insertions, 61 deletions

diff --git a/cui/uiconfig/ui/borderpage.ui b/cui/uiconfig/ui/borderpage.ui
index 2a3265cde146..c783d268396a 100644
--- a/cui/uiconfig/ui/borderpage.ui
+++ b/cui/uiconfig/ui/borderpage.ui
@@ -233,7 +233,7 @@
                       </packing>
                     </child>
                     <child>
-                      <object class="svxlo-SvxColorListBox" id="linecolorlb">
+                      <object class="svtlo-ColorListBox" id="linecolorlb">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                       </object>
@@ -505,7 +505,7 @@
                   </packing>
                 </child>
                 <child>
-                  <object class="svxlo-SvxColorListBox" id="shadowcolorlb">
+                  <object class="svtlo-ColorListBox" id="shadowcolorlb">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
                     <property name="halign">start</property>
diff --git a/cui/uiconfig/ui/colorconfigwin.ui b/cui/uiconfig/ui/colorconfigwin.ui
index f4dd177a3c3d..d03daf7c34fd 100644
--- a/cui/uiconfig/ui/colorconfigwin.ui
+++ b/cui/uiconfig/ui/colorconfigwin.ui
@@ -38,7 +38,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="doccolor_lb">
+      <object class="svtlo-ColorListBox" id="doccolor_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -72,7 +72,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="docboundaries_lb">
+      <object class="svtlo-ColorListBox" id="docboundaries_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -98,7 +98,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="appback_lb">
+      <object class="svtlo-ColorListBox" id="appback_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -148,7 +148,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="objboundaries_lb">
+      <object class="svtlo-ColorListBox" id="objboundaries_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -185,7 +185,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="tblboundaries_lb">
+      <object class="svtlo-ColorListBox" id="tblboundaries_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -220,7 +220,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="font_lb">
+      <object class="svtlo-ColorListBox" id="font_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -257,7 +257,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="unvisitedlinks_lb">
+      <object class="svtlo-ColorListBox" id="unvisitedlinks_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -294,7 +294,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="visitedlinks_lb">
+      <object class="svtlo-ColorListBox" id="visitedlinks_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -354,7 +354,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="autospellcheck_lb">
+      <object class="svtlo-ColorListBox" id="autospellcheck_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -364,7 +364,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="shadows_lb">
+      <object class="svtlo-ColorListBox" id="shadows_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -374,7 +374,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="smarttags_lb">
+      <object class="svtlo-ColorListBox" id="smarttags_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -400,7 +400,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="writergrid_lb">
+      <object class="svtlo-ColorListBox" id="writergrid_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -435,7 +435,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="field_lb">
+      <object class="svtlo-ColorListBox" id="field_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -457,7 +457,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="index_lb">
+      <object class="svtlo-ColorListBox" id="index_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -479,7 +479,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="script_lb">
+      <object class="svtlo-ColorListBox" id="script_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -559,7 +559,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="section_lb">
+      <object class="svtlo-ColorListBox" id="section_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -581,7 +581,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="hdft_lb">
+      <object class="svtlo-ColorListBox" id="hdft_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -616,7 +616,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="pagebreak_lb">
+      <object class="svtlo-ColorListBox" id="pagebreak_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -651,7 +651,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="direct_lb">
+      <object class="svtlo-ColorListBox" id="direct_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -702,7 +702,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="sgml_lb">
+      <object class="svtlo-ColorListBox" id="sgml_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -737,7 +737,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="htmlcomment_lb">
+      <object class="svtlo-ColorListBox" id="htmlcomment_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -772,7 +772,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="htmlkeyword_lb">
+      <object class="svtlo-ColorListBox" id="htmlkeyword_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -807,7 +807,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="unknown_lb">
+      <object class="svtlo-ColorListBox" id="unknown_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -858,7 +858,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="calcgrid_lb">
+      <object class="svtlo-ColorListBox" id="calcgrid_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -893,7 +893,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="brk_lb">
+      <object class="svtlo-ColorListBox" id="brk_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -928,7 +928,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="brkmanual_lb">
+      <object class="svtlo-ColorListBox" id="brkmanual_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -963,7 +963,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="brkauto_lb">
+      <object class="svtlo-ColorListBox" id="brkauto_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -998,7 +998,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="det_lb">
+      <object class="svtlo-ColorListBox" id="det_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1033,7 +1033,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="deterror_lb">
+      <object class="svtlo-ColorListBox" id="deterror_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1068,7 +1068,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="ref_lb">
+      <object class="svtlo-ColorListBox" id="ref_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1103,7 +1103,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="notes_lb">
+      <object class="svtlo-ColorListBox" id="notes_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1154,7 +1154,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="drawgrid_lb">
+      <object class="svtlo-ColorListBox" id="drawgrid_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1205,7 +1205,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="basicid_lb">
+      <object class="svtlo-ColorListBox" id="basicid_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1240,7 +1240,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="basiccomment_lb">
+      <object class="svtlo-ColorListBox" id="basiccomment_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1275,7 +1275,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="basicnumber_lb">
+      <object class="svtlo-ColorListBox" id="basicnumber_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1310,7 +1310,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="basicstring_lb">
+      <object class="svtlo-ColorListBox" id="basicstring_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1345,7 +1345,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="basicop_lb">
+      <object class="svtlo-ColorListBox" id="basicop_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1380,7 +1380,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="basickeyword_lb">
+      <object class="svtlo-ColorListBox" id="basickeyword_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1415,7 +1415,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="error_lb">
+      <object class="svtlo-ColorListBox" id="error_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1466,7 +1466,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="sqlid_lb">
+      <object class="svtlo-ColorListBox" id="sqlid_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1501,7 +1501,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="sqlnumber_lb">
+      <object class="svtlo-ColorListBox" id="sqlnumber_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1536,7 +1536,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="sqlstring_lb">
+      <object class="svtlo-ColorListBox" id="sqlstring_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1571,7 +1571,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="sqlop_lb">
+      <object class="svtlo-ColorListBox" id="sqlop_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1606,7 +1606,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="sqlkeyword_lb">
+      <object class="svtlo-ColorListBox" id="sqlkeyword_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1641,7 +1641,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="sqlparam_lb">
+      <object class="svtlo-ColorListBox" id="sqlparam_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
@@ -1676,7 +1676,7 @@
       </packing>
     </child>
     <child>
-      <object class="svxlo-SvxColorListBox" id="sqlcomment_lb">
+      <object class="svtlo-ColorListBox" id="sqlcomment_lb">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
       </object>
diff --git a/cui/uiconfig/ui/effectspage.ui b/cui/uiconfig/ui/effectspage.ui
index 46a42cd15e09..1e9171cae8ad 100644
--- a/cui/uiconfig/ui/effectspage.ui
+++ b/cui/uiconfig/ui/effectspage.ui
@@ -324,7 +324,7 @@
           </packing>
         </child>
         <child>
-          <object class="svxlo-SvxColorListBox" id="fontcolorlb">
+          <object class="svtlo-ColorListBox" id="fontcolorlb">
             <property name="visible">True</property>
             <property name="can_focus">False</property>
           </object>
@@ -389,7 +389,7 @@
           </packing>
         </child>
         <child>
-          <object class="svxlo-SvxColorListBox" id="underlinecolorlb">
+          <object class="svtlo-ColorListBox" id="underlinecolorlb">
             <property name="visible">True</property>
             <property name="can_focus">False</property>
           </object>
@@ -399,7 +399,7 @@
           </packing>
         </child>
         <child>
-          <object class="svxlo-SvxColorListBox" id="overlinecolorlb">
+          <object class="svtlo-ColorListBox" id="overlinecolorlb">
             <property name="visible">True</property>
             <property name="can_focus">False</property>
           </object>
diff --git a/cui/uiconfig/ui/gradientpage.ui b/cui/uiconfig/ui/gradientpage.ui
index b36b8d7aa678..8ab982badffd 100644
--- a/cui/uiconfig/ui/gradientpage.ui
+++ b/cui/uiconfig/ui/gradientpage.ui
@@ -450,7 +450,7 @@
                       </packing>
                     </child>
                     <child>
-                      <object class="svxlo-SvxColorListBox" id="colorfromlb">
+                      <object class="svxlo-ColorLB" id="colorfromlb">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="entry_text_column">0</property>
@@ -496,7 +496,7 @@
                     <property name="row_spacing">3</property>
                     <property name="column_spacing">6</property>
                     <child>
-                      <object class="svxlo-SvxColorListBox" id="colortolb">
+                      <object class="svxlo-ColorLB" id="colortolb">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="entry_text_column">0</property>
diff --git a/cui/uiconfig/ui/hatchpage.ui b/cui/uiconfig/ui/hatchpage.ui
index f3098001b63a..fd12b3e547f7 100644
--- a/cui/uiconfig/ui/hatchpage.ui
+++ b/cui/uiconfig/ui/hatchpage.ui
@@ -266,7 +266,7 @@
                   </packing>
                 </child>
                 <child>
-                  <object class="svxlo-SvxColorListBox" id="linecolorlb">
+                  <object class="svxlo-ColorLB" id="linecolorlb">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                       </object>
@@ -292,7 +292,7 @@
                   </packing>
                 </child>
                 <child>
-                  <object class="svxlo-SvxColorListBox" id="backgroundcolorlb">
+                  <object class="svxlo-ColorLB" id="backgroundcolorlb">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                       </object>
diff --git a/cui/uiconfig/ui/linetabpage.ui b/cui/uiconfig/ui/linetabpage.ui
index a70a0ae7bed9..0060a6fef564 100644
--- a/cui/uiconfig/ui/linetabpage.ui
+++ b/cui/uiconfig/ui/linetabpage.ui
@@ -156,7 +156,7 @@
                           </packing>
                         </child>
                         <child>
-                          <object class="svxlo-SvxColorListBox" id="LB_COLOR">
+                          <object class="svxlo-ColorLB" id="LB_COLOR">
                             <property name="visible">True</property>
                             <property name="can_focus">False</property>
                           </object>
diff --git a/cui/uiconfig/ui/numberingoptionspage.ui b/cui/uiconfig/ui/numberingoptionspage.ui
index 76b609fba613..71f392aab6df 100644
--- a/cui/uiconfig/ui/numberingoptionspage.ui
+++ b/cui/uiconfig/ui/numberingoptionspage.ui
@@ -485,7 +485,7 @@
                           </packing>
                         </child>
                         <child>
-                          <object class="svxlo-SvxColorListBox" id="color">
+                          <object class="svtlo-ColorListBox" id="color">
                             <property name="visible">True</property>
                             <property name="can_focus">False</property>
                           </object>
diff --git a/cui/uiconfig/ui/optchartcolorspage.ui b/cui/uiconfig/ui/optchartcolorspage.ui
index 3d1fc1a40b83..3cadc55c6bec 100644
--- a/cui/uiconfig/ui/optchartcolorspage.ui
+++ b/cui/uiconfig/ui/optchartcolorspage.ui
@@ -26,7 +26,8 @@
             <property name="top_padding">6</property>
             <property name="left_padding">12</property>
             <child>
-              <object class="GtkTreeView" id="colors:border">
+              <object class="svxlo-ColorLB" id="colors:border">
+                <property name="dropdown">False</property>
                 <property name="visible">True</property>
                 <property name="can_focus">True</property>
                 <property name="hexpand">True</property>
diff --git a/cui/uiconfig/ui/patterntabpage.ui b/cui/uiconfig/ui/patterntabpage.ui
index 07edfc9e1f22..03bfe52c374e 100644
--- a/cui/uiconfig/ui/patterntabpage.ui
+++ b/cui/uiconfig/ui/patterntabpage.ui
@@ -185,7 +185,7 @@
                       </packing>
                     </child>
                     <child>
-                      <object class="svxlo-SvxColorListBox" id="LB_COLOR">
+                      <object class="svxlo-ColorLB" id="LB_COLOR">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="halign">start</property>
@@ -223,7 +223,7 @@
                       </packing>
                     </child>
                     <child>
-                      <object class="svxlo-SvxColorListBox" id="LB_BACKGROUND_COLOR">
+                      <object class="svxlo-ColorLB" id="LB_BACKGROUND_COLOR">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="halign">start</property>
diff --git a/cui/uiconfig/ui/shadowtabpage.ui b/cui/uiconfig/ui/shadowtabpage.ui
index 74ad9de4df4a..de63629337d3 100644
--- a/cui/uiconfig/ui/shadowtabpage.ui
+++ b/cui/uiconfig/ui/shadowtabpage.ui
@@ -99,7 +99,7 @@
                       </packing>
                     </child>
                     <child>
-                      <object class="svxlo-SvxColorListBox" id="LB_SHADOW_COLOR">
+                      <object class="svxlo-ColorLB" id="LB_SHADOW_COLOR">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="halign">start</property>