loplugin:stringviewparam extend to comparison operators

which means that some call sites have to change to use
unicode string literals i.e. u"foo" instead of "foo"

Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 8 insertions, 8 deletions

diff --git a/cui/source/dialogs/hlinettp.cxx b/cui/source/dialogs/hlinettp.cxx
index f2deeb9b3c78..140d2a59da3b 100644
--- a/cui/source/dialogs/hlinettp.cxx
+++ b/cui/source/dialogs/hlinettp.cxx
@@ -279,7 +279,7 @@ void SvxHyperlinkInternetTp::SetScheme(const OUString& rScheme)
 |*
 |************************************************************************/
 
-void SvxHyperlinkInternetTp::RemoveImproperProtocol(const OUString& aProperScheme)
+void SvxHyperlinkInternetTp::RemoveImproperProtocol(std::u16string_view aProperScheme)
 {
     OUString aStrURL ( m_xCbbTarget->get_active_text() );
     if ( !aStrURL.isEmpty() )
diff --git a/cui/source/dialogs/hlmailtp.cxx b/cui/source/dialogs/hlmailtp.cxx
index 1cae4b29d2fa..521af033b422 100644
--- a/cui/source/dialogs/hlmailtp.cxx
+++ b/cui/source/dialogs/hlmailtp.cxx
@@ -167,7 +167,7 @@ void SvxHyperlinkMailTp::SetInitFocus()
 
 /*************************************************************************
 |************************************************************************/
-void SvxHyperlinkMailTp::SetScheme(const OUString& rScheme)
+void SvxHyperlinkMailTp::SetScheme(std::u16string_view rScheme)
 {
     //update target:
     RemoveImproperProtocol(rScheme);
@@ -183,7 +183,7 @@ void SvxHyperlinkMailTp::SetScheme(const OUString& rScheme)
 |* Remove protocol if it does not fit to the current button selection
 |*
 |************************************************************************/
-void SvxHyperlinkMailTp::RemoveImproperProtocol(const OUString& aProperScheme)
+void SvxHyperlinkMailTp::RemoveImproperProtocol(std::u16string_view aProperScheme)
 {
     OUString aStrURL(m_xCbbReceiver->get_active_text());
     if ( !aStrURL.isEmpty() )
diff --git a/cui/source/dialogs/hlmarkwn.cxx b/cui/source/dialogs/hlmarkwn.cxx
index ab28675b4932..8996c0e6790c 100644
--- a/cui/source/dialogs/hlmarkwn.cxx
+++ b/cui/source/dialogs/hlmarkwn.cxx
@@ -382,7 +382,7 @@ void SvxHlinkDlgMarkWnd::ClearTree()
 }
 
 // Find Entry for String
-std::unique_ptr<weld::TreeIter> SvxHlinkDlgMarkWnd::FindEntry (const OUString& aStrName)
+std::unique_ptr<weld::TreeIter> SvxHlinkDlgMarkWnd::FindEntry (std::u16string_view aStrName)
 {
     bool bFound=false;
     std::unique_ptr<weld::TreeIter> xEntry = mxLbTree->make_iterator();
@@ -404,7 +404,7 @@ std::unique_ptr<weld::TreeIter> SvxHlinkDlgMarkWnd::FindEntry (const OUString& a
 }
 
 // Select Entry
-bool SvxHlinkDlgMarkWnd::SelectEntry(const OUString& aStrMark)
+bool SvxHlinkDlgMarkWnd::SelectEntry(std::u16string_view aStrMark)
 {
     std::unique_ptr<weld::TreeIter> xEntry = FindEntry(aStrMark);
     if (!xEntry)
diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx
index 78bb8be5d8f8..cb7d8776dcbd 100644
--- a/cui/source/dialogs/scriptdlg.cxx
+++ b/cui/source/dialogs/scriptdlg.cxx
@@ -113,7 +113,7 @@ void SvxScriptOrgDialog::deleteAllTree()
     while (bNextEntry);
 }
 
-void SvxScriptOrgDialog::Init( const OUString& language  )
+void SvxScriptOrgDialog::Init( std::u16string_view language  )
 {
     m_xScriptsBox->freeze();
 
@@ -202,7 +202,7 @@ void SvxScriptOrgDialog::Init( const OUString& language  )
 }
 
 Reference< XInterface  >
-SvxScriptOrgDialog::getDocumentModel( Reference< XComponentContext > const & xCtx, OUString const & docName )
+SvxScriptOrgDialog::getDocumentModel( Reference< XComponentContext > const & xCtx, std::u16string_view docName )
 {
     Reference< XInterface > xModel;
     Reference< frame::XDesktop2 > desktop  = frame::Desktop::create(xCtx);
@@ -229,7 +229,7 @@ SvxScriptOrgDialog::getDocumentModel( Reference< XComponentContext > const & xCt
 }
 
 Reference< browse::XBrowseNode >
-SvxScriptOrgDialog::getLangNodeFromRootNode( Reference< browse::XBrowseNode > const & rootNode, OUString const & language )
+SvxScriptOrgDialog::getLangNodeFromRootNode( Reference< browse::XBrowseNode > const & rootNode, std::u16string_view language )
 {
     Reference< browse::XBrowseNode > langNode;