diff options
| author | Andras Timar <atimar@suse.com> | 2013-02-28 13:17:39 +0100 |
|---|---|---|
| committer | Fridrich Strba <fridrich@documentfoundation.org> | 2013-03-07 08:33:08 +0000 |
| commit | f43decde34577c8340a1abdcdad9a12e8b043068 (patch) | |
| tree | a42d308ce89691cda7323c068ea0c5fcfe0ba72c /crashrep | |
| parent | 104947d1825b99503d5df59dfd85ad6e603e1407 (diff) | |
bin PATCH_SO_NAME crack
In VersionInfo of Windows executables the FileDescription property originally contained
80 times 'x' character. These executables were marked as PATCH_SO_NAME and later the
installer maker perl program replaced the xxxxxxxxxxx to the actual file description
which was defined in scp2. WHy was it good, I have no idea. The problem was that it
happened after postprocess, where we signed the binaries, thus diigital signature became
corrupted. It is better to give file descriptions via makefiles.
Conflicts:
crashrep/WinResTarget_crashrep.mk
Oh, well, crashrep is a dmake module in 4.0. But it is not built, so patch has no
effect in practice.
Change-Id: Id5ad4470bb7a6313b33fbba09d72d9a009163a89
Reviewed-on: https://gerrit.libreoffice.org/2463
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Diffstat (limited to 'crashrep')
| -rw-r--r-- | crashrep/source/win32/rcheader.txt | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/crashrep/source/win32/rcheader.txt b/crashrep/source/win32/rcheader.txt index be3c0600d685..bace84b1ff93 100644 --- a/crashrep/source/win32/rcheader.txt +++ b/crashrep/source/win32/rcheader.txt @@ -58,13 +58,14 @@ VS_VERSION_INFO versioninfo block "040904E4" { // International StringTable - value "CompanyName", "The Document Foundation\0" - value "FileDescription", "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\0" - value "FileVersion", PPS(VER_LEVEL) "\0" - value "ProductVersion", PPS(VER_LEVEL) "\0" - value "OriginalFilename", "SOREPORT.EXE\0" - value "InternalName", "CrashReport\0" - value "LegalCopyright", S_CRIGHT " LibreOffice contributors and/or their affiliates. All rights reserved.\0" + VALUE "CompanyName", PPS(RES_APP_VENDOR) "\0" + VALUE "FileDescription", PPS(RES_APP_FILEDESC) "\0" + VALUE "FileVersion", PPS(VER_LEVEL) "\0" + VALUE "ProductVersion", PPS(VER_LEVEL) "\0" + VALUE "ProductName", "LibreOffice\0" + VALUE "OriginalFilename", PPS(RES_APP_NAME) ".exe\0" + VALUE "InternalName", PPS(RES_APP_NAME) "\0" + VALUE "LegalCopyright", S_CRIGHT " LibreOffice contributors and/or their affiliates. All rights reserved.\0" } } |