new loplugin: externalandnotdefined

Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2

2 files changed, 9 insertions, 11 deletions

diff --git a/cppuhelper/source/implbase.cxx b/cppuhelper/source/implbase.cxx
index adfab032a2a5..1ffb856a9bb3 100644
--- a/cppuhelper/source/implbase.cxx
+++ b/cppuhelper/source/implbase.cxx
@@ -33,19 +33,9 @@ using namespace ::com::sun::star::uno;
 using rtl::OUString;
 using rtl::OString;
 
-namespace
-{
-    class theImplHelperInitMutex : public rtl::Static<Mutex, theImplHelperInitMutex>{};
-}
-
 namespace cppu
 {
 
-Mutex & SAL_CALL getImplHelperInitMutex(void)
-{
-    return theImplHelperInitMutex::get();
-}
-
 // ClassDataBase
 
 ClassDataBase::ClassDataBase()
diff --git a/cppuhelper/source/implbase_ex.cxx b/cppuhelper/source/implbase_ex.cxx
index 0841603c6163..1c85b1c81585 100644
--- a/cppuhelper/source/implbase_ex.cxx
+++ b/cppuhelper/source/implbase_ex.cxx
@@ -37,13 +37,21 @@ using rtl::OString;
 using rtl::OUString;
 using rtl::OUStringBuffer;
 
+namespace
+{
+    class theImplHelperInitMutex : public rtl::Static<Mutex, theImplHelperInitMutex>{};
+}
+
 namespace cppu
 {
 
 /** Shared mutex for implementation helper initialization.
     Not for public use.
 */
-::osl::Mutex & SAL_CALL getImplHelperInitMutex(void);
+::osl::Mutex & SAL_CALL getImplHelperInitMutex(void)
+{
+    return theImplHelperInitMutex::get();
+}
 
 
 static inline void checkInterface( Type const & rType )