diff options
| author | Noel Grandin <noel@peralex.com> | 2014-03-06 15:29:08 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-03-18 08:32:26 +0200 |
| commit | 86a32589e90ee983159fb5b2c6a594428ab7d422 (patch) | |
| tree | 6de946fe2b9b25614f0d197af95e9d3aadcd1bd9 /cppcanvas | |
| parent | bb17844099ba98a77c8e5d7a25c0c416a4b0641e (diff) | |
Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
Diffstat (limited to 'cppcanvas')
| -rw-r--r-- | cppcanvas/source/inc/implrenderer.hxx | 2 | ||||
| -rw-r--r-- | cppcanvas/source/mtfrenderer/implrenderer.cxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/cppcanvas/source/inc/implrenderer.hxx b/cppcanvas/source/inc/implrenderer.hxx index 4f043b9b33a9..55fe6f132c1b 100644 --- a/cppcanvas/source/inc/implrenderer.hxx +++ b/cppcanvas/source/inc/implrenderer.hxx @@ -266,7 +266,7 @@ static float GetSwapFloat( SvStream& rSt ) bool bSubsettableActions ); void createTextAction( const ::Point& rStartPoint, - const OUString rString, + const OUString& rString, int nIndex, int nLength, const sal_Int32* pCharWidths, diff --git a/cppcanvas/source/mtfrenderer/implrenderer.cxx b/cppcanvas/source/mtfrenderer/implrenderer.cxx index 52f527828acf..4b5935a1ae53 100644 --- a/cppcanvas/source/mtfrenderer/implrenderer.cxx +++ b/cppcanvas/source/mtfrenderer/implrenderer.cxx @@ -849,7 +849,7 @@ namespace cppcanvas // create text effects such as shadow/relief/embossed void ImplRenderer::createTextAction( const ::Point& rStartPoint, - const OUString rString, + const OUString& rString, int nIndex, int nLength, const sal_Int32* pCharWidths, |