diff options
| author | dennisroczek <dennisroczek@libreoffice.org> | 2017-04-01 15:26:28 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2017-04-27 22:20:40 +0200 |
| commit | 91a1342aa2930268006614680ec439c6ebecdedb (patch) | |
| tree | 922a2e7ec859c5498ce45bc167f5c496a795c7e0 /connectivity | |
| parent | bfc54ba3d2ac7f7ff40f8b3e95a6bd9b74bcd0c5 (diff) | |
tdf#39468 cleanup source code comments
* translate German source code comments
* remove ascii art
* remove bogus source Code comments
* remove old StarOffice/Sun internal bug tracker references
Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451
Reviewed-on: https://gerrit.libreoffice.org/36005
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'connectivity')
| -rw-r--r-- | connectivity/source/commontools/parameters.cxx | 5 | ||||
| -rw-r--r-- | connectivity/source/drivers/mysql/YCatalog.cxx | 1 | ||||
| -rw-r--r-- | connectivity/source/parse/sqliterator.cxx | 23 |
3 files changed, 13 insertions, 16 deletions
diff --git a/connectivity/source/commontools/parameters.cxx b/connectivity/source/commontools/parameters.cxx index 70e1883ff41f..4f0caca3b4de 100644 --- a/connectivity/source/commontools/parameters.cxx +++ b/connectivity/source/commontools/parameters.cxx @@ -265,9 +265,8 @@ namespace dbtools if ( pMasterFields->isEmpty() || pDetailFields->isEmpty() ) continue; - // if not even the master part of the relationship exists in the parent , the - // link is invalid as a whole - // #i63674# / 2006-03-28 / frank.schoenheit@sun.com + // if not even the master part of the relationship exists in the parent, the + // link is invalid as a whole #i63674# if ( !_rxParentColumns->hasByName( *pMasterFields ) ) { bNeedExchangeLinks = true; diff --git a/connectivity/source/drivers/mysql/YCatalog.cxx b/connectivity/source/drivers/mysql/YCatalog.cxx index 38f0b24e211b..eb755309fd41 100644 --- a/connectivity/source/drivers/mysql/YCatalog.cxx +++ b/connectivity/source/drivers/mysql/YCatalog.cxx @@ -74,7 +74,6 @@ void OMySQLCatalog::refreshViews() // let's simply assume the server is new enough to support views. Current drivers // as of this writing might not return the proper information in getTableTypes, so // don't rely on it. - // during #73245# / 2007-10-26 / frank.schoenheit@sun.com bool bSupportsViews = true; TStringVector aVector; diff --git a/connectivity/source/parse/sqliterator.cxx b/connectivity/source/parse/sqliterator.cxx index 341c30c26298..959e0ca4733b 100644 --- a/connectivity/source/parse/sqliterator.cxx +++ b/connectivity/source/parse/sqliterator.cxx @@ -334,8 +334,7 @@ void OSQLParseTreeIterator::impl_getQueryParameterColumns( const OSQLTable& _rQu OSQLParseTreeIterator aSubQueryIterator( *this, m_rParser, pSubQueryNode.get() ); aSubQueryIterator.impl_traverse( TraversalParts::Parameters | TraversalParts::SelectColumns ); - // SelectColumns might also contain parameters - // #i77635# - 2007-07-23 / frank.schoenheit@sun.com + // SelectColumns might also contain parameters #i77635# pSubQueryParameterColumns = aSubQueryIterator.getParameters(); aSubQueryIterator.dispose(); @@ -574,13 +573,13 @@ const OSQLParseNode* OSQLParseTreeIterator::getTableNode( OSQLTables& _rTables, if ( SQL_ISRULE( pQueryExpression, select_statement ) ) { getSelect_statement( *m_pImpl->m_pSubTables, pQueryExpression ); - // LEM TODO: now, we need to setup a OSQLTable from pQueryExpression in some way - // and stick it in _rTables[rTableRange]. Probably fake it by - // setting up a full OSQLParseTreeIterator on pQueryExpression - // and using its m_aSelectColumns - // This is necessary in stuff like "SELECT * FROM tbl1 INNER JOIN (SELECT foo, bar FROM tbl2) AS tbl3" - // so that setSelectColumnName() can expand the "*" correctly. - // See e.g. R_UserAndLastSubscription query of https://bugs.libreoffice.org/attachment.cgi?id=71871 + // TODO: now, we need to setup a OSQLTable from pQueryExpression in some way + // and stick it in _rTables[rTableRange]. Probably fake it by + // setting up a full OSQLParseTreeIterator on pQueryExpression + // and using its m_aSelectColumns + // This is necessary in stuff like "SELECT * FROM tbl1 INNER JOIN (SELECT foo, bar FROM tbl2) AS tbl3" + // so that setSelectColumnName() can expand the "*" correctly. + // See e.g. R_UserAndLastSubscription query of https://bugs.libreoffice.org/attachment.cgi?id=71871 } else { @@ -989,9 +988,9 @@ bool OSQLParseTreeIterator::traverseSelectColumnNames(const OSQLParseNode* pSele if ( pColumnRef->isRule() ) { - // LEM FIXME: the if condition is not quite right - // many expressions are rules, e.g. "5+3" - // or even: "colName + 1" + // FIXME: the if condition is not quite right + // many expressions are rules, e.g. "5+3" + // or even: "colName + 1" bFkt = true; nType = getFunctionReturnType(pColumnRef); } |