fdo#60148 Clean up warnings from the Clang compiler plugin

Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

6 files changed, 3 insertions, 14 deletions

diff --git a/connectivity/source/drivers/file/FTable.cxx b/connectivity/source/drivers/file/FTable.cxx
index d947c251a2b5..8dc2c7106544 100644
--- a/connectivity/source/drivers/file/FTable.cxx
+++ b/connectivity/source/drivers/file/FTable.cxx
@@ -51,8 +51,6 @@ OFileTable::OFileTable(sdbcx::OCollection* _pTables,OConnection* _pConnection)
     RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, "file", "Ocke.Janssen@sun.com", "OFileTable::OFileTable" );
     DBG_CTOR( file_OFileTable, NULL );
     construct();
-    TStringVector aVector;
-    //  m_pColumns  = new OColumns(this,m_aMutex,aVector);
     m_aColumns = new OSQLColumns();
 }
 // -------------------------------------------------------------------------
diff --git a/connectivity/source/drivers/mork/MResultSetMetaData.cxx b/connectivity/source/drivers/mork/MResultSetMetaData.cxx
index 57f6dea980ac..778bdae69ac6 100644
--- a/connectivity/source/drivers/mork/MResultSetMetaData.cxx
+++ b/connectivity/source/drivers/mork/MResultSetMetaData.cxx
@@ -158,10 +158,8 @@ sal_Int32 SAL_CALL OResultSetMetaData::isNullable( sal_Int32 column ) throw(SQLE
 }
 // -------------------------------------------------------------------------
 
-sal_Bool SAL_CALL OResultSetMetaData::isSearchable( sal_Int32 column ) throw(SQLException, RuntimeException)
+sal_Bool SAL_CALL OResultSetMetaData::isSearchable( sal_Int32 /*column*/ ) throw(SQLException, RuntimeException)
 {
-    ::rtl::OUString sColumnName( getColumnName( column ) );
-
     if ( !m_pTable || !m_pTable->getConnection() )
     {
         OSL_FAIL( "OResultSetMetaData::isSearchable: suspicious: called without table or connection!" );
diff --git a/connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx b/connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx
index 8f8e68df6683..b654171f27d5 100644
--- a/connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx
@@ -187,12 +187,11 @@ void IndexColumns::refresh()
 
 
 void IndexColumns::appendByDescriptor(
-    const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& future )
+    const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& /*future*/ )
     throw (::com::sun::star::sdbc::SQLException,
            ::com::sun::star::container::ElementExistException,
            ::com::sun::star::uno::RuntimeException)
 {
-    OUString name = extractStringProperty( future, getStatics().NAME );
     throw com::sun::star::sdbc::SQLException(
         "SDBC-POSTGRESQL: IndexesColumns.appendByDescriptor not yet implemented",
         *this, OUString(), 1, Any() );
diff --git a/connectivity/source/drivers/postgresql/pq_xtable.cxx b/connectivity/source/drivers/postgresql/pq_xtable.cxx
index e6210eac3850..7ba75f8131dd 100644
--- a/connectivity/source/drivers/postgresql/pq_xtable.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xtable.cxx
@@ -293,8 +293,6 @@ void Table::alterColumnByIndex(
     Reference< com::sun::star::container::XIndexAccess > colums =
         Reference< com::sun::star::container::XIndexAccess>( getColumns(), UNO_QUERY );
     Reference< com::sun::star::beans::XPropertySet> column(colums->getByIndex( index ), UNO_QUERY );
-    OUString oldName = extractStringProperty( column, getStatics().NAME );
-    OUString newName = extractStringProperty( descriptor, getStatics().NAME );
     ::pq_sdbc_driver::alterColumnByDescriptor(
         extractStringProperty( this, getStatics().SCHEMA_NAME ),
         extractStringProperty( this, getStatics().NAME ),
@@ -302,7 +300,6 @@ void Table::alterColumnByIndex(
         m_conn->createStatement(),
         column,
         descriptor );
-//     m_pColumns->rename( oldName, newName );
     m_pColumns->refresh();
 }
 
diff --git a/connectivity/source/drivers/postgresql/pq_xtables.cxx b/connectivity/source/drivers/postgresql/pq_xtables.cxx
index 705adcf4f2c2..92c0f12f2dfe 100644
--- a/connectivity/source/drivers/postgresql/pq_xtables.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xtables.cxx
@@ -321,9 +321,7 @@ void Tables::appendByDescriptor(
             while( xEnum.is() && xEnum->hasMoreElements() )
             {
                 Reference< XPropertySet > column( xEnum->nextElement(), UNO_QUERY );
-                // help text seems to be used by OOo rather than Description
-//                 OUString description = extractStringProperty( column, st.HELP_TEXT );
-                OUString helpText = extractStringProperty( column,st.DESCRIPTION );
+                description = extractStringProperty( column,st.DESCRIPTION );
                 if( description.getLength() )
                 {
                     buf = OUStringBuffer( 128 );
diff --git a/connectivity/source/drivers/postgresql/pq_xuser.cxx b/connectivity/source/drivers/postgresql/pq_xuser.cxx
index e76b29ff9dc8..b96450a7bd94 100644
--- a/connectivity/source/drivers/postgresql/pq_xuser.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xuser.cxx
@@ -184,7 +184,6 @@ sal_Int32 User::getPrivileges( const ::rtl::OUString& objName, sal_Int32 objType
     if( isLog( m_pSettings, LogLevel::INFO ) )
     {
         Statics & st = getStatics();
-        rtl::OUString user = extractStringProperty( this, st.NAME );
 
         rtl::OUStringBuffer buf( 128 );
         buf.append( "User::getPrivileges[" + extractStringProperty( this, st.NAME ) +