diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-18 14:15:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-19 11:42:47 +0200 |
| commit | 82572caae4a282cdf79456b977508ca71507c584 (patch) | |
| tree | befc8478f8cd9bf7e7c9a87a776b063a9ed4b718 /connectivity/source/drivers/evoab2 | |
| parent | 71ef762f21ada8c25aad2183065478171e985e8c (diff) | |
improve and enable loplugin:fragiledestructor
Where the problem was benign and the class was not extended, I marked
the class as final.
Where the problem was benign and the class was extended, I marked the
relevant callee methods as final.
Other cases were excluded in the plugin.
Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc
Reviewed-on: https://gerrit.libreoffice.org/79089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'connectivity/source/drivers/evoab2')
| -rw-r--r-- | connectivity/source/drivers/evoab2/NConnection.hxx | 2 | ||||
| -rw-r--r-- | connectivity/source/drivers/evoab2/NResultSet.cxx | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/connectivity/source/drivers/evoab2/NConnection.hxx b/connectivity/source/drivers/evoab2/NConnection.hxx index 2b2737927b53..2ba2a8db7ea8 100644 --- a/connectivity/source/drivers/evoab2/NConnection.hxx +++ b/connectivity/source/drivers/evoab2/NConnection.hxx @@ -47,7 +47,7 @@ namespace connectivity typedef connectivity::OMetaConnection OConnection_BASE; // implements basics and text encoding - class OEvoabConnection :public OConnection_BASE + class OEvoabConnection final :public OConnection_BASE { private: const OEvoabDriver& m_rDriver; diff --git a/connectivity/source/drivers/evoab2/NResultSet.cxx b/connectivity/source/drivers/evoab2/NResultSet.cxx index 0c438f650479..28c7278f2010 100644 --- a/connectivity/source/drivers/evoab2/NResultSet.cxx +++ b/connectivity/source/drivers/evoab2/NResultSet.cxx @@ -435,7 +435,7 @@ public: return isBookBackend(pBook, "local"); } - virtual void freeContacts() override + virtual void freeContacts() override final { e_client_util_free_object_slist(m_pContacts); m_pContacts = nullptr; @@ -560,7 +560,7 @@ public: !strncmp( "local:", e_book_get_uri( pBook ), 6 ) ); } - virtual void freeContacts() override + virtual void freeContacts() override final { g_list_free(m_pContacts); m_pContacts = nullptr; |