summaryrefslogtreecommitdiff
path: root/connectivity/source/drivers
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2019-11-13 22:34:48 +0100
committerMichael Stahl <michael.stahl@cib.de>2019-11-14 10:20:18 +0100
commit122a0be8ae480473bd1d7f35e197a2529f4621e3 (patch)
treed0b99b63cf27b895540c4148af2cb2eb1ae0272a /connectivity/source/drivers
parent52b15945ac14ae3ef8dd99a6b3067d61085e1315 (diff)
Fix useless assert(true) (which would never fire)
526387b96e9bc2c04b0dc26744bf6b88ea7c0521 "loplugin:unnecessaryvirtual" had added the assert (which was presumably meant to be an assert(false) instead, but had somewhat oddly been added as part of that commit for no apparent reason), after 68ec95b3f80408ae50897b043eed69a07d084df9 "made ListBox handle more than 64k elements, fdo#61520 related" had added the check+return. But check+assert+return doesn't make sense. Either the checked condition cannot happen (assert) or it can (return), but not both. A `make check screenshot` didn't cause the (now active) assert to fire in my local build, so lets assume that the condition cannot happen and the assert is legitimate (and thus drop the return and simplify the code accordingly). An alternative fix would be to show that the condition can happen, and to thus drop the assert. Change-Id: Id0059790d4f34c6645eadda9bca3184483e46bdf Reviewed-on: https://gerrit.libreoffice.org/82642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Diffstat (limited to 'connectivity/source/drivers')
0 files changed, 0 insertions, 0 deletions