summaryrefslogtreecommitdiff
path: root/connectivity/source/commontools
diff options
context:
space:
mode:
authorMike Kaganski <mike.kaganski@collabora.com>2019-08-22 15:42:36 +0300
committerMike Kaganski <mike.kaganski@collabora.com>2019-08-23 11:48:53 +0200
commit63dfd069b3a957361881c12ccba38c5a23b9a42f (patch)
treee7a9bd1027b19f44a7c58ea9c445ded435c838bc /connectivity/source/commontools
parent61ed17cafc90d9b4303b52260f729638eed107c7 (diff)
Mark move ctors/assignments noexcept
This should enable using move semantics where possible e.g. in standard containers. According to https://en.cppreference.com/w/cpp/language/move_constructor: To make strong exception guarantee possible, user-defined move constructors should not throw exceptions. For example, std::vector relies on std::move_if_noexcept to choose between move and copy when the elements need to be relocated. Change-Id: I6e1e1cdd5cd430b139ffa2fa7031fb0bb625decb Reviewed-on: https://gerrit.libreoffice.org/77957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'connectivity/source/commontools')
-rw-r--r--connectivity/source/commontools/FValue.cxx4
-rw-r--r--connectivity/source/commontools/dbmetadata.cxx4
2 files changed, 4 insertions, 4 deletions
diff --git a/connectivity/source/commontools/FValue.cxx b/connectivity/source/commontools/FValue.cxx
index 51adab4f3e98..bf79ffd5ac7b 100644
--- a/connectivity/source/commontools/FValue.cxx
+++ b/connectivity/source/commontools/FValue.cxx
@@ -259,7 +259,7 @@ void ORowSetValue::setTypeKind(sal_Int32 _eType)
}
-void ORowSetValue::free()
+void ORowSetValue::free() noexcept
{
if(!m_bNull)
{
@@ -470,7 +470,7 @@ ORowSetValue& ORowSetValue::operator=(const ORowSetValue& _rRH)
return *this;
}
-ORowSetValue& ORowSetValue::operator=(ORowSetValue&& _rRH)
+ORowSetValue& ORowSetValue::operator=(ORowSetValue&& _rRH) noexcept
{
if ( m_eTypeKind != _rRH.m_eTypeKind || !m_bNull)
free();
diff --git a/connectivity/source/commontools/dbmetadata.cxx b/connectivity/source/commontools/dbmetadata.cxx
index 026381e0377b..d345aec78cac 100644
--- a/connectivity/source/commontools/dbmetadata.cxx
+++ b/connectivity/source/commontools/dbmetadata.cxx
@@ -188,7 +188,7 @@ namespace dbtools
{
}
- DatabaseMetaData::DatabaseMetaData( DatabaseMetaData&& _copyFrom )
+ DatabaseMetaData::DatabaseMetaData(DatabaseMetaData&& _copyFrom) noexcept
:m_pImpl(std::move(_copyFrom.m_pImpl))
{
}
@@ -202,7 +202,7 @@ namespace dbtools
return *this;
}
- DatabaseMetaData& DatabaseMetaData::operator=( DatabaseMetaData&& _copyFrom )
+ DatabaseMetaData& DatabaseMetaData::operator=(DatabaseMetaData&& _copyFrom) noexcept
{
m_pImpl = std::move(_copyFrom.m_pImpl);
return *this;