diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2019-12-14 12:57:36 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2019-12-14 13:40:18 +0100 |
| commit | 736229b20c94c502c91e2177fdd1719719c0a083 (patch) | |
| tree | aec3dd1163e41332fdf30dc10f218ee9a2b89054 /config_host | |
| parent | f6064b13586aa8681907b69e4f43643251f9b803 (diff) | |
Rename HAVE_GCC_BUG_87150 to HAVE_P1155R3
...to match the new reality (see comment in config_host/config_global.h.in)
Change-Id: I5450e520d8b82584e3fd71d7e42a6840993b5ddb
Reviewed-on: https://gerrit.libreoffice.org/85142
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'config_host')
| -rw-r--r-- | config_host/config_global.h.in | 18 |
1 files changed, 15 insertions, 3 deletions
diff --git a/config_host/config_global.h.in b/config_host/config_global.h.in index 5b04594c12f5..f7672d211647 100644 --- a/config_host/config_global.h.in +++ b/config_host/config_global.h.in @@ -32,8 +32,20 @@ Any change in this header will cause a rebuild of almost everything. // Useable C++2a <span>: #define HAVE_CPP_SPAN 0 -/* GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87150> "move ctor wrongly chosen in return - stmt (derived vs. base)": */ -#define HAVE_GCC_BUG_87150 0 +/* "CWG motion 23: P1825R0 'Merged wording for P0527R1 and P1155R3' (DR)" in + <https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/n4829.html> "N4829 Editors' Report -- + Programming Languages -- C++" marks + <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1155r3.html> "More implicit moves" as a + DR. Some versions of GCC already implemented it prior to the fix for + <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87150> "move ctor wrongly chosen in return stmt + (derived vs. base)"; MSVC++ 14.24 started to implement it, see <https:// + developercommunity.visualstudio.com/content/problem/852827/ + msvc-1424-started-to-chose-move-ctor-in-return-der.html> "MSVC++ 14.24 started to chose move ctor + in return derived vs. base". At least Clang 9, which does not implement it, emits + -Werror,-Wreturn-std-move when it therefore considers a std::move to be missing. On the other + hand, at least some versions of GCC would emit -Werror=redundant-move in places where such a + std::move would be added unconditionally, see c00948d9bd35dfb15a331c2163f32e9ee24644fd "Silence + bogus -Werror=redundant-move (GCC 9)". */ +#define HAVE_P1155R3 0 #endif |