summaryrefslogtreecommitdiff
path: root/compilerplugins
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2017-11-30 08:43:10 +0100
committerChristian Lohmaier <lohmaier+LibreOffice@googlemail.com>2017-12-01 16:24:21 +0100
commitfaf10d47142d6dde25b6d6c5f7994340075ab7ac (patch)
tree7c1e7f85ebdc9c240c3baee90184bca3727bef2e /compilerplugins
parenta7d05b67775fac5c6d2d92a2a37871860aa630c0 (diff)
Move loplugin:fpcomparison to store/
...after bc4e8de8eea1ccebda479c8e2db2f3c6dfff60d2 "Silence new loplugin:fpcomparison for now": > Nov 30 08:33:16 <sberg> noelgrandin, thoughts on whether fpcomparison is actually worth it, seeing the loooooooong blacklist there? > Nov 30 08:34:11 <noelgrandin> sberg, that's wasn't my idea, can't remember who came up with it. vmiklos was that you? > Nov 30 08:34:36 <noelgrandin> sberg, the original commit message was "Find code that compares floating point values with == or != > Nov 30 08:34:36 <noelgrandin> It should rather use rtl::math::approxEqual" > Nov 30 08:34:45 <noelgrandin> so in theory the replacement should be fairly manual > Nov 30 08:34:48 <vmiklos> i don't think so :) > Nov 30 08:35:15 <noelgrandin> might have been moggi, but he's not around so.... just disable it > Nov 30 08:36:19 <sberg> noelgrandin, yeah, in theory; in practice, I guess there's also cases where x==1.0 is what you want exactly (given x tends not to be a computed value after all, but some literal that's being passed around) > Nov 30 08:36:33 <sberg> noelgrandin, yeah, I'll disable it then Change-Id: I35f5328efa0ec02d9be837c12efab2b03a3dae52 Reviewed-on: https://gerrit.libreoffice.org/45550 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit bf59f89d8818f62b03acaf7820e1a9560a388252) Reviewed-on: https://gerrit.libreoffice.org/45658 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Diffstat (limited to 'compilerplugins')
-rw-r--r--compilerplugins/clang/store/fpcomparison.cxx (renamed from compilerplugins/clang/fpcomparison.cxx)0
1 files changed, 0 insertions, 0 deletions
diff --git a/compilerplugins/clang/fpcomparison.cxx b/compilerplugins/clang/store/fpcomparison.cxx
index b5026fe21210..b5026fe21210 100644
--- a/compilerplugins/clang/fpcomparison.cxx
+++ b/compilerplugins/clang/store/fpcomparison.cxx