diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-09 16:27:11 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-22 12:47:37 +0200 |
| commit | 76dd28afc9c0eb632a5dd20eb51704ee0bbc4b58 (patch) | |
| tree | 82c51d09721476a1a6fcbf1e4cd4af8189ac55a2 /compilerplugins | |
| parent | 78490b45c771a4c9632b324922f2c8e83f06153b (diff) | |
loplugin:staticvar in various
looks for variables that can be declared const and static i.e. they can
be stored in the read-only linker segment and shared between different
processes
Change-Id: I8ddc6e5fa0f6b10d80c75d5952df8ddd311cf892
Reviewed-on: https://gerrit.libreoffice.org/61591
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/staticvar.cxx | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/compilerplugins/clang/staticvar.cxx b/compilerplugins/clang/staticvar.cxx index a9db2f4dda04..37156a283c33 100644 --- a/compilerplugins/clang/staticvar.cxx +++ b/compilerplugins/clang/staticvar.cxx @@ -76,7 +76,10 @@ public: // aHTMLOptionTab is ordered by useful grouping, so let it sort at runtime || fn == SRCDIR "/svtools/source/svhtml/htmlkywd.cxx" // TODO sorting some of these tables will be a lot of work... - || fn == SRCDIR "/sw/source/filter/ww8/ww8par6.cxx") + || fn == SRCDIR "/sw/source/filter/ww8/ww8par6.cxx" + // this only triggers on older versions of clang, not sure why + // in any case, it is actually about the array in vcl/inc/units.hrc, which we can't change + || fn == SRCDIR "/vcl/source/app/svdata.cxx") return; TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); } @@ -198,7 +201,7 @@ bool StaticVar::VisitVarDecl(VarDecl const* varDecl) return true; } -loplugin::Plugin::Registration<StaticVar> X("staticvar", false); +loplugin::Plugin::Registration<StaticVar> X("staticvar", true); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |