diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2018-11-07 16:01:30 +0100 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2018-11-14 16:05:55 +0100 |
| commit | 2dbda86cca1301b81a4232a6f0c03559da5ed7f4 (patch) | |
| tree | 7c1506c668939cb2b0f003bdc8e64012a0ea9a7e /compilerplugins | |
| parent | 698942ac73b8502eb1957b70dd165023e8d54c82 (diff) | |
make ScInterpreterContext also accessible without passing it around
E.g. ScModelObj::GetFormatter() can be rather deep in the call chain
and it just doesn't make sense to pass ScInterpreterContext* to
all the relevant places (and it's a question if it makes sense
to pass it around at all, googling shows that thread_local is not
really _that_ slow).
Change-Id: I9114ef8a10d82a10968391718099edccde7a2663
Reviewed-on: https://gerrit.libreoffice.org/63184
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/badstatics.cxx | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/compilerplugins/clang/badstatics.cxx b/compilerplugins/clang/badstatics.cxx index 43c26558ccbc..39b99e6de71e 100644 --- a/compilerplugins/clang/badstatics.cxx +++ b/compilerplugins/clang/badstatics.cxx @@ -197,6 +197,8 @@ public: || name == "m_aUncommitedRegistrations" // sw/source/uibase/dbui/dbmgr.cxx || (loplugin::DeclCheck(pVarDecl).Var("aAllListeners") .Class("ScAddInListener").GlobalNamespace()) // not owning + || (loplugin::DeclCheck(pVarDecl).Var("maThreadSpecific") + .Class("ScDocument").GlobalNamespace()) // not owning || name == "s_pLOKWindowsMap" // LOK only, guarded by assert, and LOK never tries to perform a VCL cleanup || name == "gStaticManager" // vcl/source/graphic/Manager.cxx - stores non-owning pointers ) // these variables appear unproblematic |